1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
|
## name Unspectacular die
## failures 3
## cut
die 'A horrible death' if $condtion;
if ($condition) {
die 'A horrible death';
}
open my $fh, '<', $path or
die "Can't open file $path";
#-----------------------------------------------------------------------------
## name Unspectacular warn
## failures 3
## cut
warn 'A horrible warning' if $condtion;
if ($condition) {
warn 'A horrible warning';
}
open my $fh, '<', $path or
warn "Can't open file $path";
#-----------------------------------------------------------------------------
## name Carping
## failures 0
## cut
carp 'A horrible death' if $condtion;
if ($condition) {
carp 'A horrible death';
}
open my $fh, '<', $path or
carp "Can't open file $path";
#-----------------------------------------------------------------------------
## name No croaking
## failures 1
## cut
die 'A horrible death';
#-----------------------------------------------------------------------------
## name Complain about cases without arguments.
## failures 2
## cut
die;
die
#-----------------------------------------------------------------------------
## name Complain about cases with empty list arguments.
## failures 2
## cut
die ( );
die ( )
#-----------------------------------------------------------------------------
## name Complain about cases with non-string arguments.
## failures 7
## cut
die $error;
die @errors;
die %errors_by_id;
die $errors[0];
die $errors_by_id{"Cheese fondue overflow"};
die $marvin_gaye->whats_goin_on();
die $george_washington->cross("Delaware River\n");
#-----------------------------------------------------------------------------
## name Don't complain about obvious uses of references because they're likely being used as exception objects.
## TODO not yet implemented
## failures 0
## cut
die \$frobnication_exception;
die \@accumulated_warnings;
die \%problem_data;
die
[
'process.html: missing standard section separator comments',
'green.css: uses non-standard font "Broken 15"',
'cat.jpg: missing copyright information in Exif metadata',
];
die
{
message => 'Found duplicate entries',
file => $current_file,
parser => $self,
occurrences => $occurrences,
duplicated => $entry_content,
};
die Blrfl::Exception->new('Too many croutons', $salad);
#-----------------------------------------------------------------------------
## name Don't complain if message ends with "\n" in double quotes.
## failures 0
## cut
die "A horrible death\n" ;
die "A horrible death\n" # last statement doesn't need a terminator
#-----------------------------------------------------------------------------
## name Don't complain if message ends with literal "\n" (RT #25046)
## failures 0
## cut
die "A horrible death
" ;
die 'A horrible death
' ;
die q{A horrible death
} ;
die qq{A horrible death
} ;
#-----------------------------------------------------------------------------
## name Don't complain if message is a heredoc, which must end in "\n"
## failures 0
## cut
die <<'eod' ;
A horrible death
eod
die <<'eod' # last statement doesn't need a terminator
A horrible death
eod
#-----------------------------------------------------------------------------
## name Complain if message ends with "\n" in single quotes.
## failures 2
## cut
die 'A horrible death\n' ;
die 'A horrible death\n' # last statement doesn't need a terminator
#-----------------------------------------------------------------------------
## name Don't complain if message ends with "\n" in interpolated quotelike operator.
## failures 0
## cut
die qq{A horrible death\n} ;
die qq#A horrible death\n# ;
die qq/A horrible death\n/ # last statement doesn't need a terminator
#-----------------------------------------------------------------------------
## name Complain if message ends with "\n" in non-interpolated quotelike operator.
## failures 3
## cut
die q{A horrible death\n} ;
die q#A horrible death\n# ;
die q/A horrible death\n/ # last statement doesn't need a terminator
#-----------------------------------------------------------------------------
## name Don't complain if message is a list with a last element that ends with "\n"
## failures 0
## cut
die q{Don't }, $die, " a horrible death\n" ;
die qq{Don't }, $die, qq/ a horrible death\n/ ;
die q{Don't }, $die, " a horrible death\n" , ;
die q{Don't }, $die, " a horrible death\n" , # last statement doesn't need a terminator
#-----------------------------------------------------------------------------
## name Don't complain if message is a parenthesised list with a last element that ends with "\n"
## failures 0
## cut
die ( q{Don't }, $die, " a horrible death\n" ) ;
die ( qq{Don't }, $die, qq/ a horrible death\n/ ) ;
die ( qq{Don't }, $die, qq/ a horrible death\n/ ) , ;
die ( q{Don't }, $die, " a horrible death\n" , ) # last statement doesn't need a terminator
#-----------------------------------------------------------------------------
## name Don't complain if message is a list with "sub" lists with a last (flattened list) element that ends with "\n"
## failures 0
## cut
# all these tests are necessary (different PPI trees)
# one element in a sub list
die q{Don't } , ( $die ) , " a horrible death\n" ;
die q{Don't } , $die , ( " a horrible death\n" ) ;
# sub list and a bare element
die q{Don't } , ( $die , " a horrible death\n" ) ;
# two sub lists
die q{Don't } , ( $die ) , ( " a horrible death\n" ) ;
# sub sub lists
die ( ( q{Don't } ) , $die , " a horrible death\n" ) ;
die ( q{Don't } , $die , ( " a horrible death\n" ) ) ;
die ( q{Don't } , ( $die , ( " a horrible death\n" ) ) ) ;
die ( ( q{Don't } , ( $die , ( " a horrible death\n" ) ) ) ) ;
# play with extra commas
die ( ( q{Don't } , ( $die , ( " a horrible death\n" , ) , ) , ) , ) , ;
die ( ( q{Don't } , ( $die , ( " a horrible death\n" , ) , ) , ) , ) ,
#-----------------------------------------------------------------------------
## name Complain if message is a list with "sub" lists with a last (flattened list) element that doesn't end with "\n"
## failures 10
## cut
# all these tests are necessary: make sure that the policy knows when to
# stop looking.
# one element in a sub list
die q{Don't } , ( $die ) , @a_horrible_death ;
die q{Don't } , $die , ( @a_horrible_death ) ;
# sub list and a bare element
die q{Don't } , ( $die , @a_horrible_death ) ;
# two sub lists
die q{Don't } , ( $die ) , ( @a_horrible_death ) ;
# sub sub lists
die ( ( q{Don't } ) , $die , @a_horrible_death ) ;
die ( q{Don't } , $die , ( @a_horrible_death ) ) ;
die ( q{Don't } , ( $die , ( @a_horrible_death ) ) ) ;
die ( ( q{Don't } , ( $die , ( @a_horrible_death ) ) ) ) ;
# play with extra commas
die ( ( q{Don't } , ( $die , ( @a_horrible_death , ) , ) , ) , ) , ;
die ( ( q{Don't } , ( $die , ( @a_horrible_death , ) , ) , ) , ) ,
#-----------------------------------------------------------------------------
## name Don't complain if message is a concatenation with a last element that ends with "\n"
## failures 0
## cut
die q{Don't } . $die . " a horrible death\n" ;
die ( q{Don't } . $die . " a horrible death\n" ) ;
##-----------------------------------------------------------------------------
## name Complain if message has a last element that ends with "\n" but has an operation in front
## failures 2
## cut
die q{Don't } . $die . length " a horrible death\n" ;
die ( q{Don't } . $die . length " a horrible death\n" ) ;
#-----------------------------------------------------------------------------
## name Don't complain if followed by postfix operator and otherwise valid.
## failures 0
## cut
die "A horrible death\n" if $self->is_a_bad_guy();
die "A horrible death\n" unless $self->rescued_from_the_sinking_ship();
die "A horrible death\n" while $deep_sense_of_guilt;
die "A horrible death\n" until $clear_conscience;
die "A horrible death\n" for @your_crimes;
die "A horrible death\n" foreach @{ $songs_sung_off_key };
die 'A horrible ', "death\n" if $self->is_a_bad_guy();
die 'A horrible ', "death\n" unless $self->rescued_from_the_sinking_ship();
die 'A horrible ', "death\n" while $deep_sense_of_guilt;
die 'A horrible ', "death\n" until $clear_conscience;
die 'A horrible ', "death\n" for @your_crimes;
die 'A horrible ', "death\n" foreach @{ $songs_sung_off_key };
die ( 'A horrible ', "death\n" ) if $self->is_a_bad_guy();
die ( 'A horrible ', "death\n" ) unless $self->rescued_from_the_sinking_ship();
die ( 'A horrible ', "death\n" ) while $deep_sense_of_guilt;
die ( 'A horrible ', "death\n" ) until $clear_conscience;
die ( 'A horrible ', "death\n" ) for @your_crimes;
die ( 'A horrible ', "death\n" ) foreach @{ $songs_sung_off_key };
die ( 'A horrible ' . "death\n" ) if $self->is_a_bad_guy();
die ( 'A horrible ' . "death\n" ) unless $self->rescued_from_the_sinking_ship();
die ( 'A horrible ' . "death\n" ) while $deep_sense_of_guilt;
die ( 'A horrible ' . "death\n" ) until $clear_conscience;
die ( 'A horrible ' . "death\n" ) for @your_crimes;
die ( 'A horrible ' . "death\n" ) foreach @{ $songs_sung_off_key };
#-----------------------------------------------------------------------------
## name Complain if followed by postfix operator with "\n" ending last operand and otherwise invalid.
## failures 24
## cut
die "A horrible death" if "Matagami\n";
die "A horrible death" unless "Enniscorthy\n";
die "A horrible death" while "Htargcm\n";
die "A horrible death" until "Akhalataki\n";
die "A horrible death" for "Fleac\n";
die "A horrible death" foreach "Uist\n";
die 'A horrible ', "death" if "Matagami\n";
die 'A horrible ', "death" unless "Enniscorthy\n";
die 'A horrible ', "death" while "Htargcm\n";
die 'A horrible ', "death" until "Akhalataki\n";
die 'A horrible ', "death" for "Fleac\n";
die 'A horrible ', "death" foreach "Uist\n";
die ( 'A horrible ', "death" ) if "Matagami\n";
die ( 'A horrible ', "death" ) unless "Enniscorthy\n";
die ( 'A horrible ', "death" ) while "Htargcm\n";
die ( 'A horrible ', "death" ) until "Akhalataki\n";
die ( 'A horrible ', "death" ) for "Fleac\n";
die ( 'A horrible ', "death" ) foreach "Uist\n";
die ( 'A horrible ' . "death" ) if "Matagami\n";
die ( 'A horrible ' . "death" ) unless "Enniscorthy\n";
die ( 'A horrible ' . "death" ) while "Htargcm\n";
die ( 'A horrible ' . "death" ) until "Akhalataki\n";
die ( 'A horrible ' . "death" ) for "Fleac\n";
die ( 'A horrible ' . "death" ) foreach "Uist\n";
#-----------------------------------------------------------------------------
## name Complain if config doesn't allow newlines.
## failures 1
## parms { allow_messages_ending_with_newlines => 0 }
## cut
die "A horrible death\n" ;
#-----------------------------------------------------------------------------
## name Complain if in main:: and option not set (RT #56619)
## failures 1
## cut
package main;
die "A horrible death";
#-----------------------------------------------------------------------------
## name Don't complain if in main:: and option set (RT #56619)
## failures 0
## parms { allow_in_main_unless_in_subroutine => 1 }
## cut
package main;
die "A horrible death";
#-----------------------------------------------------------------------------
## name Don't complain if implicitly in main:: and option set (RT #56619)
## failures 0
## parms { allow_in_main_unless_in_subroutine => 1 }
## cut
die "A horrible death";
#-----------------------------------------------------------------------------
## name Complain if in main:: but in subroutine (RT #56619)
## parms { allow_in_main_unless_in_subroutine => 1 }
## failures 1
## cut
sub foo {
die "Goodbye, cruel world!";
}
#-----------------------------------------------------------------------------
## name Complain if in main:: but in anonymous subroutine (RT #56619)
## parms { allow_in_main_unless_in_subroutine => 1 }
## failures 1
## cut
my $foo = sub {
die "Goodbye, cruel world!";
};
#-----------------------------------------------------------------------------
# Local Variables:
# mode: cperl
# cperl-indent-level: 4
# fill-column: 78
# indent-tabs-mode: nil
# c-indentation-style: bsd
# End:
# ex: set ts=8 sts=4 sw=4 tw=78 ft=perl expandtab shiftround :
|
