1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393
|
## name open .. close
## failures 0
## cut
open my $fh1, '<', $filename or die;
close $fh1;
open my $fh2, '<', $filename or die;
close $fh2;
if (open my $fh3, '<', $filename) {
close $fh3;
}
my $fh4;
open $fh4, '<', $filename or die;
close $fh4;
#-----------------------------------------------------------------------------
## name OO
## failures 0
## cut
open my $fh1, '<', $filename or die;
$fh1->close;
#-----------------------------------------------------------------------------
## name else
## failures 0
## cut
if (!open my $fh3, '<', $filename) {
croak;
} else {
close $fh3;
}
#-----------------------------------------------------------------------------
## name while .. print
## failures 0
## cut
open my $fh1, '<', $filename or die;
while (<$fh1>) {
print;
}
close $fh1;
if (open my $fh2, '<', $filename) {
while (<$fh2>) {
print;
}
close $fh2;
}
#-----------------------------------------------------------------------------
## name basic failures
## failures 2
## cut
open my $fh1, '<', $filename or die;
close $fh0;
if (open my $fh2, '<', $filename) {
while (<$fh2>) {
print;
}
}
#-----------------------------------------------------------------------------
## name lexical wrong name failure
## failures 2
## cut
open my $fh1, '<', $filename or die;
close $fh2;
open my $fh3, '<', $filename or die;
$fh4->close;
#-----------------------------------------------------------------------------
## name scope failure
## failures 1
## cut
{
open my $fh1, '<', $filename;
}
close $fh1;
#-----------------------------------------------------------------------------
## name glob scope failure; no longer fails w/ RT #64437 applied.
## failures 0
## cut
{
open FH1, '<', $filename;
}
close FH1;
#-----------------------------------------------------------------------------
## name glob filehandle
## failures 0
## cut
local (*FH1);
open FH1, '<', $filename or die;
close FH1;
#-----------------------------------------------------------------------------
## name glob failure
## failures 2
## cut
local (*FH2);
open FH2, '<', $filename or die;
open *FH3, '<', $filename or die;
#-----------------------------------------------------------------------------
## name glob wrong name failure
## failures 1
## cut
local (*FH1);
open FH1, '<', $filename or die;
close FH2;
#-----------------------------------------------------------------------------
## name we do not flag non-uppercase globs -- maybe it is a sub call
## failures 0
## cut
local (*fh1);
open fh1, '<', $filename or die;
#-----------------------------------------------------------------------------
## name fail blocks
## failures 2
## cut
my $foo;
open {$foo}, '<', $filename or die;
open {*BAR}, '<', $filename or die;
#-----------------------------------------------------------------------------
## name allow std handles
## failures 0
## cut
open STDIN, '<', $filename or die;
open STDOUT, '>', $filename or die;
open STDERR, '>', $filename or die;
#-----------------------------------------------------------------------------
## name allow std globs in blocks
## failures 0
## cut
open {*STDIN}, '<', $filename or die;
open {*STDOUT}, '>', $filename or die;
open {*STDERR}, '>', $filename or die;
#-----------------------------------------------------------------------------
## name config - pass at default
## failures 0
## cut
open my $fh1, '<', $filename;
# 1
# 2
# 3
# 4
# 5
# 6
# 7
# 8
close $fh1;
#-----------------------------------------------------------------------------
## name config - fail at one after default
## failures 1
## cut
open my $fh1, '<', $filename;
# 1
# 2
# 3
# 4
# 5
# 6
# 7
# 8
# 9
close $fh1;
#-----------------------------------------------------------------------------
## name config - set lines to 2
## failures 1
## parms {lines => '2'}
## cut
open my $fh1, '<', $filename;
# 1
close $fh1;
open my $fh2, '<', $filename;
# 1
# 2
close $fh2;
#-----------------------------------------------------------------------------
## name nested sub
## failures 1
## cut
open my $fh1, '<', $filename;
sub not_a_recommended_idiom {
close $fh1;
}
#-----------------------------------------------------------------------------
## name opener sub
## failures 0
## cut
sub my_open {
my ($filename) = @_;
open my $fh1, '<', $filename or return;
return $fh1;
}
#-----------------------------------------------------------------------------
## name long opener sub failure
## failures 1
## cut
sub my_open {
my ($filename) = @_;
open my $fh1, '<', $filename or return;
# 1
# 2
# 3
# 4
# 5
# 6
# 7
# 8
# 9
return $fh1;
}
#-----------------------------------------------------------------------------
## name opener sub failure
## failures 1
## cut
sub my_open {
my ($filename) = @_;
open my $fh1, '<', $filename or return;
return $fh2;
}
#-----------------------------------------------------------------------------
## name unusual lexical syntax
## failures 1
## TODO we do not recognize parenthesized lexical declarations
## cut
open my ($fh1), '<', $filename;
#-----------------------------------------------------------------------------
## name code coverage - unsupported open() calls
## failures 0
## cut
$self->open($door);
open($fh); # erroneous call
open(get_fh(), '<', $filename); # first arg returns a filehandle -- bad form
open(1 + 1, '<', $filename); # nonsense
#-----------------------------------------------------------------------------
## name code coverage - glob topic for method call
## failures 1
## cut
open FH1, '<', $filename;
FH1->close; # invalid code
#-----------------------------------------------------------------------------
## name code coverage - close is not a function or method call
## failures 1
## cut
open my $fh, '<', $filename;
$hash->{close};
#-----------------------------------------------------------------------------
## name code coverage - FH is not a glob or scalar
## failures 0
## cut
open @foo, '<', $filename; # nonsense
open @$foo, '<', $filename; # nonsense
open my @bar, '<', $filename; # nonsense
#-----------------------------------------------------------------------------
## name CORE::close() - RT #52391
## failures 0
## cut
open( my $fh, '<', $filename );
my $value = <$fh>;
CORE::close($fh);
#-----------------------------------------------------------------------------
## name CORE::GLOBAL::close()
## failures 0
## cut
open my $fh, '<', $filename;
my $value = <$fh>;
CORE::GLOBAL::close($fh);
#-----------------------------------------------------------------------------
## name CORE::open()
## failures 1
## cut
CORE::open my $fh, '<', $filename;
#-----------------------------------------------------------------------------
## name CORE::GLOBAL::open()
## failures 1
## cut
CORE::GLOBAL::open(my $fh, '<', $filename);
#-----------------------------------------------------------------------------
## name Handle declared in outer scope RT #64437
## failures 0
## cut
#!/usr/bin/perl
my $file = 'fubar';
my ($fh, @lines);
if (! open $fh, '<', $file) {
croak "Error opening $file for reading: $!";
}
@lines = <$fh>;
if (! close $fh) {
croak "Error closing $file after reading: $!";
}
#-----------------------------------------------------------------------------
# Local Variables:
# mode: cperl
# cperl-indent-level: 4
# fill-column: 78
# indent-tabs-mode: nil
# c-indentation-style: bsd
# End:
# ex: set ts=8 sts=4 sw=4 tw=78 ft=perl expandtab shiftround :
|