1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
|
## name basic failures
## failures 12
## cut
open $fh, ">$output";
open($fh, ">$output");
open($fh, ">$output") or die;
open my $fh, ">$output";
open(my $fh, ">$output");
open(my $fh, ">$output") or die;
open FH, ">$output";
open(FH, ">$output");
open(FH, ">$output") or die;
#This are tricky because the Critic can't
#tell where the expression really ends
open FH, ">$output" or die;
open $fh, ">$output" or die;
open my $fh, ">$output" or die;
#-----------------------------------------------------------------------------
## name basic passes
## failures 0
## cut
open $fh, '>', $output;
open($fh, '>', $output);
open($fh, '>', $output) or die;
open my $fh, '>', $output;
open(my $fh, '>', $output);
open(my $fh, '>', $output) or die;
open FH, '>', $output;
open(FH, '>', $output);
open(FH, '>', $output) or die;
#This are tricky because the Critic can't
#tell where the expression really ends
open $fh, '>', $output or die;
open my $fh, '>', $output or die;
open FH, '>', $output or die;
$foo{open}; # not a function call
#-----------------------------------------------------------------------------
## name no three-arg equivalent passes
## failures 0
## cut
open( STDOUT, '>&STDOUT' );
open( STDIN, '>&STDIN' );
open( STDERR, '>&STDERR' );
open( \*STDOUT, '>&STDERR' );
open( *STDOUT, '>&STDERR' );
open( STDOUT, '>&STDERR' );
# These are actually forks
open FH, '-|';
open FH, '|-';
open FH, q{-|};
open FH, qq{-|};
open FH, "-|";
# Other file modes.
open( \*STDOUT, '>>&STDERR' );
open( \*STDOUT, '<&STDERR' );
open( \*STDOUT, '+>&STDERR' );
open( \*STDOUT, '+>>&STDERR' );
open( \*STDOUT, '+<&STDERR' );
#-----------------------------------------------------------------------------
## name pass with "use 5.005"
## failures 0
## cut
open $fh, ">$output";
use 5.005;
#-----------------------------------------------------------------------------
## name fail with "use 5.006"
## failures 1
## cut
open $fh, ">$output";
use 5.006;
#-----------------------------------------------------------------------------
## name rt44554 two arg open should fail
## failures 1
## cut
open my $a, 'testing' or die 'error: ', $!;
#-----------------------------------------------------------------------------
# Local Variables:
# mode: cperl
# cperl-indent-level: 4
# fill-column: 78
# indent-tabs-mode: nil
# c-indentation-style: bsd
# End:
# ex: set ts=8 sts=4 sw=4 tw=78 ft=perl expandtab shiftround :
|
