1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
|
package Perl::Critic::Policy::Modules::ProhibitAutomaticExportation;
use 5.010001;
use strict;
use warnings;
use Readonly;
use Perl::Critic::Utils qw{ :severities };
use List::SomeUtils qw(any);
use parent 'Perl::Critic::Policy';
our $VERSION = '1.156';
#-----------------------------------------------------------------------------
Readonly::Scalar my $DESC => q{Symbols are exported by default};
Readonly::Scalar my $EXPL => q{Use '@EXPORT_OK' or '%EXPORT_TAGS' instead}; ## no critic (RequireInterpolation)
#-----------------------------------------------------------------------------
sub supported_parameters { return () }
sub default_severity { return $SEVERITY_HIGH }
sub default_themes { return qw( core bugs ) }
sub applies_to { return 'PPI::Document' }
#-----------------------------------------------------------------------------
sub violates {
my ( $self, undef, $doc ) = @_;
if ( _uses_exporter($doc) ) {
if ( my $exp = _has_exports($doc) ) {
return $self->violation( $DESC, $EXPL, $exp );
}
}
return; #ok
}
#-----------------------------------------------------------------------------
sub _uses_exporter {
my ($doc) = @_;
my $includes_ref = $doc->find('PPI::Statement::Include');
return if not $includes_ref;
# This covers both C<use Exporter;> and C<use parent 'Exporter';>
return any { m/ \b Exporter \b/xms } @{ $includes_ref };
}
#------------------
sub _has_exports {
my ($doc) = @_;
my $wanted =
sub { _our_export(@_) or _vars_export(@_) or _package_export(@_) };
return $doc->find_first( $wanted );
}
#------------------
sub _our_export {
my (undef, $elem) = @_;
$elem->isa('PPI::Statement::Variable') or return 0;
$elem->type() eq 'our' or return 0;
return any { $_ eq '@EXPORT' } $elem->variables(); ## no critic(RequireInterpolationOfMetachars)
}
#------------------
sub _vars_export {
my (undef, $elem) = @_;
$elem->isa('PPI::Statement::Include') or return 0;
$elem->pragma() eq 'vars' or return 0;
return $elem =~ m{ \@EXPORT \b }xms; #Crude, but usually works
}
#------------------
sub _package_export {
my (undef, $elem) = @_;
$elem->isa('PPI::Token::Symbol') or return 0;
return $elem =~ m{ \A \@ \S+ ::EXPORT \z }xms;
#TODO: ensure that it is in _this_ package!
}
1;
__END__
#-----------------------------------------------------------------------------
=pod
=head1 NAME
Perl::Critic::Policy::Modules::ProhibitAutomaticExportation - Export symbols via C<@EXPORT_OK> or C<%EXPORT_TAGS> instead of C<@EXPORT>.
=head1 AFFILIATION
This Policy is part of the core L<Perl::Critic|Perl::Critic>
distribution.
=head1 DESCRIPTION
When using L<Exporter|Exporter>, symbols placed in the C<@EXPORT>
variable are automatically exported into the caller's namespace.
Although convenient, this practice is not polite, and may cause
serious problems if the caller declares the same symbols. The best
practice is to place your symbols in C<@EXPORT_OK> or C<%EXPORT_TAGS>
and let the caller choose exactly which symbols to export.
package Foo;
use Exporter 'import';
our @EXPORT = qw(foo $bar @baz); # not ok
our @EXPORT_OK = qw(foo $bar @baz); # ok
our %EXPORT_TAGS = ( all => [ qw(foo $bar @baz) ] ); # ok
=head1 CONFIGURATION
This Policy is not configurable except for the standard options.
=head1 AUTHOR
Jeffrey Ryan Thalhammer <jeff@imaginative-software.com>
=head1 COPYRIGHT
Copyright (c) 2005-2023 Imaginative Software Systems. All rights reserved.
This program is free software; you can redistribute it and/or modify
it under the same terms as Perl itself. The full text of this license
can be found in the LICENSE file included with this module.
=cut
# Local Variables:
# mode: cperl
# cperl-indent-level: 4
# fill-column: 78
# indent-tabs-mode: nil
# c-indentation-style: bsd
# End:
# ex: set ts=8 sts=4 sw=4 tw=78 ft=perl expandtab shiftround :
|
