1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
|
package Perl::Critic::Policy::RegularExpressions::ProhibitEscapedMetacharacters;
use 5.010001;
use strict;
use warnings;
use Readonly;
use Perl::Critic::Utils qw( :severities hashify );
use parent 'Perl::Critic::Policy';
our $VERSION = '1.156';
#-----------------------------------------------------------------------------
Readonly::Scalar my $DESC => q{Use character classes for literal metachars instead of escapes};
Readonly::Scalar my $EXPL => [247];
Readonly::Hash my %REGEXP_METACHARS => hashify(split / /xms, '{ } ( ) . * + ? |');
#-----------------------------------------------------------------------------
sub supported_parameters { return qw() }
sub default_severity { return $SEVERITY_LOWEST }
sub default_themes { return qw( core pbp cosmetic ) }
sub applies_to { return qw(PPI::Token::Regexp::Match
PPI::Token::Regexp::Substitute
PPI::Token::QuoteLike::Regexp) }
#-----------------------------------------------------------------------------
sub violates {
my ( $self, $elem, $document ) = @_;
# optimization: don't bother parsing the regexp if there are no escapes
return if $elem !~ m/\\/xms;
my $re = $document->ppix_regexp_from_element( $elem ) or return;
$re->failures() and return;
my $qr = $re->regular_expression() or return;
my $exacts = $qr->find( 'PPIx::Regexp::Token::Literal' ) or return;
foreach my $exact( @{ $exacts } ) {
$exact->content() =~ m/ \\ ( . ) /xms or next;
return $self->violation( $DESC, $EXPL, $elem ) if $REGEXP_METACHARS{$1};
}
return; # OK
}
1;
__END__
#-----------------------------------------------------------------------------
=pod
=for stopwords IPv4
=head1 NAME
Perl::Critic::Policy::RegularExpressions::ProhibitEscapedMetacharacters - Use character classes for literal meta-characters instead of escapes.
=head1 AFFILIATION
This Policy is part of the core L<Perl::Critic|Perl::Critic>
distribution.
=head1 DESCRIPTION
Ever heard of leaning toothpick syndrome? That comes from writing
regular expressions that match on characters that are significant in
regular expressions. For example, the expression to match four
forward slashes looks like:
m/\/\/\/\//;
Well, this policy doesn't solve that problem (write it as C<m{////}>
instead!) but solves a related one. As seen above, the escapes make
the expression hard to parse visually. One solution is to use
character classes. You see, inside of character classes, the only
characters that are special are C<\>, C<]>, C<^> and C<->, so you
don't need to escape the others. So instead of the following loose
IPv4 address matcher:
m/ \d+ \. \d+ \. \d+ \. \d+ /x;
You could write:
m/ \d+ [.] \d+ [.] \d+ [.] \d+ /x;
which is certainly more readable, if less recognizable prior the
publication of Perl Best Practices. (Of course, you should really use
L<Regexp::Common::net|Regexp::Common::net> to match IPv4 addresses!)
Specifically, this policy forbids backslashes immediately prior to the
following characters:
{ } ( ) . * + ? | #
We make special exception for C<$> because C</[$]/> turns into
C</[5.008006/> for Perl 5.8.6. We also make an exception for C<^>
because it has special meaning (negation) in a character class.
Finally, C<[> and C<]> are exempt, of course, because they are awkward
to represent in character classes.
Note that this policy does not forbid unnecessary escaping. So go
ahead and (pointlessly) escape C<!> characters.
=head1 CONFIGURATION
This Policy is not configurable except for the standard options.
=head1 BUGS
Perl treats C<m/[#]/x> in unexpected ways.
I think it's a bug in Perl itself, but am not 100% sure that I have
not simply misunderstood...
This part makes sense:
"#f" =~ m/[#]f/x; # match
"#f" =~ m/[#]a/x; # no match
This doesn't:
$qr = qr/f/;
"#f" =~ m/[#]$qr/x; # no match
Neither does this:
print qr/[#]$qr/x; # yields '(?x-ism:[#]$qr
)'
=head1 CREDITS
Initial development of this policy was supported by a grant from the
Perl Foundation.
=head1 AUTHOR
Chris Dolan <cdolan@cpan.org>
=head1 COPYRIGHT
Copyright (c) 2007-2023 Chris Dolan
This program is free software; you can redistribute it and/or modify
it under the same terms as Perl itself. The full text of this license
can be found in the LICENSE file included with this module
=cut
# Local Variables:
# mode: cperl
# cperl-indent-level: 4
# fill-column: 78
# indent-tabs-mode: nil
# c-indentation-style: bsd
# End:
# ex: set ts=8 sts=4 sw=4 tw=78 ft=perl expandtab shiftround :
|
