1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440
|
package Perl::Critic::Policy::Subroutines::ProhibitUnusedPrivateSubroutines;
use 5.010001;
use strict;
use warnings;
use English qw< $EVAL_ERROR -no_match_vars >;
use List::SomeUtils qw(any);
use Readonly;
use Perl::Critic::Utils qw{
:characters hashify is_function_call is_method_call :severities
$EMPTY $TRUE
};
use parent 'Perl::Critic::Policy';
our $VERSION = '1.156';
#-----------------------------------------------------------------------------
Readonly::Scalar my $DESC =>
q{Private subroutine/method '%s' declared but not used};
Readonly::Scalar my $EXPL => q{Eliminate dead code};
Readonly::Hash my %IS_COMMA => hashify( $COMMA, $FATCOMMA );
#-----------------------------------------------------------------------------
sub supported_parameters {
return (
{
name => 'private_name_regex',
description => 'Pattern that determines what a private subroutine is.',
default_string => '\b_\w+\b', ## no critic (RequireInterpolationOfMetachars)
behavior => 'string',
parser => \&_parse_regex_parameter,
},
{
name => 'allow',
description =>
q<Subroutines matching the private name regex to allow under this policy.>,
default_string => $EMPTY,
behavior => 'string list',
},
{
name => 'skip_when_using',
description =>
q<Modules that, if used within a file, will cause the policy to be disabled for this file>,
default_string => $EMPTY,
behavior => 'string list',
},
{
name => 'allow_name_regex',
description =>
q<Pattern defining private subroutine names that are always allowed>,
default_string => $EMPTY,
behavior => 'string',
parser => \&_parse_regex_parameter,
},
);
}
sub default_severity { return $SEVERITY_MEDIUM }
sub default_themes { return qw( core maintenance certrec ) }
sub applies_to { return 'PPI::Statement::Sub' }
#-----------------------------------------------------------------------------
sub _parse_regex_parameter {
my ($self, $parameter, $config_string) = @_;
$config_string //= $parameter->get_default_string();
my $regex;
eval { $regex = qr/$config_string/; 1 } ## no critic (RegularExpressions)
or $self->throw_parameter_value_exception(
$parameter,
$config_string,
undef,
"is not a valid regular expression: $EVAL_ERROR",
);
$self->__set_parameter_value($parameter, $regex);
return;
}
#-----------------------------------------------------------------------------
sub violates {
my ( $self, $elem, $document ) = @_;
my @skip_modules = keys %{ $self->{_skip_when_using} };
return if any { $document->uses_module($_) } @skip_modules;
# Not interested in forward declarations, only the real thing.
$elem->forward() and return;
# Not interested in subs without names.
my $name = $elem->name() or return;
# If the sub is shoved into someone else's name space, we wimp out.
$name =~ m/ :: /smx and return;
# If the name is explicitly allowed, we just return (OK).
$self->{_allow}{$name} and return;
# Allow names that match the 'allow_name_regex' pattern.
if ($self->{_allow_name_regex}) {
$name =~ m/ \A $self->{_allow_name_regex} \z /smx and return;
}
# If the name is not an anonymous subroutine according to our definition,
# we just return (OK).
$name =~ m/ \A $self->{_private_name_regex} \z /smx or return;
# If the subroutine is called in the document, just return (OK).
return if _find_sub_call_in_document( $elem, $document );
# If the subroutine is referred to in the document, just return (OK).
return if _find_sub_reference_in_document( $elem, $document );
# If the subroutine is used in an overload, just return (OK).
return if _find_sub_overload_in_document( $elem, $document );
# No uses of subroutine found. Return a violation.
return $self->violation( sprintf( $DESC, $name ), $EXPL, $elem );
}
# Basically the spaceship operator for token locations. The arguments are the
# two tokens to compare. If either location is unavailable we return undef.
sub _compare_token_locations {
my ( $left_token, $right_token ) = @_;
my $left_loc = $left_token->location() or return;
my $right_loc = $right_token->location() or return;
return $left_loc->[0] <=> $right_loc->[0] ||
$left_loc->[1] <=> $right_loc->[1];
}
# Find out if the subroutine defined in $elem is called in $document. Calls
# inside the subroutine itself do not count.
sub _find_sub_call_in_document {
my ( $elem, $document ) = @_;
my $start_token = $elem->first_token();
my $finish_token = $elem->last_token();
my $name = $elem->name();
if ( my $found = $document->find( 'PPI::Token::Word' ) ) {
foreach my $usage ( @{ $found } ) {
$name eq $usage->content() or next;
is_function_call( $usage )
or is_method_call( $usage )
or next;
_compare_token_locations( $usage, $start_token ) < 0
and return $TRUE;
_compare_token_locations( $finish_token, $usage ) < 0
and return $TRUE;
}
}
foreach my $regexp ( _find_regular_expressions( $document ) ) {
_compare_token_locations( $regexp, $start_token ) >= 0
and _compare_token_locations( $finish_token, $regexp ) >= 0
and next;
_find_sub_usage_in_regexp( $name, $regexp, $document )
and return $TRUE;
}
return;
}
# Find analyzable regular expressions in the given document. This means
# matches, substitutions, and the qr{} operator.
sub _find_regular_expressions {
my ( $document ) = @_;
return ( map { @{ $document->find( $_ ) || [] } } qw{
PPI::Token::Regexp::Match
PPI::Token::Regexp::Substitute
PPI::Token::QuoteLike::Regexp
} );
}
# Find out if the subroutine named in $name is called in the given $regexp.
# This could happen either by an explicit s/.../.../e, or by interpolation
# (i.e. @{[...]} ).
sub _find_sub_usage_in_regexp {
my ( $name, $regexp, $document ) = @_;
my $ppix = $document->ppix_regexp_from_element( $regexp ) or return;
$ppix->failures() and return;
foreach my $code ( @{ $ppix->find( 'PPIx::Regexp::Token::Code' ) || [] } ) {
my $doc = $code->ppi() or next;
foreach my $word ( @{ $doc->find( 'PPI::Token::Word' ) || [] } ) {
$name eq $word->content() or next;
is_function_call( $word )
or is_method_call( $word )
or next;
return $TRUE;
}
}
return;
}
# Find out if the subroutine defined in $elem handles an overloaded operator.
# We recognize both string literals (the usual form) and words (in case
# someone perversely followed the subroutine name by a fat comma). We ignore
# the '\&_foo' construction, since _find_sub_reference_in_document() should
# find this.
sub _find_sub_overload_in_document {
my ( $elem, $document ) = @_;
my $name = $elem->name();
if ( my $found = $document->find( 'PPI::Statement::Include' ) ) {
foreach my $usage ( @{ $found } ) {
'overload' eq $usage->module() or next;
my $inx;
foreach my $arg ( _get_include_arguments( $usage ) ) {
$inx++ % 2 or next;
@{ $arg } == 1 or next;
my $element = $arg->[0];
if ( $element->isa( 'PPI::Token::Quote' ) ) {
$element->string() eq $name and return $TRUE;
} elsif ( $element->isa( 'PPI::Token::Word' ) ) {
$element->content() eq $name and return $TRUE;
}
}
}
}
return;
}
# Find things of the form '&_foo'. This includes both references proper (i.e.
# '\&foo'), calls using the sigil, and gotos. The latter two do not count if
# inside the subroutine itself.
sub _find_sub_reference_in_document {
my ( $elem, $document ) = @_;
my $start_token = $elem->first_token();
my $finish_token = $elem->last_token();
my $symbol = q<&> . $elem->name();
if ( my $found = $document->find( 'PPI::Token::Symbol' ) ) {
foreach my $usage ( @{ $found } ) {
$symbol eq $usage->content() or next;
my $prior = $usage->sprevious_sibling();
$prior
and $prior->isa( 'PPI::Token::Cast' )
and q<\\> eq $prior->content()
and return $TRUE;
is_function_call( $usage )
or $prior
and $prior->isa( 'PPI::Token::Word' )
and 'goto' eq $prior->content()
or next;
_compare_token_locations( $usage, $start_token ) < 0
and return $TRUE;
_compare_token_locations( $finish_token, $usage ) < 0
and return $TRUE;
}
}
return;
}
# Expand the given element, losing any brackets along the way. This is
# intended to be used to flatten the argument list of 'use overload'.
sub _expand_element {
my ( $element ) = @_;
$element->isa( 'PPI::Node' )
and return ( map { _expand_element( $_ ) } $_->children() );
$element->significant() and return $element;
return;
}
# Given an include statement, return its arguments. The return is a flattened
# list of lists of tokens, each list of tokens representing an argument.
sub _get_include_arguments {
my ($include) = @_;
# If there are no arguments, just return. We flatten the list because
# someone might use parens to define it.
my @arguments = map { _expand_element( $_ ) } $include->arguments()
or return;
my @elements;
my $inx = 0;
foreach my $element ( @arguments ) {
if ( $element->isa( 'PPI::Token::Operator' ) &&
$IS_COMMA{$element->content()} ) {
$inx++;
} else {
push @{ $elements[$inx] ||= [] }, $element;
}
}
return @elements;
}
1;
__END__
#-----------------------------------------------------------------------------
=pod
=head1 NAME
Perl::Critic::Policy::Subroutines::ProhibitUnusedPrivateSubroutines - Prevent unused private subroutines.
=head1 AFFILIATION
This Policy is part of the core L<Perl::Critic|Perl::Critic>
distribution.
=head1 DESCRIPTION
By convention Perl authors (like authors in many other languages)
indicate private methods and variables by inserting a leading
underscore before the identifier. This policy catches such subroutines
which are not used in the file which declares them.
This module defines a 'use' of a subroutine as a subroutine or method call to
it (other than from inside the subroutine itself), a reference to it (i.e.
C<< my $foo = \&_foo >>), a C<goto> to it outside the subroutine itself (i.e.
C<goto &_foo>), or the use of the subroutine's name as an even-numbered
argument to C<< use overload >>.
=head1 CONFIGURATION
You can define what a private subroutine name looks like by specifying
a regular expression for the C<private_name_regex> option in your
F<.perlcriticrc>:
[Subroutines::ProhibitUnusedPrivateSubroutines]
private_name_regex = _(?!_)\w+
The above example is a way of saying that subroutines that start with
a double underscore are not considered to be private. (Perl::Critic,
in its implementation, uses leading double underscores to indicate a
distribution-private subroutine -- one that is allowed to be invoked by
other Perl::Critic modules, but not by anything outside of
Perl::Critic.)
You can configure additional subroutines to accept by specifying them
in a space-delimited list to the C<allow> option:
[Subroutines::ProhibitUnusedPrivateSubroutines]
allow = _bar _baz
These are added to the default list of exemptions from this policy. So the
above allows C<< sub _bar {} >> and C<< sub _baz {} >>, even if they are not
referred to in the module that defines them.
You can allow a whole class or subroutine names by defining a regular
expression that matches allowed names.
[Subroutines::ProhibitUnusedPrivateSubroutines]
allow_name_regex = _build_\w+
You can configure this policy not to check private subroutines declared in a
file that uses one or more particular named modules. This allows you to, for
example, exclude unused private subroutine checking in classes that are roles.
[Subroutines::ProhibitUnusedPrivateSubroutines]
skip_when_using = Moose::Role Moo::Role Role::Tiny
=head1 HISTORY
This policy is derived from
L<Perl::Critic::Policy::Subroutines::ProtectPrivateSubs|Perl::Critic::Policy::Subroutines::ProtectPrivateSubs>,
which looks at the other side of the problem.
=head1 BUGS
Does not forbid C<< sub Foo::_foo{} >> because it does not know (and can not
assume) what is in the C<Foo> package.
Does not respect the scope caused by multiple packages in the same file. For
example a file:
package Foo;
sub _is_private { print "A private sub!"; }
package Bar;
_is_private();
Will not trigger a violation even though C<Foo::_is_private> is not called.
Similarly, C<skip_when_using> currently works on a I<file> level, not on a
I<package scope> level.
=head1 SEE ALSO
L<Perl::Critic::Policy::Subroutines::ProtectPrivateSubs|Perl::Critic::Policy::Subroutines::ProtectPrivateSubs>.
=head1 AUTHOR
Chris Dolan <cdolan@cpan.org>
=head1 COPYRIGHT
Copyright (c) 2009-2021 Thomas R. Wyant, III.
This program is free software; you can redistribute it and/or modify
it under the same terms as Perl itself. The full text of this license
can be found in the LICENSE file included with this module.
=cut
# Local Variables:
# mode: cperl
# cperl-indent-level: 4
# fill-column: 78
# indent-tabs-mode: nil
# c-indentation-style: bsd
# End:
# ex: set ts=8 sts=4 sw=4 tw=78 ft=perl expandtab shiftround :
|