1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
|
package Perl::Critic::Policy::ValuesAndExpressions::ProhibitEscapedCharacters;
use 5.010001;
use strict;
use warnings;
use Readonly;
use Perl::Critic::Utils qw{ :severities };
use parent 'Perl::Critic::Policy';
our $VERSION = '1.156';
#-----------------------------------------------------------------------------
Readonly::Scalar my $DESC => q{Numeric escapes in interpolated string};
Readonly::Scalar my $EXPL => [ 54..55 ];
#-----------------------------------------------------------------------------
sub supported_parameters { return () }
sub default_severity { return $SEVERITY_LOW }
sub default_themes { return qw(core pbp cosmetic) }
sub applies_to { return qw(PPI::Token::Quote::Double
PPI::Token::Quote::Interpolate) }
#-----------------------------------------------------------------------------
sub violates {
my ( $self, $elem, undef ) = @_;
my $not_escaped = qr/(?<!\\)(?:\\\\)*/xms;
my $hex = qr/\\x[\dA-Fa-f]{2}/xms;
my $widehex = qr/\\x[{][\dA-Fa-f]+[}]/xms;
my $oct = qr/\\[01][0-7]/xms;
if ($elem->content =~ m/$not_escaped (?:$hex|$widehex|$oct)/xmso) {
return $self->violation( $DESC, $EXPL, $elem );
}
return; #ok!
}
1;
__END__
#-----------------------------------------------------------------------------
=pod
=head1 NAME
Perl::Critic::Policy::ValuesAndExpressions::ProhibitEscapedCharacters - Write C<"\N{DELETE}"> instead of C<"\x7F">, etc.
=head1 AFFILIATION
This Policy is part of the core L<Perl::Critic|Perl::Critic>
distribution.
=head1 DESCRIPTION
Escaped numeric values are hard to read and debug. Instead, use named
values. The syntax is less compact, but dramatically more readable.
$str = "\x7F\x06\x22Z"; # not ok
use charnames ':full';
$str = "\N{DELETE}\N{ACKNOWLEDGE}\N{CANCEL}Z"; # ok
=head1 CONFIGURATION
This Policy is not configurable except for the standard options.
=head1 AUTHOR
Chris Dolan <cdolan@cpan.org>
=head1 COPYRIGHT
Copyright (c) 2006-2011 Chris Dolan.
This program is free software; you can redistribute it and/or modify
it under the same terms as Perl itself. The full text of this license
can be found in the LICENSE file included with this module.
=cut
# Local Variables:
# mode: cperl
# cperl-indent-level: 4
# fill-column: 78
# indent-tabs-mode: nil
# c-indentation-style: bsd
# End:
# ex: set ts=8 sts=4 sw=4 tw=78 ft=perl expandtab shiftround :
|
