1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
|
package Perl::Critic::Policy::Variables::ProhibitReusedNames;
use 5.010001;
use strict;
use warnings;
use List::SomeUtils qw(part);
use Readonly;
use Perl::Critic::Utils qw{ :severities :classification :data_conversion };
use parent 'Perl::Critic::Policy';
our $VERSION = '1.156';
#-----------------------------------------------------------------------------
Readonly::Scalar my $DESC => q{Reused variable name in lexical scope: };
Readonly::Scalar my $EXPL => q{Invent unique variable names};
#-----------------------------------------------------------------------------
sub supported_parameters {
return (
{
name => 'allow',
description => 'The variables to not consider as duplicates.',
default_string => '$self $class', ## no critic (RequireInterpolationOfMetachars)
behavior => 'string list',
},
);
}
sub default_severity { return $SEVERITY_MEDIUM }
sub default_themes { return qw( core bugs ) }
sub applies_to { return 'PPI::Statement::Variable' }
#-----------------------------------------------------------------------------
sub violates {
my ( $self, $elem, undef ) = @_;
return if 'local' eq $elem->type;
my $allow = $self->{_allow};
my $names = [ grep { not $allow->{$_} } $elem->variables() ];
# Assert: it is impossible for @$names to be empty in valid Perl syntax
# But if it IS empty, this code should still work but will be inefficient
# Walk up the PDOM looking for declared variables in the same
# scope or outer scopes. Quit when we hit the root or when we find
# violations for all vars (the latter is a shortcut).
my $outer = $elem;
my @violations;
while (1) {
my $up = $outer->sprevious_sibling;
if (not $up) {
$up = $outer->parent;
last if !$up; # top of PDOM, we're done
}
$outer = $up;
if ($outer->isa('PPI::Statement::Variable') && 'local' ne $outer->type) {
my %vars = map {$_ => undef} $outer->variables;
my $hits;
($hits, $names) = part { exists $vars{$_} ? 0 : 1 } @{$names};
if ($hits) {
push @violations, map { $self->violation( $DESC . $_, $EXPL, $elem ) } @{$hits};
last if not $names; # found violations for ALL variables, we're done
}
}
}
return @violations;
}
1;
__END__
#-----------------------------------------------------------------------------
=pod
=head1 NAME
Perl::Critic::Policy::Variables::ProhibitReusedNames - Do not reuse a variable name in a lexical scope
=head1 AFFILIATION
This Policy is part of the core L<Perl::Critic|Perl::Critic>
distribution.
=head1 DESCRIPTION
It's really hard on future maintenance programmers if you reuse a
variable name in a lexical scope. The programmer is at risk of
confusing which variable is which. And, worse, the programmer could
accidentally remove the inner declaration, thus silently changing the
meaning of the inner code to use the outer variable.
my $x = 1;
for my $i (0 .. 10) {
my $x = $i+1; # not OK, "$x" reused
}
With C<use warnings> in effect, Perl will warn you if you reuse a
variable name at the same scope level but not within nested scopes. Like so:
% perl -we 'my $x; my $x'
"my" variable $x masks earlier declaration in same scope at -e line 1.
This policy takes that warning to a stricter level.
=head1 CAVEATS
=head2 Crossing subroutines
This policy looks across subroutine boundaries. So, the following may
be a false positive for you:
sub make_accessor {
my ($self, $fieldname) = @_;
return sub {
my ($self) = @_; # false positive, $self declared as reused
return $self->{$fieldname};
}
}
This is intentional, though, because it catches bugs like this:
my $debug_mode = 0;
sub set_debug {
my $debug_mode = 1; # accidental redeclaration
}
I've done this myself several times -- it's a strong habit to put that
"my" in front of variables at the start of subroutines.
=head2 Performance
The current implementation walks the tree over and over. For a big
file, this can be a huge time sink. I'm considering rewriting to
search the document just once for variable declarations and cache the
tree walking on that single analysis.
=head1 CONFIGURATION
This policy has a single option, C<allow>, which is a list of names to
never count as duplicates. It defaults to containing C<$self> and
C<$class>. You add to this by adding something like this to your
F<.perlcriticrc>:
[Variables::ProhibitReusedNames]
allow = $self $class @blah
=head1 AUTHOR
Chris Dolan <cdolan@cpan.org>
This policy is inspired by
L<http://use.perl.org/~jdavidb/journal/37548>. Java does not allow
you to reuse variable names declared in outer scopes, which I think is
a nice feature.
=head1 COPYRIGHT
Copyright (c) 2008-2021 Chris Dolan
This program is free software; you can redistribute it and/or modify
it under the same terms as Perl itself. The full text of this license
can be found in the LICENSE file included with this module.
=cut
# Local Variables:
# mode: cperl
# cperl-indent-level: 4
# fill-column: 78
# indent-tabs-mode: nil
# c-indentation-style: bsd
# End:
# ex: set ts=8 sts=4 sw=4 tw=78 ft=perl expandtab shiftround :
|
