File: ProhibitBooleanGrep.run

package info (click to toggle)
libperl-critic-perl 1.156-1
  • links: PTS, VCS
  • area: main
  • in suites: forky, sid, trixie
  • size: 3,544 kB
  • sloc: perl: 24,092; lisp: 341; makefile: 7
file content (132 lines) | stat: -rw-r--r-- 2,876 bytes parent folder | download | duplicates (6)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
## name Basic passing
## failures 0
## cut

print grep("$foo", @list);
print ( grep "$foo", @list );
@list = ( grep "$foo", @list );
$aref = [ grep "$foo", @list ];
$href = { grep "$foo", @list };

#-----------------------------------------------------------------------------

## name Counting is allowed
## failures 0
## cut

$count = grep {m/./xms} @list

#-----------------------------------------------------------------------------

## name Non-boolean in conditional
## failures 0
## cut

if (0 == grep {m/./xms} @list) {}

#-----------------------------------------------------------------------------

## name For loop is not conditional
## failures 0
## cut

for( grep { foo($_) } @list ) {}
foreach( grep { foo($_) } @list ) {}

#-----------------------------------------------------------------------------

## name Control structures
## failures 4
## cut

if( grep { foo($_) } @list ) {}
unless( grep { foo($_) } @list ) {}
while( grep { foo($_) } @list ) {}
until( grep { foo($_) } @list ) {}

#-----------------------------------------------------------------------------

## name Postfix control structures
## failures 4
## cut

foo() if grep { bar($_) } @list;
foo() unless grep { bar($_) } @list;
foo() while grep { bar($_) } @list;
foo() until grep { bar($_) } @list;

#-----------------------------------------------------------------------------

## name Complex booleans
## failures 1
## cut

if( 1 && grep { foo($_) } @list ) {}

#-----------------------------------------------------------------------------

## name Complex booleans
## failures 1
## TODO need to detect assignment
## cut

$bar = grep({foo()} @list) && 1;

#-----------------------------------------------------------------------------

## name Complex booleans
## failures 0
## cut

1 && grep({foo()} @list) == 0;

#-----------------------------------------------------------------------------

## name Complex booleans
## failures 1
## cut

1 && grep({foo()} @list) && 0;

#-----------------------------------------------------------------------------

## name Complex booleans
## failures 1
## TODO detect end of statement
## cut

1 && grep({foo()} @list);

#-----------------------------------------------------------------------------

## name Complex booleans
## failures 1
## cut

(1 && grep({foo()} @list))

#-----------------------------------------------------------------------------

## name code coverage...
## failures 1
## cut

(1 && grep);

#-----------------------------------------------------------------------------

## name code coverage...
## failures 0
## cut

$hash->{grep};

#-----------------------------------------------------------------------------
# Local Variables:
#   mode: cperl
#   cperl-indent-level: 4
#   fill-column: 78
#   indent-tabs-mode: nil
#   c-indentation-style: bsd
# End:
# ex: set ts=8 sts=4 sw=4 tw=78 ft=perl expandtab shiftround :