1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
|
## name Topics in a filetest
## failures 2
## cut
my $x = -s $_;
if ( -f $_ ) { foo(); }
#-----------------------------------------------------------------------------
## name Topics in a filetest: -t $_ is not useless because -t defaults to STDIN
## failures 0
## cut
if ( -t $_ ) { foo(); }
#-----------------------------------------------------------------------------
## name Topics in a function call, with parens
## failures 5
## cut
my $x = length($_);
my $y = sin($_);
my $z = defined($_);
my @x = split( /\t/, $_ );
unlink($_);
# Policy cannot handle this yet.
#my $backwards = reverse($_);
#-----------------------------------------------------------------------------
## name Topics in a function call, no parens
## failures 6
## cut
my $x = length $_;
my $y = sin $_;
my $z = defined $_;
my @x = split /\t/, $_;
unlink $_;
my $backwards = reverse $_;
#-----------------------------------------------------------------------------
## name Function calls with $_ but in ways that should not be flagged.
## failures 0
## cut
my @y = split( /\t/, $_, 3 );
my @y = split /\t/, $_, 3;
unlink $_ . '.txt';
my $z = sin( $_ * 4 );
my $a = tan $_ + 5;
#-----------------------------------------------------------------------------
## The following two should NOT be flagged as errors.
## TODO see KNOWN BUGS in the policy documentation
## failures 0
## cut
my @backwards = reverse $_;
my @backwards = reverse($_);
#-----------------------------------------------------------------------------
## name GH #600
## TODO User reported false positives
## failures 0
## cut
$self->zilla->log($_)
foo(lc, $_)
#-----------------------------------------------------------------------------
# Local Variables:
# mode: cperl
# cperl-indent-level: 4
# fill-column: 78
# indent-tabs-mode: nil
# c-indentation-style: bsd
# End:
# ex: set ts=8 sts=4 sw=4 tw=78 ft=perl expandtab shiftround :
|
