1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
|
## name No code
## failures 1
## cut
#Nothing!
#-----------------------------------------------------------------------------
## name basic pass
## failures 0
## cut
our $VERSION = 1.0;
#-----------------------------------------------------------------------------
## name basic pass #2
## failures 0
## cut
our ($VERSION) = 1.0;
#-----------------------------------------------------------------------------
## name basic pass #3
## failures 0
## cut
$Package::VERSION = 1.0;
#-----------------------------------------------------------------------------
## name basic pass #4
## failures 0
## cut
use vars '$VERSION';
#-----------------------------------------------------------------------------
## name basic pass #5
## failures 0
## cut
use vars qw($VERSION);
#-----------------------------------------------------------------------------
## name fail with lexical
## failures 1
## cut
my $VERSION;
#-----------------------------------------------------------------------------
## name fail with wrong variable
## failures 1
## cut
our $Version;
#-----------------------------------------------------------------------------
## name pass with "no critic" on
## failures 0
## cut
#!anything ## no critic (RequireVersionVar)
#-----------------------------------------------------------------------------
## name Readonly VERSION
## failures 0
## cut
Readonly our $VERSION = 1.0;
#-----------------------------------------------------------------------------
## name Readonly::Scalar VERSION
## failures 0
## cut
Readonly::Scalar our $VERSION = 1.0;
#-----------------------------------------------------------------------------
## name Readonly::Scalar VERSION
## failures 1
## cut
Readonly::Scalar my $VERSION = 1.0; #Note this is lexical
#-----------------------------------------------------------------------------
## name Version as argument to package. RT #67159
## failures 0
## cut
package Foo 0.001;
#-----------------------------------------------------------------------------
## name Package without version should still be violation. RT #67159
## failures 1
## cut
package Foo;
##############################################################################
# Local Variables:
# mode: cperl
# cperl-indent-level: 4
# fill-column: 78
# indent-tabs-mode: nil
# c-indentation-style: bsd
# End:
# ex: set ts=8 sts=4 sw=4 tw=78 ft=perl expandtab shiftround :
|
