File: ProhibitCaptureWithoutTest.run

package info (click to toggle)
libperl-critic-perl 1.156-1
  • links: PTS, VCS
  • area: main
  • in suites: forky, sid, trixie
  • size: 3,544 kB
  • sloc: perl: 24,092; lisp: 341; makefile: 7
file content (333 lines) | stat: -rw-r--r-- 6,623 bytes parent folder | download | duplicates (6)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
## name use without regex
## failures 3
## cut
my $foo = $1;
my @matches = ($1, $2);

#-----------------------------------------------------------------------------

## name void use without regex
## failures 1
## cut
$1

#-----------------------------------------------------------------------------

## name regex but no check on success
## failures 1
## cut
'some string' =~ m/(s)/;
my $s = $1;

#-----------------------------------------------------------------------------

## name inside a checkblock, but another regex overrides
## failures 1
## cut
if (m/(.)/) {
   'some string' =~ m/(s)/;
   my $s = $1;
}

#-----------------------------------------------------------------------------

## name good passes
## failures 0
## cut
if ($str =~ m/(.)/) {
   return $1;
}
elsif ($foo =~ s/(b)//) {
   $bar = $1;
}

if ($str =~ m/(.)/) {
   while (1) {
      return $1;
   }
}

while ($str =~ m/\G(.)/cg) {
   print $1;
}

print $0; # not affected by policy
print $_; # not affected by policy
print $f1; # not affected by policy

my $result = $str =~ m/(.)/;
if ($result) {
   return $1;
}

#-----------------------------------------------------------------------------

## name ternary passes
## failures 0
## cut
print m/(.)/ ? $1 : 'undef';
print !m/(.)/ ? 'undef' : $1;
print s/(.)// ? $1 : 'undef';
print !s/(.)// ? 'undef' : $1;
$foo = m/(.)/ && $1;
$foo = !m/(.)/ || $1;
$foo = s/(.)// && $1;
$foo = !s/(.)// || $1;

#-----------------------------------------------------------------------------

## name Regression for PPI::Statement::Expressions
## failures 0
## cut

if (m/(\d+)/xms) {
   $foo = ($1);
}

#-----------------------------------------------------------------------------

## name Regression for ternaries with structures
## failures 0
## cut

$str =~ m/(.)/xms ? foo($1) : die;
$str =~ m/(.)/xms ? [$1] : die;
$str =~ m/(.)/xms ? { match => $1 } : die;

#-----------------------------------------------------------------------------

## name Failure to match throws exception - RT 36081.
## failures 0
## cut

m/(foo)/ or die;
print $1, "\n";
m/(foo)/ or croak;
print $1, "\n";
m/(foo)/ or confess;
print $1, "\n";
m/(foo)/ || die;
print $1, "\n";
m/(foo)/ || croak;
print $1, "\n";
m/(foo)/ || confess;
print $1, "\n";

#-----------------------------------------------------------------------------

## name Failure to match throws exception (regex in outer block) - RT 36081.
## failures 0
## cut

m/(foo)/ or die;
{
    print $1, "\n";
}

#-----------------------------------------------------------------------------

## name Failure to match throws exception (regex in inner block) - RT 36081.
## failures 1
## cut

{
    m/(foo)/ or die;
}
print $1, "\n";

#-----------------------------------------------------------------------------

## name Boolean 'or' without known exception source is an error - RT 36081
## failures 1
## cut

m/(foo)/ or my_exception_source( 'bar' );
print $1, "\n";

#-----------------------------------------------------------------------------

## name Recognize alternate exception sources if told about them - RT 36081
## parms { exception_source => 'my_exception_source' }
## failures 0
## cut

m/(foo)/ or my_exception_source( 'bar' );
print $1, "\n";
m/(foo)/ or $self->my_exception_source( 'bar' );
print $1, "\n";

#-----------------------------------------------------------------------------

## name Failure to match causes transfer of control - RT 36081.
## failures 0
## cut

m/(foo)/ or next;
print $1, "\n";
m/(foo)/ or last;
print $1, "\n";
m/(foo)/ or redo;
print $1, "\n";
m/(foo)/ or goto FOO;
print $1, "\n";
m/(foo)/ or return;
print $1, "\n";
m/(foo)/ || next;
print $1, "\n";
m/(foo)/ || last;
print $1, "\n";
m/(foo)/ || redo;
print $1, "\n";
m/(foo)/ || goto FOO;
print $1, "\n";
m/(foo)/ || return;
print $1, "\n";

#-----------------------------------------------------------------------------

## name Failure to match causes transfer of control (regex in outer block) - RT 36081.
## failures 0
## cut

m/(foo)/ or return;
{
    print $1, "\n";
}

#-----------------------------------------------------------------------------

## name Failure to match causes transfer of control (regex in inner block) - RT 36081.
## failures 1
## cut

{
    m/(foo)/ or return;
}
print $1, "\n";

#-----------------------------------------------------------------------------

## name Failure to match does not cause transfer of control (regex in inner block) - RT 36081.
## failures 1
## cut

{
    m/(foo)/;
}
print $1, "\n";

#-----------------------------------------------------------------------------

## name goto that transfers around capture - RT 36081.
## failures 0
## cut

{
    m/(foo)/ or goto BAR;
    print $1, "\n";
    BAR:
    print "Baz\n";
}

{
BAR: m/(foo)/ or goto BAR;
    print $1, "\n";
}

{
    m/(foo)/ or goto &bar;
    print $1, "\n";
}

#-----------------------------------------------------------------------------

## name goto that does not transfer around capture - RT 36081.
## failures 1
## cut

{
    m/(foo)/ or goto BAR;
BAR : print $1, "\n";
}

#-----------------------------------------------------------------------------

## name goto that can not be disambiguated - RT 36081.
## failures 1
## cut

{
FOO: m/(foo)/ or goto (qw{FOO BAR BAZ})[$i];
BAR: print $1, "\n";
BAZ:
}

#-----------------------------------------------------------------------------

## name regex in suffix control
## failures 0
## cut

die unless m/(foo)/;
print $1, "\n";
last unless m/(foo)/;
print $1, "\n";
die "Arrrgh" unless m/(foo)/;
print $1, "\n";

#-----------------------------------------------------------------------------

## name regex in loop with capture in nested if
## failures 0
## cut

foreach (qw{foo bar baz}) {
    next unless m/(foo)/;
    if ($1) {
        print "Foo!\n";
    }
}

#-----------------------------------------------------------------------------

## name regex in while, capture in loop
## failures 0
## cut

while (m/(foo)/) {
    print $1, "\n";
}

#-----------------------------------------------------------------------------

## name Regex followed by "and do {...}" RT #50910
## failures 0
## cut

m/^commit (.*)/xsm and do {
     $commit = $1;
     next;
};

#-----------------------------------------------------------------------------

## name regex inside when(){} RT #36081
## failures 0
## cut

use 5.010;

given ( 'abc' ) {
    when ( m/(a)/ ) {
        say $1;
    }
}

# Local Variables:
#   mode: cperl
#   cperl-indent-level: 4
#   fill-column: 78
#   indent-tabs-mode: nil
#   c-indentation-style: bsd
# End:
# ex: set ts=8 sts=4 sw=4 tw=78 ft=perl expandtab shiftround :