1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
|
## name basic passes
## failures 0
## cut
sub foo { }
sub bar;
sub baz { return; }
sub quux { return {some => [qw(complicated data)], q{ } => /structure/}; }
#-----------------------------------------------------------------------------
## name complex passes
## failures 0
## cut
sub foo { if ($bool) { return; } else { return; } }
sub bar { unless ($bool) { return; } else { return; } }
sub baz { if ($bool) { return; } elsif ($bool2) { return; } else { return; } }
sub quuz { unless ($bool) { return; } elsif ($bool2) { return; } else { return; } }
#-----------------------------------------------------------------------------
## name ternary returns
## failures 0
## TODO We are not yet detecting ternaries
## cut
sub foo { 1 ? return : 2 ? return : return; }
#-----------------------------------------------------------------------------
## name returning ternaries
## failures 0
## cut
sub foo { return 1 ? 1 : 2 ? 2 : 3; }
#-----------------------------------------------------------------------------
## name implicit returns fail
## failures 2
## cut
sub foo { 1 }
sub foo { 'Club sandwich'; }
#-----------------------------------------------------------------------------
## name return in a constant loop
## failures 1
## cut
sub foo { while (1==1) { return; } }
#-----------------------------------------------------------------------------
## name not all code paths returns
## failures 3
## cut
sub foo { if ($bool) { } else { } }
sub foo { if ($bool) { $foo = 'bar'; } else { return; } }
sub foo { unless ($bool) { $foo = 'bar'; } else { return; } }
#-----------------------------------------------------------------------------
## name special blocks exemption
## failures 0
## cut
BEGIN {
print 'this should not need a return';
}
INIT {
print 'nor this';
}
CHECK {
print 'nor this';
}
END {
print 'nor this';
}
#-----------------------------------------------------------------------------
## name goto is equivalent to return
## failures 0
## cut
sub foo { goto &bar; }
END_PERL
#-----------------------------------------------------------------------------
## name next and last are not equivalent to return (and are invalid Perl)
## failures 2
## cut
sub foo { next; }
sub bar { last; }
#-----------------------------------------------------------------------------
## name abnormal termination is allowed
## failures 0
## cut
sub foo { die; }
sub bar { croak; }
sub baz { confess; }
sub bar_C { Carp::croak; }
sub baz_C { Carp::confess; }
sub quux { exec; }
sub quux2 { exit; }
sub quux3 { throw 'nuts'; }
#-----------------------------------------------------------------------------
## name Final return is present, but conditional
## failures 5
## cut
sub foo { die if $condition }
sub bar { croak unless $condition }
sub baz { exec for @condition }
sub baz { exit for @condition }
sub quux { throw 'nuts'if not $condition }
#-----------------------------------------------------------------------------
## name Compound final return is present, but conditional
## failures 1
## cut
sub foo {
if( $condition ) {
return if $today_is_tuesday;
}
else {
exit unless $today_is_wednesday;
}
}
#-----------------------------------------------------------------------------
## name Custom terminal functions
## parms { terminal_funcs => 'bailout abort quit' };
## failures 0
## cut
sub foo { if ($condition) { return 1; }else{ abort } }
sub bar { if ($condition) { bailout }else{ return 1 } }
sub baz { quit }
#-----------------------------------------------------------------------------
## name Custom terminal methods
## parms { terminal_methods => 'bailoutmeth abortmeth quitmeth' };
## failures 0
## cut
sub foo { if ($condition) { return 1; }else{ ONE->bailoutmeth } }
sub bar { if ($condition) { $two->abortmeth }else{ return 1 } }
sub baz { $three->quitmeth }
#-----------------------------------------------------------------------------
## name Custom terminal methods failing
## parms { };
## failures 3
## cut
sub foo { if ($condition) { return 1; }else{ ONE->bailoutmeth } }
sub bar { if ($condition) { $two->abortmeth }else{ return 1 } }
sub baz { $three->quitmeth }
#-----------------------------------------------------------------------------
## name ForLoop is a QuoteLike::Words
## failures 0
## cut
sub foo {
for my $thingy qw<blah> {}
return;
}
#-----------------------------------------------------------------------------
## name RT 43309 - given/when followed by return
## failures 0
## cut
sub foo {
given ($bar) {}
return;
}
#-----------------------------------------------------------------------------
## name given/when with return on all branches
## failures 0
## cut
sub foo {
my ( $val ) = @_;
given ( $val ) {
when ( 'end' ) {
return 'End.';
}
default {
return 'Not end.';
}
}
}
#-----------------------------------------------------------------------------
## name given/suffix when with return on all branches
## failures 0
## cut
sub foo {
my ( $val ) = @_;
given ( $val ) {
return 'End.' when 'end';
default {
return 'Not end.';
}
}
}
#-----------------------------------------------------------------------------
## name given/when without return on all branches fails
## failures 1
## cut
sub foo {
my ( $val ) = @_;
given ( $val ) {
when ( 'end' ) {
return 'End.';
}
default {
print "Not end.\n";
}
}
}
#-----------------------------------------------------------------------------
## name given/when with return on all branches but without default fails
## failures 1
## cut
sub foo {
my ( $val ) = @_;
given ( $val ) {
when ( 'end' ) {
return 'End.';
}
}
}
#-----------------------------------------------------------------------------
## name return without trailing whitespace (GH #451)
## failures 0
## cut
sub f {
return'ProposedOverdue.png';
}
#-----------------------------------------------------------------------------
## name yada-yada operator is essentially terminal (GH #574)
## failures 0
## cut
sub f {
some_code();
...
}
##############################################################################
# Local Variables:
# mode: cperl
# cperl-indent-level: 4
# fill-column: 78
# indent-tabs-mode: nil
# c-indentation-style: bsd
# End:
# ex: set ts=8 sts=4 sw=4 tw=78 ft=perl expandtab shiftround :
|
