File: ProhibitCommaSeparatedStatements.run

package info (click to toggle)
libperl-critic-perl 1.156-1
  • links: PTS, VCS
  • area: main
  • in suites: forky, sid, trixie
  • size: 3,544 kB
  • sloc: perl: 24,092; lisp: 341; makefile: 7
file content (309 lines) | stat: -rw-r--r-- 6,801 bytes parent folder | download | duplicates (3)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
## name Basic passing
## failures 0
## cut

@x = (@y, @z);
my $expl = [133, 138];
$lookup = { a => 1, b => 2 };

#-----------------------------------------------------------------------------

## name Basic failure
## failures 1
## cut

@x = @y, @z;

#-----------------------------------------------------------------------------

## name List including assignments
## failures 0
## cut

@w = ($x = 1, $y = 2, $z = 3);

#-----------------------------------------------------------------------------

## name List containing statement
## failures 0
## cut

@w = ( {}, [] );

#-----------------------------------------------------------------------------

## name List containing statement in a constructor that is reported as a block
## failures 0
## cut

my %foo = (
    blah => {
        blah => 'blah',
    },
);

#-----------------------------------------------------------------------------

## name Regular statement inside a block.
## failures 0
## cut

foreach my $path ( @ARGV ) {
    utter 'Looking at ', $path, '.';
}

#-----------------------------------------------------------------------------

## name Sub call after comma
## failures 1
## cut

@x = @y, foo @z;

#-----------------------------------------------------------------------------

## name Regular sub call before comma
## failures 1
## cut

# The space between the sub name and the left parenthesis is significant
# in that part of Conway's point is that things that look like lists may
# not be.

@x = foo (@y), @z;

#-----------------------------------------------------------------------------

## name No-argument sub call via use of sigil
## failures 1
## cut

@x = &foo, @y, bar @z;

#-----------------------------------------------------------------------------

## name Two sub calls
## failures 0
## cut

@x = foo @y, bar @z;

#-----------------------------------------------------------------------------

## name Built-in call that provides a list context without parentheses
## failures 0
## cut

@x = push @y, @z;

#-----------------------------------------------------------------------------

## name Built-in call that provides a list context, called like a function
## failures 1
## cut

@x = push (@y), @z;

#-----------------------------------------------------------------------------

## name Built-in call that takes multiple arguments without parentheses
## failures 0
## cut

@x = substr $y, 1, 2;

#-----------------------------------------------------------------------------

## name Built-in call that takes multiple arguments, called like a function
## failures 1
## cut

@x = substr ($y, 1), 2;

#-----------------------------------------------------------------------------

## name Call to unary built-in without parentheses
## failures 1
## cut

@x = tied @y, @z;

#-----------------------------------------------------------------------------

## name Unary built-in, called like a function
## failures 1
## cut

@x = tied (@y), @z;

#-----------------------------------------------------------------------------

## name Call to no-argument built-in without parentheses
## failures 1
## cut

@x = time, @z;

#-----------------------------------------------------------------------------

## name No-argument built-in, called like a function
## failures 1
## cut

@x = time (), @z;

#-----------------------------------------------------------------------------

## name Call to optional argument built-in without an argument without parentheses
## failures 1
## cut

@x = sin, @z;

#-----------------------------------------------------------------------------

## name Optional argument built-in, called like a function without an argument
## failures 1
## cut

@x = sin (), @z;

#-----------------------------------------------------------------------------

## name Call to optional argument built-in with an argument without parentheses
## failures 1
## cut

@x = sin @y, @z;

#-----------------------------------------------------------------------------

## name Optional argument built-in, called like a function with an argument
## failures 1
## cut

@x = sin (@y), @z;

#-----------------------------------------------------------------------------

## name For loop
## failures 2
## cut

for ($x = 0, $y = 0; $x < 10; $x++, $y += 2) {
    foo($x, $y);
}

#-----------------------------------------------------------------------------

## name For loop
## failures 0
## cut

for ($x, 'x', @y, 1, ) {
    print;
}

#-----------------------------------------------------------------------------

## name qw<>
## failures 0
## cut

@list = qw<1, 2, 3>; # this really means @list = ('1,', '2,', '3');

#-----------------------------------------------------------------------------

## name original RT #27654
## failures 0
## cut

my @arr1;
@arr1 = split /b/, 'abc';

#-----------------------------------------------------------------------------

## name RT #27654 - NKH example 1
## failures 0
## cut

return
  {
  "string" => $aliased_history,
  TIME => $self->{something},
  } ;

#-----------------------------------------------------------------------------

## name RT #27654 - NKH example 2 - without allow_last_statement_to_be_comma_separated_in_map_and_grep
## failures 1
## cut

%hash = map {$_, 1} @list ;

#-----------------------------------------------------------------------------

## name RT #27654 - NKH example 2 - with allow_last_statement_to_be_comma_separated_in_map_and_grep
## failures 0
## parms { allow_last_statement_to_be_comma_separated_in_map_and_grep => 1 }
## cut

%hash = map {$_, 1} @list ;

#-----------------------------------------------------------------------------

## name RT #27654 - NKH example 3
## failures 0
## cut

$self->DoSomething
  (
  { %{$a_hash_ref}, %{$another_hash_ref}},
  @more_data,
  ) ;

#-----------------------------------------------------------------------------

## name RT #33935 and 49679
## failures 0
## cut

func( @{ $href }{'1', '2'} );

#-----------------------------------------------------------------------------

## name RT #61301 (requires PPI 1.215)
## failures 0
## cut

sub foo {
    return { bar => 1, answer => 42 };
}

#-----------------------------------------------------------------------------

## name RT #64132 (requires PPI 1.215)
## failures 0
## cut

sub new {
    return bless { foo => 1, bar => 2 }, __PACKAGE__;
}

#-----------------------------------------------------------------------------

## name Hashref seen as block (GH #192)
## failures 0
## cut

my $o = shift || {'file' => 1, 'exec' => 1};

#-----------------------------------------------------------------------------
# Local Variables:
#   mode: cperl
#   cperl-indent-level: 4
#   fill-column: 78
#   indent-tabs-mode: nil
#   c-indentation-style: bsd
# End:
# ex: set ts=8 sts=4 sw=4 tw=78 ft=perl expandtab shiftround :