1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55
|
#!/usr/bin/perl -w
# Copyright 2015 Kevin Ryde
# This file is part of Perl-Critic-Pulp.
#
# Perl-Critic-Pulp is free software; you can redistribute it and/or
# modify it under the terms of the GNU General Public License as published
# by the Free Software Foundation; either version 3, or (at your option) any
# later version.
#
# Perl-Critic-Pulp is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General
# Public License for more details.
#
# You should have received a copy of the GNU General Public License along
# with Perl-Critic-Pulp. If not, see <http://www.gnu.org/licenses/>.
# Look for modules with @EXPORT etc but no "use Exporter".
#
use 5.008;
use strict;
use lib::abs '.';
use MyLocatePerl;
use MyStuff;
# uncomment this to run the ### lines
use Smart::Comments;
use base 'Exporter';
our @EXPORT = ('foo');
my $verbose = 0;
my $l = MyLocatePerl->new;
while (my ($filename, $str) = $l->next) {
if ($verbose) { print "look at $filename\n"; }
# strip comments
$str =~ s/#.*//mg;
$str =~ /[^'"\\]\@EXPORT/ || next;
my $pos = $+[0];
next if $str =~ /require Exporter\s*;/;
next if $str =~ /use\s+(Exporter|base\s+('|qw\s*\()Exporter)\b/s;
my ($line, $col) = MyStuff::pos_to_line_and_column ($str, $pos);
print "$filename:$line:$col: \@EXPORT without \"use Exporter\"\n",
MyStuff::line_at_pos($str, $pos);
}
exit 0;
|