1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
|
# Copyright 2008, 2009, 2010, 2011, 2012, 2013, 2014, 2015, 2016, 2017 Kevin Ryde
# This file is part of Perl-Critic-Pulp.
# Perl-Critic-Pulp is free software; you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by the
# Free Software Foundation; either version 3, or (at your option) any later
# version.
#
# Perl-Critic-Pulp is distributed in the hope that it will be useful, but
# WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY
# or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
# for more details.
#
# You should have received a copy of the GNU General Public License along
# with Perl-Critic-Pulp. If not, see <http://www.gnu.org/licenses/>.
package Perl::Critic::Pulp;
use 5.006;
use strict;
use warnings;
our $VERSION = 96;
1;
__END__
=for stopwords perlcritic builtin multi-constants Gtk2 Gtk2Constants perlcritic's Ryde barewords un-typical parens de gustibus disputandum backslashing initializers globals add-ons
=head1 NAME
Perl::Critic::Pulp - some add-on perlcritic policies
=head1 DESCRIPTION
This is a collection of add-on policies for C<Perl::Critic>. They're under
a "pulp" theme plus other themes according to their purpose (see
L<Perl::Critic/POLICY THEMES>).
=for my_pod policy_list begin
=head2 Bugs
=over
=item L<CodeLayout::ProhibitFatCommaNewline|Perl::Critic::Policy::CodeLayout::ProhibitFatCommaNewline>
Avoid newline before C<=E<gt>> not quoting.
=item L<CodeLayout::ProhibitIfIfSameLine|Perl::Critic::Policy::CodeLayout::ProhibitIfIfSameLine>
Avoid C<} if () {> perhaps meant to be C<elsif>.
=item L<Miscellanea::TextDomainPlaceholders|Perl::Critic::Policy::Miscellanea::TextDomainPlaceholders>
Check keyword arguments to C<__x()>, C<__nx()>, etc.
=item L<Modules::ProhibitUseQuotedVersion|Perl::Critic::Policy::Modules::ProhibitUseQuotedVersion>
Don't quote a version requirement like C<use Foo '1.5'>
=item L<ValuesAndExpressions::RequireNumericVersion|Perl::Critic::Policy::ValuesAndExpressions::RequireNumericVersion>
C<$VERSION> plain number for comparisons and checking.
=item L<ValuesAndExpressions::ConstantBeforeLt|Perl::Critic::Policy::ValuesAndExpressions::ConstantBeforeLt>
Avoid problems with C<< FOO < 123 >>
=item L<ValuesAndExpressions::NotWithCompare|Perl::Critic::Policy::ValuesAndExpressions::NotWithCompare>
Avoid problems with C<! $x == $y>
=item L<ValuesAndExpressions::ProhibitArrayAssignAref|Perl::Critic::Policy::ValuesAndExpressions::ProhibitArrayAssignAref>
Dubious C<@array=[1,2,3]> array/arrayref assignments.
=item L<ValuesAndExpressions::ProhibitDuplicateHashKeys|Perl::Critic::Policy::ValuesAndExpressions::ProhibitDuplicateHashKeys>
Duplicate literal keys C<%h = (xyz=E<gt>123, xyz=E<gt>456)>.
=item L<ValuesAndExpressions::ProhibitFiletest_f|Perl::Critic::Policy::ValuesAndExpressions::ProhibitFiletest_f>
Don't use C<-f>.
=item L<ValuesAndExpressions::UnexpandedSpecialLiteral|Perl::Critic::Policy::ValuesAndExpressions::UnexpandedSpecialLiteral>
C<__PACKAGE__> etc special words not expanding.
=back
=head2 Compatibility
=over
=item L<Compatibility::ConstantPragmaHash|Perl::Critic::Policy::Compatibility::ConstantPragmaHash>
Version requirement for hash style multi-constants.
=item L<Compatibility::ConstantLeadingUnderscore|Perl::Critic::Policy::Compatibility::ConstantLeadingUnderscore>
Version requirement for constants with leading underscore.
=item L<Compatibility::Gtk2Constants|Perl::Critic::Policy::Compatibility::Gtk2Constants>
Gtk2 module version requirement for some constants.
=item L<Compatibility::PerlMinimumVersionAndWhy|Perl::Critic::Policy::Compatibility::PerlMinimumVersionAndWhy>
Perl version declared against features used.
=item L<Compatibility::PodMinimumVersion|Perl::Critic::Policy::Compatibility::PodMinimumVersion>
Perl version declared against POD features used.
=item L<Compatibility::ProhibitUnixDevNull|Perl::Critic::Policy::Compatibility::ProhibitUnixDevNull>
Prefer C<< File::Spec->devnull >> over F</dev/null>.
=back
=head2 Efficiency
=over
=item L<Documentation::RequireEndBeforeLastPod|Perl::Critic::Policy::Documentation::RequireEndBeforeLastPod>
Put C<__END__> before POD at end of file.
=item L<Miscellanea::TextDomainUnused|Perl::Critic::Policy::Miscellanea::TextDomainUnused>
C<Locale::TextDomain> imported but not used.
=item L<Modules::ProhibitPOSIXimport|Perl::Critic::Policy::Modules::ProhibitPOSIXimport>
Don't import the whole of C<POSIX>.
=back
=head2 Cosmetic
=over
=item L<CodeLayout::RequireTrailingCommaAtNewline|Perl::Critic::Policy::CodeLayout::RequireTrailingCommaAtNewline>
Comma "," at the end of list, if at a newline.
=item L<CodeLayout::RequireFinalSemicolon|Perl::Critic::Policy::CodeLayout::RequireFinalSemicolon>
Semicolon C<;> on the last statement of a subroutine or block.
=item L<ValuesAndExpressions::ProhibitEmptyCommas|Perl::Critic::Policy::ValuesAndExpressions::ProhibitEmptyCommas>
Stray consecutive commas C<,,>
=item L<ValuesAndExpressions::ProhibitNullStatements|Perl::Critic::Policy::ValuesAndExpressions::ProhibitNullStatements>
Stray semicolons C<;>
=item L<ValuesAndExpressions::ProhibitUnknownBackslash|Perl::Critic::Policy::ValuesAndExpressions::ProhibitUnknownBackslash>
Unknown C<\z> etc escapes in strings.
=item L<ValuesAndExpressions::ProhibitBarewordDoubleColon|Perl::Critic::Policy::ValuesAndExpressions::ProhibitBarewordDoubleColon>
Double-colon barewords C<Foo::Bar::>
=item L<Modules::ProhibitModuleShebang|Perl::Critic::Policy::Modules::ProhibitModuleShebang>
No C<#!> interpreter line in F<.pm> files.
=back
=head2 Documentation
=over
=item L<Documentation::ProhibitUnbalancedParens|Perl::Critic::Policy::Documentation::ProhibitUnbalancedParens>
Unbalanced or mismatched ( ) parens, brackets and braces.
=item L<Documentation::ProhibitAdjacentLinks|Perl::Critic::Policy::Documentation::ProhibitAdjacentLinks>
Put commas or some text between adjacent C<< LE<lt>E<gt> >> links.
=item L<Documentation::ProhibitDuplicateHeadings|Perl::Critic::Policy::Documentation::ProhibitDuplicateHeadings>
Don't duplicate C<=head> headings.
=item L<Documentation::ProhibitDuplicateSeeAlso|Perl::Critic::Policy::Documentation::ProhibitDuplicateSeeAlso>
Don't duplicate C<< LE<lt>E<gt> >> links in SEE ALSO sections.
=item L<Documentation::ProhibitBadAproposMarkup|Perl::Critic::Policy::Documentation::ProhibitBadAproposMarkup>
Avoid C<< CE<lt>E<gt> >> in NAME section, bad for man's "apropos" output.
=item L<Documentation::RequireFilenameMarkup|Perl::Critic::Policy::Documentation::RequireFilenameMarkup>
Markup /foo filenames.
=item L<Documentation::ProhibitLinkToSelf|Perl::Critic::Policy::Documentation::ProhibitLinkToSelf>
Don't C<< LE<lt>E<gt> >> link to the document itself.
=item L<Documentation::ProhibitParagraphEndComma|Perl::Critic::Policy::Documentation::ProhibitParagraphEndComma>
Don't end paragraph with "," comma.
=item L<Documentation::ProhibitParagraphTwoDots|Perl::Critic::Policy::Documentation::ProhibitParagraphTwoDots>
Don't end paragraph with ".." (stray extra dot).
=item L<Documentation::ProhibitVerbatimMarkup|Perl::Critic::Policy::Documentation::ProhibitVerbatimMarkup>
Verbatim paragraphs not expanding C<< CE<lt>E<gt> >> etc markup.
=item L<Documentation::RequireFinalCut|Perl::Critic::Policy::Documentation::RequireFinalCut>
Have a C<=cut> at end of file.
=item L<Documentation::RequireLinkedURLs|Perl::Critic::Policy::Documentation::RequireLinkedURLs>
Use C<< LE<lt>E<gt> >> markup on URLs.
=back
=for my_pod policy_list end
=head2 Selecting
You can always enable or disable the policies you do or don't want (see
L<Perl::Critic/CONFIGURATION>). You may have already realized that there's
a wide range of builtin and add-on perlcritic policies ranging from buggy
practice to deliberately restrictive or even quite bizarre. You're not
meant to pass everything. Some policies may even be mutually contradictory.
The restrictive policies are meant as building blocks for a limited house
style. For example C<ProhibitBarewordDoubleColon> here, or something like
C<ProhibitUnlessBlocks>. They're usually a matter of personal preference,
and "non de gustibus disputandum" as they say in the classics. Trying to
follow all of them would give away big parts of the language and quite
likely result in very un-typical code.
Some of the restrictive policies are geared towards beginners.
C<ProhibitUnknownBackslash> here or C<RequireInitializationForLocalVars> are
along those lines. There might for instance be good backslashing which the
prohibition doesn't recognise, or local variable initializers make no sense
for output variables like C<$!>, once you get to the level of knowing to use
C<local> to preserve such globals.
In general the POD of each policy is supposed to explain the motivation so
you can see whether you want it or not. If you're not turning off or
drastically customizing at least half of all policies then you're either not
trying or you're much too easily lead!
=head1 OTHER NOTES
In most of the perlcritic documentation, including the Pulp add-ons here,
policy names appear without the full C<Perl::Critic::Policy::...> class
part. In Emacs try C<man-completion.el> to make C<M-x man> automatically
expand a suffix part at point, or C<ffap-perl-module.el> for the same to go
to the source.
=over
=item
L<http://user42.tuxfamily.org/man-completion/index.html>
=item
L<http://user42.tuxfamily.org/ffap-perl-module/index.html>
=back
In perlcritic's output you can ask for C<%P> to see the full policy package
name to run C<perldoc> or copy or follow etc. Here's a good output format
you can put in your F<.perlcriticrc>. The file:line:column: part is a style
Emacs will recognise.
verbose=%f:%l:%c:\n %P\n %m\n
See L<Perl::Critic::Violation> for all available C<%> escapes.
F<perlcritic.el> which comes with perlcritic has regexp patterns for Emacs
to recognise the builtin perlcritic formats, but it's easier to output
"file:line:column:" in the first place.
=head1 SEE ALSO
L<Perl::Critic>
=head1 HOME PAGE
L<http://user42.tuxfamily.org/perl-critic-pulp/index.html>
=head1 COPYRIGHT
Copyright 2008, 2009, 2010, 2011, 2012, 2013, 2014, 2015, 2016, 2017 Kevin Ryde
Perl-Critic-Pulp is free software; you can redistribute it and/or modify it
under the terms of the GNU General Public License as published by the Free
Software Foundation; either version 3, or (at your option) any later
version.
Perl-Critic-Pulp is distributed in the hope that it will be useful, but
WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY
or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for
more details.
You should have received a copy of the GNU General Public License along with
Perl-Critic-Pulp. If not, see <http://www.gnu.org/licenses/>.
=cut
|
