1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
|
#!/usr/bin/perl -w
# Copyright 2008, 2009, 2010, 2011, 2012, 2013, 2014, 2015, 2016, 2017, 2019, 2021 Kevin Ryde
# This file is part of Perl-Critic-Pulp.
#
# Perl-Critic-Pulp is free software; you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by the
# Free Software Foundation; either version 3, or (at your option) any later
# version.
#
# Perl-Critic-Pulp is distributed in the hope that it will be useful, but
# WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY
# or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
# for more details.
#
# You should have received a copy of the GNU General Public License along
# with Perl-Critic-Pulp. If not, see <http://www.gnu.org/licenses/>.
use 5.006;
use strict;
use warnings;
use Test::More tests => 38;
use lib 't';
use MyTestHelpers;
BEGIN { MyTestHelpers::nowarnings() }
require Perl::Critic::Policy::ValuesAndExpressions::UnexpandedSpecialLiteral;
#-----------------------------------------------------------------------------
my $want_version = 99;
is ($Perl::Critic::Policy::ValuesAndExpressions::UnexpandedSpecialLiteral::VERSION, $want_version, 'VERSION variable');
is (Perl::Critic::Policy::ValuesAndExpressions::UnexpandedSpecialLiteral->VERSION, $want_version, 'VERSION class method');
{
ok (eval { Perl::Critic::Policy::ValuesAndExpressions::UnexpandedSpecialLiteral->VERSION($want_version); 1 }, "VERSION class check $want_version");
my $check_version = $want_version + 1000;
ok (! eval { Perl::Critic::Policy::ValuesAndExpressions::UnexpandedSpecialLiteral->VERSION($check_version); 1 }, "VERSION class check $check_version");
}
#------------------------------------------------------------------------------
# confirming what's claimed in the POD and subject to critiquing ...
#
{ my @x = ('MyExtra::'.__PACKAGE__ => 123);
is_deeply (\@x, [ 'MyExtra::__PACKAGE__', 123 ],
'list constructor literal on right of a . expression');
}
{ my $hash = { 'Foo'.__FILE__ => 123 };
my @h = (%$hash);
is_deeply (\@h, [ 'Foo__FILE__', 123 ],
'hash constructor literal on right of a . expression');
}
# Perl 5.20 is probably going to quote all builtins across newline, except
# for __DATA__ and __END__. That would mean __PACKAGE__ doesn't expand, and
# ought to be reported as a violation.
#
# { my @array = (__PACKAGE__
# => 123);
# is_deeply (\@array, [ 'main', 123 ],
# "fat comma doesn't quote across newline");
# }
# { my @array = (__PACKAGE__ # and with a comment
# => 123);
# is_deeply (\@array, [ 'main', 123 ],
# "fat comma doesn't quote across comment and newline");
# }
#------------------------------------------------------------------------------
require Perl::Critic;
my $critic = Perl::Critic->new
('-profile' => '',
'-single-policy' => '^Perl::Critic::Policy::ValuesAndExpressions::UnexpandedSpecialLiteral$');
{ my @p = $critic->policies;
is (scalar @p, 1,
'single policy UnexpandedSpecialLiteral');
my $policy = $p[0];
ok (eval { $policy->VERSION($want_version); 1 },
"VERSION object check $want_version");
my $check_version = $want_version + 1000;
ok (! eval { $policy->VERSION($check_version); 1 },
"VERSION object check $check_version");
}
foreach my $data (## no critic (RequireInterpolationOfMetachars)
# from the POD
[ 1, 'my $seen = { __FILE__ => 1 };' ],
[ 1, '$obj->{__PACKAGE__}{myextra} = 123;' ],
[ 1, 'my $hash = { \'Foo\'.__FILE__ => 123 };' ],
[ 1, 'return (\'MyExtra::\'.__PACKAGE__ => 123);' ],
[ 1, '$hash{__PACKAGE__}' ],
[ 1, '$hash{__FILE__}' ],
[ 1, '$hash{__LINE__}' ],
[ 1, '$hash{ __PACKAGE__ }' ],
[ 0, '$hash{"__PACKAGE__"}' ],
[ 0, '$hash{\'__PACKAGE__\'}' ],
[ 0, '$hash{q{__PACKAGE__}}' ],
[ 0, '$hash{SOMETHING}' ],
[ 0, '$hash{(__PACKAGE__)}}' ],
[ 0, '$hash{__PACKAGE__.""}' ],
[ 1, '$href = { __PACKAGE__ => 123 }' ],
[ 0, "\$href = { __PACKAGE__ \n => 123 }" ],
[ 1, '$href = { __FILE__ => 123 }' ],
[ 1, '$href = { __LINE__ => 123 }' ],
[ 0, '$href = { SOMETHING => 123 }' ],
[ 1, '$href = { __PACKAGE__ => 123, FOO => 123 }' ],
[ 1, '$href = { FOO => 123, __PACKAGE__ => 123 }' ],
[ 1, '$href = { FOO => 123 => __PACKAGE__ => 123 }' ],
[ 0, '$href = { __PACKAGE__."x" => 123 }' ],
# it's the token immediately left of the => which is
# literal, so though __PACKAGE__ is part of a "."
# expression it's used literally, not expanded
[ 1, '$href = { "x".__PACKAGE__ => 123 }' ],
[ 0, '__PACKAGE__' ],
[ 0, 'return __PACKAGE__;' ],
[ 0, '{__PACKAGE__}' ],
[ 0, '{__PACKAGE__; 123}' ],
# in a code block return value like this __PACKAGE__ is
# still literal, not expanded
[ 1, '{; __PACKAGE__ => 123}' ],
## use critic
) {
my ($want_count, $str) = @$data;
my @violations = $critic->critique (\$str);
my $got_count = scalar @violations;
is ($got_count, $want_count, "str: $str");
if ($got_count != $want_count) {
foreach (@violations) {
diag ($_->description);
}
}
}
exit 0;
|
