1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
|
/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4; fill-column: 100 -*- */
/*
* This file is part of the LibreOffice project.
*
* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/.
*/
#include <rtl/strbuf.hxx>
#include <rtl/string.hxx>
#include <rtl/ustrbuf.hxx>
#include <rtl/ustring.hxx>
// ---------------------------------------------------------------
// replacing OUStringBuffer.append sequences to OUString+
namespace test1
{
void f1()
{
// expected-error@+1 {{convert this append sequence into a *String + sequence [loplugin:bufferadd]}}
OUStringBuffer v;
v.append("xxx");
v.append("xxx");
}
void f2()
{
// expected-error@+1 {{convert this append sequence into a *String + sequence [loplugin:bufferadd]}}
OUStringBuffer v;
v.append("xxx").append("aaaa");
}
void f3(OString class_name)
{
// expected-error@+1 {{convert this append sequence into a *String + sequence [loplugin:bufferadd]}}
OStringBuffer sig_buf(5 + class_name.getLength());
sig_buf.append("(I)L");
//sig_buf.append( class_name.replace( '.', '/' ) );
sig_buf.append(';');
OString sig(sig_buf.makeStringAndClear());
(void)sig;
}
void f4(sal_Unicode const* pPathBegin)
{
// expected-error@+1 {{convert this append sequence into a *String + sequence [loplugin:bufferadd]}}
OUStringBuffer v;
v.append(pPathBegin, 12);
v.append("aaaa");
}
void f5(OUStringBuffer& input)
{
// expected-error@+1 {{convert this append sequence into a *String + sequence [loplugin:bufferadd]}}
OUStringBuffer v(input);
v.append("aaaa");
}
void f6(OString const& s)
{
// expected-error@+1 {{convert this append sequence into a *String + sequence [loplugin:bufferadd]}}
OUStringBuffer b("foo");
b.append(OStringToOUString(s, RTL_TEXTENCODING_ASCII_US));
}
struct Footer
{
OStringBuffer m_descriptorStart;
OString m_descriptorEnd;
OString f8() const
{
// expected-error@+1 {{convert this append sequence into a *String + sequence [loplugin:bufferadd]}}
OStringBuffer buf(m_descriptorStart);
buf.append(m_descriptorEnd);
return buf.makeStringAndClear();
}
};
}
namespace test2
{
void f2()
{
// no warning expected
OUStringBuffer v;
v.append("xxx");
if (true)
v.append("yyyy");
}
void appendTo(OUStringBuffer&);
void f3()
{
// no warning expected
OUStringBuffer v;
appendTo(v);
v.append("xxx");
}
void f4()
{
// no warning expected
OUStringBuffer v;
v.append("xxx");
v.setLength(0);
}
void f5()
{
// no warning expected
OUStringBuffer v;
v.append("xxx");
v[1] = 'x';
}
void f6()
{
// no warning expected
OUStringBuffer noel1("xxx");
while (true)
noel1.append("ffff").append("aaa");
}
void f7()
{
// expected-error@+1 {{convert this append sequence into a *String + sequence [loplugin:bufferadd]}}
OStringBuffer noelf7("xxx");
noelf7 = "xxx" + noelf7 + "xxx";
}
}
/* vim:set shiftwidth=4 softtabstop=4 expandtab cinoptions=b1,g0,N-s cinkeys+=0=break: */
|
