1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
|
/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4; fill-column: 100 -*- */
/*
* This file is part of the LibreOffice project.
*
* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/.
*/
#include "sal/config.h"
// no warning expected
namespace test1
{
class Foo
{
~Foo() { f(); }
void f();
};
}
namespace test2
{
class Foo
{
~Foo() { f(); }
// expected-error@-1 {{calling virtual method from destructor, either make the virtual method final, or make this class final [loplugin:fragiledestructor]}}
virtual void f();
// expected-note@-1 {{callee method here [loplugin:fragiledestructor]}}
};
}
// no warning expected
namespace test3
{
class Foo final
{
~Foo() { f(); }
#if __has_warning("-Wunnecessary-virtual-specifier")
#pragma clang diagnostic ignored "-Wunnecessary-virtual-specifier"
#endif
virtual void f();
};
}
namespace test4
{
struct Bar
{
virtual ~Bar();
virtual void f();
// expected-note@-1 {{callee method here [loplugin:fragiledestructor]}}
};
class Foo : public Bar
{
~Foo() { f(); }
// expected-error@-1 {{calling virtual method from destructor, either make the virtual method final, or make this class final [loplugin:fragiledestructor]}}
};
}
// no warning expected
namespace test5
{
struct Bar
{
virtual ~Bar();
virtual void f();
};
class Foo : public Bar
{
~Foo() { f(); }
virtual void f() final override;
};
}
// no warning expected
namespace test6
{
struct Bar
{
virtual ~Bar();
virtual void f();
};
class Foo : public Bar
{
~Foo() { Foo::f(); }
virtual void f() override;
};
}
/* vim:set shiftwidth=4 softtabstop=4 expandtab cinoptions=b1,g0,N-s cinkeys+=0=break: */
|
