1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376
|
/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
/*
* This file is part of the LibreOffice project.
*
* Based on LLVM/Clang.
*
* This file is distributed under the University of Illinois Open Source
* License. See LICENSE.TXT for details.
*
*/
#include "plugin.hxx"
#include "check.hxx"
#include <regex>
/**
* Changes calls to tools::Rectangle/Point/Size methods that return a ref to instead call the setter methods.
*
* run as:
* make COMPILER_PLUGIN_TOOL=changetoolsgen UPDATE_FILES=all FORCE_COMPILE=all
* or
* make <module> COMPILER_PLUGIN_TOOL=changetoolsgen FORCE_COMPILE=all
*/
namespace
{
class ChangeToolsGen : public loplugin::FilteringRewritePlugin<ChangeToolsGen>
{
public:
explicit ChangeToolsGen(loplugin::InstantiationData const& data)
: FilteringRewritePlugin(data)
{
}
virtual void run() override;
bool VisitCXXMemberCallExpr(CXXMemberCallExpr const* call);
private:
bool ChangeAssignment(Stmt const* parent, std::string const& methodName,
std::string const& setPrefix);
bool ChangeBinaryOperatorPlusMinus(BinaryOperator const* parent, CXXMemberCallExpr const* call,
std::string const& methodName);
bool ChangeBinaryOperatorOther(BinaryOperator const* parent, CXXMemberCallExpr const* call,
std::string const& methodName, std::string const& setPrefix);
bool ChangeUnaryOperator(UnaryOperator const* parent, CXXMemberCallExpr const* call,
std::string const& methodName);
std::string extractCode(SourceLocation startLoc, SourceLocation endLoc);
};
void ChangeToolsGen::run() { TraverseDecl(compiler.getASTContext().getTranslationUnitDecl()); }
bool ChangeToolsGen::VisitCXXMemberCallExpr(CXXMemberCallExpr const* call)
{
if (ignoreLocation(call))
return true;
const CXXMethodDecl* func = call->getMethodDecl();
if (!func)
return true;
if (func->isConst())
return true;
auto dc = loplugin::DeclCheck(func);
std::string methodName;
std::string setPrefix;
if (dc.Function("Top").Class("Rectangle").Namespace("tools").GlobalNamespace())
{
methodName = "Top";
setPrefix = "Set";
}
else if (dc.Function("Bottom").Class("Rectangle").Namespace("tools").GlobalNamespace())
{
methodName = "Bottom";
setPrefix = "Set";
}
else if (dc.Function("Left").Class("Rectangle").Namespace("tools").GlobalNamespace())
{
methodName = "Left";
setPrefix = "Set";
}
else if (dc.Function("Right").Class("Rectangle").Namespace("tools").GlobalNamespace())
{
methodName = "Right";
setPrefix = "Set";
}
else if (dc.Function("X").Class("Point").GlobalNamespace())
{
methodName = "X";
setPrefix = "set";
}
else if (dc.Function("Y").Class("Point").GlobalNamespace())
{
methodName = "Y";
setPrefix = "set";
}
else if (dc.Function("Width").Class("Size").GlobalNamespace())
{
methodName = "Width";
setPrefix = "set";
}
else if (dc.Function("Height").Class("Size").GlobalNamespace())
{
methodName = "Height";
setPrefix = "set";
}
else
return true;
if (!loplugin::TypeCheck(func->getReturnType()).LvalueReference())
return true;
auto parent = getParentStmt(call);
if (!parent)
return true;
if (auto unaryOp = dyn_cast<UnaryOperator>(parent))
{
if (!ChangeUnaryOperator(unaryOp, call, methodName))
report(DiagnosticsEngine::Warning, "Could not fix, unary", call->getBeginLoc());
return true;
}
auto binaryOp = dyn_cast<BinaryOperator>(parent);
if (!binaryOp)
{
// normal getter
return true;
}
auto opcode = binaryOp->getOpcode();
if (opcode == BO_Assign)
{
// Check for assignments embedded inside other expressions
auto parent2 = getParentStmt(parent);
if (dyn_cast_or_null<ExprWithCleanups>(parent2))
parent2 = getParentStmt(parent2);
if (parent2 && isa<Expr>(parent2))
{
report(DiagnosticsEngine::Warning, "Could not fix, embedded assign",
call->getBeginLoc());
return true;
}
// Check for
// X.Width() = X.Height() = 1;
if (auto rhs = dyn_cast<BinaryOperator>(binaryOp->getRHS()->IgnoreParenImpCasts()))
if (rhs->getOpcode() == BO_Assign)
{
report(DiagnosticsEngine::Warning, "Could not fix, double assign",
call->getBeginLoc());
return true;
}
if (!ChangeAssignment(parent, methodName, setPrefix))
report(DiagnosticsEngine::Warning, "Could not fix, assign", call->getBeginLoc());
return true;
}
if (opcode == BO_AddAssign || opcode == BO_SubAssign)
{
if (!ChangeBinaryOperatorPlusMinus(binaryOp, call, methodName))
report(DiagnosticsEngine::Warning, "Could not fix, assign-and-change",
call->getBeginLoc());
return true;
}
else if (opcode == BO_RemAssign || opcode == BO_MulAssign || opcode == BO_DivAssign)
{
if (!ChangeBinaryOperatorOther(binaryOp, call, methodName, setPrefix))
report(DiagnosticsEngine::Warning, "Could not fix, assign-and-change",
call->getBeginLoc());
return true;
}
else
assert(false);
return true;
}
bool ChangeToolsGen::ChangeAssignment(Stmt const* parent, std::string const& methodName,
std::string const& setPrefix)
{
// Look for expressions like
// aRect.Left() = ...;
// and replace with
// aRect.SetLeft( ... );
SourceManager& SM = compiler.getSourceManager();
SourceLocation startLoc = SM.getExpansionLoc(parent->getBeginLoc());
SourceLocation endLoc = SM.getExpansionLoc(parent->getEndLoc());
const char* p1 = SM.getCharacterData(startLoc);
const char* p2 = SM.getCharacterData(endLoc);
unsigned n = Lexer::MeasureTokenLength(endLoc, SM, compiler.getLangOpts());
if (p2 < p1) // clang is misbehaving, appears to be macro constant related
return false;
std::string callText(p1, p2 - p1 + n);
auto originalLength = callText.size();
auto newText = std::regex_replace(callText, std::regex(methodName + " *\\( *\\) *="),
setPrefix + methodName + "(");
if (newText == callText)
return false;
newText += " )";
return replaceText(startLoc, originalLength, newText);
}
bool ChangeToolsGen::ChangeBinaryOperatorPlusMinus(BinaryOperator const* binaryOp,
CXXMemberCallExpr const* call,
std::string const& methodName)
{
// Look for expressions like
// aRect.Left() += ...;
// and replace with
// aRect.MoveLeft( ... );
SourceManager& SM = compiler.getSourceManager();
SourceLocation startLoc = SM.getExpansionLoc(binaryOp->getBeginLoc());
SourceLocation endLoc = SM.getExpansionLoc(binaryOp->getEndLoc());
const char* p1 = SM.getCharacterData(startLoc);
const char* p2 = SM.getCharacterData(endLoc);
if (p2 < p1) // clang is misbehaving, appears to be macro constant related
return false;
unsigned n = Lexer::MeasureTokenLength(endLoc, SM, compiler.getLangOpts());
std::string callText(p1, p2 - p1 + n);
auto originalLength = callText.size();
std::string newText;
if (binaryOp->getOpcode() == BO_AddAssign)
{
newText = std::regex_replace(callText, std::regex(methodName + " *\\( *\\) *\\+= *"),
"Adjust" + methodName + "(");
newText += " )";
}
else
{
newText = std::regex_replace(callText, std::regex(methodName + " *\\( *\\) *\\-= *"),
"Adjust" + methodName + "( -(");
newText += ") )";
}
if (newText == callText)
{
report(DiagnosticsEngine::Warning, "binaryop-plusminus regex match failed",
call->getBeginLoc());
return false;
}
return replaceText(startLoc, originalLength, newText);
}
bool ChangeToolsGen::ChangeBinaryOperatorOther(BinaryOperator const* binaryOp,
CXXMemberCallExpr const* call,
std::string const& methodName,
std::string const& setPrefix)
{
// Look for expressions like
// aRect.Left() += ...;
// and replace with
// aRect.SetLeft( aRect.GetLeft() + ... );
SourceManager& SM = compiler.getSourceManager();
SourceLocation startLoc = SM.getExpansionLoc(binaryOp->getBeginLoc());
SourceLocation endLoc = SM.getExpansionLoc(binaryOp->getEndLoc());
const char* p1 = SM.getCharacterData(startLoc);
const char* p2 = SM.getCharacterData(endLoc);
if (p2 < p1) // clang is misbehaving, appears to be macro constant related
return false;
unsigned n = Lexer::MeasureTokenLength(endLoc, SM, compiler.getLangOpts());
std::string callText(p1, p2 - p1 + n);
auto originalLength = callText.size();
std::string regexOpname;
std::string replaceOpname;
switch (binaryOp->getOpcode())
{
case BO_RemAssign:
regexOpname = "\\%=";
replaceOpname = "%";
break;
case BO_MulAssign:
regexOpname = "\\*=";
replaceOpname = "*";
break;
case BO_DivAssign:
regexOpname = "\\/=";
replaceOpname = "/";
break;
default:
assert(false);
}
auto implicitObjectText = extractCode(call->getImplicitObjectArgument()->getExprLoc(),
call->getImplicitObjectArgument()->getExprLoc());
std::string reString(methodName + " *\\( *\\) *" + regexOpname);
auto newText = std::regex_replace(callText, std::regex(reString),
setPrefix + methodName + "( " + implicitObjectText + "."
+ methodName + "() " + replaceOpname + " (");
if (newText == callText)
{
report(DiagnosticsEngine::Warning, "binaryop-other regex match failed %0",
call->getBeginLoc())
<< reString;
return false;
}
// sometimes we end up with duplicate spaces after the opname
newText
= std::regex_replace(newText, std::regex(methodName + "\\(\\) \\" + replaceOpname + " "),
methodName + "() " + replaceOpname + " ");
newText += ") )";
return replaceText(startLoc, originalLength, newText);
}
bool ChangeToolsGen::ChangeUnaryOperator(UnaryOperator const* unaryOp,
CXXMemberCallExpr const* call,
std::string const& methodName)
{
// Look for expressions like
// aRect.Left()++;
// ++aRect.Left();
// and replace with
// aRect.MoveLeft( 1 );
SourceManager& SM = compiler.getSourceManager();
SourceLocation startLoc = SM.getExpansionLoc(unaryOp->getBeginLoc());
SourceLocation endLoc = SM.getExpansionLoc(unaryOp->getEndLoc());
const char* p1 = SM.getCharacterData(startLoc);
const char* p2 = SM.getCharacterData(endLoc);
if (p2 < p1) // clang is misbehaving, appears to be macro constant related
return false;
unsigned n = Lexer::MeasureTokenLength(endLoc, SM, compiler.getLangOpts());
std::string callText(p1, p2 - p1 + n);
auto originalLength = callText.size();
auto implicitObjectText = extractCode(call->getImplicitObjectArgument()->getExprLoc(),
call->getImplicitObjectArgument()->getExprLoc());
auto op = unaryOp->getOpcode();
std::string regexOpname;
std::string replaceOp;
switch (op)
{
case UO_PostInc:
case UO_PreInc:
replaceOp = "1";
regexOpname = "\\+\\+";
break;
case UO_PostDec:
case UO_PreDec:
replaceOp = "-1";
regexOpname = "\\-\\-";
break;
default:
assert(false);
}
std::string newText;
std::string reString;
if (op == UO_PostInc || op == UO_PostDec)
{
reString = methodName + " *\\( *\\) *" + regexOpname;
newText = std::regex_replace(callText, std::regex(reString),
"Adjust" + methodName + "( " + replaceOp);
}
else
{
newText = implicitObjectText + "." + "Adjust" + methodName + "( " + replaceOp;
}
if (newText == callText)
{
report(DiagnosticsEngine::Warning, "unaryop regex match failed %0", call->getBeginLoc())
<< reString;
return false;
}
newText += " )";
return replaceText(startLoc, originalLength, newText);
}
std::string ChangeToolsGen::extractCode(SourceLocation startLoc, SourceLocation endLoc)
{
SourceManager& SM = compiler.getSourceManager();
const char* p1 = SM.getCharacterData(SM.getExpansionLoc(startLoc));
const char* p2 = SM.getCharacterData(SM.getExpansionLoc(endLoc));
unsigned n = Lexer::MeasureTokenLength(endLoc, SM, compiler.getLangOpts());
return std::string(p1, p2 - p1 + n);
}
static loplugin::Plugin::Registration<ChangeToolsGen> X("changetoolsgen", false);
} // namespace
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
|