1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
|
/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
/*
* This file is part of the LibreOffice project.
*
* Based on LLVM/Clang.
*
* This file is distributed under the University of Illinois Open Source
* License. See LICENSE.TXT for details.
*
*/
#ifndef LO_CLANG_SHARED_PLUGINS
#include <cassert>
#include <string>
#include <iostream>
#include <fstream>
#include <set>
#include <unordered_set>
#include "plugin.hxx"
#include "check.hxx"
/*
Look for places where we are using cow_wrapper, but we are calling a const method on the impl object
with a non-const pointer, which means we will unnecessarily trigger a copy.
*/
namespace
{
class Cow_Wrapper : public loplugin::FilteringPlugin<Cow_Wrapper>
{
public:
explicit Cow_Wrapper(loplugin::InstantiationData const& data)
: FilteringPlugin(data)
{
}
bool shouldVisitTemplateInstantiations() const { return true; }
virtual bool preRun() override { return true; }
virtual void run() override
{
if (preRun())
TraverseDecl(compiler.getASTContext().getTranslationUnitDecl());
}
bool VisitCXXMemberCallExpr(const CXXMemberCallExpr*);
};
bool Cow_Wrapper::VisitCXXMemberCallExpr(const CXXMemberCallExpr* memberCallExpr)
{
if (ignoreLocation(memberCallExpr))
return true;
auto methodDecl = memberCallExpr->getMethodDecl();
if (!methodDecl || !methodDecl->isConst())
return true;
auto expr = memberCallExpr->getImplicitObjectArgument()->IgnoreImplicit()->IgnoreParens();
auto operatorCallExpr = dyn_cast<CXXOperatorCallExpr>(expr);
if (operatorCallExpr && operatorCallExpr->getOperator() == OO_Arrow)
{
auto arrowMethodDecl = dyn_cast_or_null<CXXMethodDecl>(operatorCallExpr->getDirectCallee());
if (!arrowMethodDecl)
return true;
if (arrowMethodDecl->isConst())
return true;
auto dc = loplugin::DeclCheck(arrowMethodDecl->getParent())
.Class("cow_wrapper")
.Namespace("o3tl")
.GlobalNamespace();
if (!dc)
return true;
}
else if (operatorCallExpr)
{
auto methodDecl2 = dyn_cast_or_null<CXXMethodDecl>(operatorCallExpr->getDirectCallee());
if (!methodDecl2)
return true;
auto dc = loplugin::DeclCheck(methodDecl2->getParent())
.Class("cow_wrapper")
.Namespace("o3tl")
.GlobalNamespace();
if (!dc)
return true;
}
else if (auto callExpr = dyn_cast<CallExpr>(expr))
{
if (!isa<ImplicitCastExpr>(callExpr->getCallee())) // std::as_const shows up as this
return true;
if (callExpr->getNumArgs() < 1)
return true;
auto arg0 = dyn_cast<CXXOperatorCallExpr>(callExpr->getArg(0));
if (!arg0)
return true;
auto starMethodDecl = dyn_cast_or_null<CXXMethodDecl>(arg0->getDirectCallee());
if (!starMethodDecl)
return true;
auto dc = loplugin::DeclCheck(starMethodDecl->getParent())
.Class("cow_wrapper")
.Namespace("o3tl")
.GlobalNamespace();
if (!dc)
return true;
}
else
return true;
report(DiagnosticsEngine::Warning,
"calling const method on o3tl::cow_wrapper impl class via non-const pointer, rather use "
"std::as_const to prevent triggering an unnecessary copy",
memberCallExpr->getBeginLoc())
<< memberCallExpr->getSourceRange();
return true;
}
loplugin::Plugin::Registration<Cow_Wrapper> cow_wrapper("cow_wrapper", true);
} // namespace
#endif // LO_CLANG_SHARED_PLUGINS
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
|
