1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
|
/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
/*
* This file is part of the LibreOffice project.
*
* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/.
*/
#include <cassert>
#include <string>
#include <iostream>
#include <set>
#include <unordered_set>
#include "config_clang.h"
#include "compat.hxx"
#include "plugin.hxx"
#include <fstream>
/**
Dump a list of virtual methods and a list of methods overriding virtual methods.
Then we will post-process the 2 lists and find the set of virtual methods which don't need to be virtual.
Also, we look for virtual methods where the bodies of all the overrides are empty i.e. this is leftover code
that no longer has a purpose.
The process goes something like this:
$ make check
$ make FORCE_COMPILE=all COMPILER_PLUGIN_TOOL='unnecessaryvirtual' check
$ ./compilerplugins/clang/unnecessaryvirtual.py
$ for dir in *; do make FORCE_COMPILE=all UPDATE_FILES=$dir COMPILER_PLUGIN_TOOL='removevirtuals' $dir; done
Note that the actual process may involve a fair amount of undoing, hand editing, and general messing around
to get it to work :-)
TODO some boost bind stuff appears to confuse it, notably in the xmloff module
*/
namespace {
struct MyFuncInfo
{
std::string name;
std::string sourceLocation;
};
bool operator < (const MyFuncInfo &lhs, const MyFuncInfo &rhs)
{
return lhs.name < rhs.name;
}
// try to limit the voluminous output a little
static std::set<MyFuncInfo> definitionSet;
static std::unordered_set<std::string> overridingSet;
static std::unordered_set<std::string> nonEmptySet;
class UnnecessaryVirtual:
public RecursiveASTVisitor<UnnecessaryVirtual>, public loplugin::Plugin
{
public:
explicit UnnecessaryVirtual(loplugin::InstantiationData const & data):
Plugin(data) {}
virtual void run() override
{
handler.enableTreeWideAnalysisMode();
TraverseDecl(compiler.getASTContext().getTranslationUnitDecl());
// dump all our output in one write call - this is to try and limit IO "crosstalk" between multiple processes
// writing to the same logfile
std::string output;
for (const MyFuncInfo & s : definitionSet)
output += "definition:\t" + s.name + "\t" + s.sourceLocation + "\n";
for (const std::string & s : overridingSet)
output += "overriding:\t" + s + "\n";
for (const std::string & s : nonEmptySet)
output += "nonempty:\t" + s + "\n";
std::ofstream myfile;
myfile.open( WORKDIR "/loplugin.unnecessaryvirtual.log", std::ios::app | std::ios::out);
myfile << output;
myfile.close();
}
bool shouldVisitTemplateInstantiations () const { return true; }
bool shouldVisitImplicitCode() const { return true; }
bool VisitCXXMethodDecl( const CXXMethodDecl* decl );
private:
void MarkRootOverridesNonEmpty( const CXXMethodDecl* methodDecl );
std::string toString(SourceLocation loc);
};
std::string niceName(const CXXMethodDecl* cxxMethodDecl)
{
while (cxxMethodDecl->getTemplateInstantiationPattern())
cxxMethodDecl = dyn_cast<CXXMethodDecl>(cxxMethodDecl->getTemplateInstantiationPattern());
while (cxxMethodDecl->getInstantiatedFromMemberFunction())
cxxMethodDecl = dyn_cast<CXXMethodDecl>(cxxMethodDecl->getInstantiatedFromMemberFunction());
std::string s = cxxMethodDecl->getReturnType().getCanonicalType().getAsString()
+ " " + cxxMethodDecl->getQualifiedNameAsString() + "(";
for (const ParmVarDecl *pParmVarDecl : cxxMethodDecl->parameters()) {
s += pParmVarDecl->getType().getCanonicalType().getAsString();
s += ",";
}
s += ")";
if (cxxMethodDecl->isConst()) {
s += "const";
}
return s;
}
bool UnnecessaryVirtual::VisitCXXMethodDecl( const CXXMethodDecl* methodDecl )
{
if (!methodDecl->isVirtual() || methodDecl->isDeleted()) {
return true;
}
// ignore stuff that forms part of the stable URE interface
if (isInUnoIncludeFile(methodDecl->getCanonicalDecl())) {
return true;
}
auto body = methodDecl->getBody();
if (body) {
auto compoundStmt = dyn_cast<CompoundStmt>(body);
if (!compoundStmt)
MarkRootOverridesNonEmpty(methodDecl->getCanonicalDecl());
else if (compoundStmt->size() > 0)
MarkRootOverridesNonEmpty(methodDecl->getCanonicalDecl());
}
if (!methodDecl->isThisDeclarationADefinition())
return true;
methodDecl = methodDecl->getCanonicalDecl();
if (!methodDecl)
return true;
std::string aNiceName = niceName(methodDecl);
// for destructors, we need to check if any of the superclass' destructors are virtual
if (isa<CXXDestructorDecl>(methodDecl)) {
const CXXRecordDecl* cxxRecordDecl = methodDecl->getParent();
if (cxxRecordDecl->getNumBases() == 0) {
definitionSet.insert( { aNiceName, toString( methodDecl->getLocation() ) } );
return true;
}
for(auto baseSpecifier = cxxRecordDecl->bases_begin();
baseSpecifier != cxxRecordDecl->bases_end(); ++baseSpecifier)
{
if (baseSpecifier->getType()->isRecordType())
{
const CXXRecordDecl* superclassCXXRecordDecl = baseSpecifier->getType()->getAsCXXRecordDecl();
if (superclassCXXRecordDecl->getDestructor())
{
std::string aOverriddenNiceName = niceName(superclassCXXRecordDecl->getDestructor());
overridingSet.insert(aOverriddenNiceName);
}
}
}
return true;
}
if (methodDecl->size_overridden_methods() == 0) {
definitionSet.insert( { aNiceName, toString( methodDecl->getLocation() ) } );
} else {
for (auto iter = methodDecl->begin_overridden_methods();
iter != methodDecl->end_overridden_methods(); ++iter)
{
const CXXMethodDecl *overriddenMethod = *iter;
// we only care about the first level override to establish that a virtual qualifier was useful.
if (compat::isPureVirtual(overriddenMethod)
|| overriddenMethod->size_overridden_methods() == 0)
{
std::string aOverriddenNiceName = niceName(overriddenMethod);
overridingSet.insert(aOverriddenNiceName);
}
}
}
return true;
}
void UnnecessaryVirtual::MarkRootOverridesNonEmpty( const CXXMethodDecl* methodDecl )
{
if (!methodDecl)
return;
if (methodDecl->size_overridden_methods() == 0) {
nonEmptySet.insert(niceName(methodDecl));
return;
}
for (auto iter = methodDecl->begin_overridden_methods();
iter != methodDecl->end_overridden_methods(); ++iter)
{
MarkRootOverridesNonEmpty(*iter);
}
}
std::string UnnecessaryVirtual::toString(SourceLocation loc)
{
SourceLocation expansionLoc = compiler.getSourceManager().getExpansionLoc( loc );
StringRef name = getFilenameOfLocation(expansionLoc);
std::string sourceLocation = std::string(name.substr(strlen(SRCDIR)+1)) + ":" + std::to_string(compiler.getSourceManager().getSpellingLineNumber(expansionLoc));
loplugin::normalizeDotDotInFilePath(sourceLocation);
return sourceLocation;
}
loplugin::Plugin::Registration< UnnecessaryVirtual > X("unnecessaryvirtual", false);
}
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
|
