File: we-dont-have-the-needed-fonts.diff

package info (click to toggle)
libreoffice 4%3A25.8.4-1
  • links: PTS, VCS
  • area: main
  • in suites: forky, sid
  • size: 3,821,596 kB
  • sloc: cpp: 4,380,697; xml: 499,713; java: 257,208; python: 80,923; ansic: 33,825; perl: 30,305; javascript: 19,722; sh: 11,717; makefile: 10,614; cs: 8,865; yacc: 8,549; objc: 2,131; lex: 1,379; asm: 1,231; awk: 996; pascal: 914; csh: 20; sed: 5
file content (224 lines) | stat: -rw-r--r-- 8,974 bytes parent folder | download | duplicates (2)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
diff --git a/sw/qa/core/text/text.cxx b/sw/qa/core/text/text.cxx
index a4d4540ab228..46d262f6f0b8 100644
--- a/sw/qa/core/text/text.cxx
+++ b/sw/qa/core/text/text.cxx
@@ -9,6 +9,8 @@
 
 #include <swmodeltestbase.hxx>
 
+#include <config_fonts.h>
+
 #include <memory>
 
 #include <com/sun/star/text/BibliographyDataField.hpp>
@@ -1363,6 +1365,8 @@ CPPUNIT_TEST_FIXTURE(SwCoreTextTest, testParaUpperMarginFlyIntersect)
     CPPUNIT_ASSERT_EQUAL(521, nHeight);
 }
 
+/* needs Source Han Serif SC*/
+#if HAVE_MORE_FONTS
 CPPUNIT_TEST_FIXTURE(SwCoreTextTest, testTdf129810)
 {
     // Load the document.
@@ -1394,6 +1398,7 @@ CPPUNIT_TEST_FIXTURE(SwCoreTextTest, testTdf129810)
         }
     }
 }
+#endif
 
 CPPUNIT_TEST_FIXTURE(SwCoreTextTest, testScriptinfosurrogatePairs)
 {
diff --git a/vcl/qa/cppunit/pdfexport/pdfexport2.cxx b/vcl/qa/cppunit/pdfexport/pdfexport2.cxx
index 2c314d6b886f..b50e7dd4d82f 100644
--- a/vcl/qa/cppunit/pdfexport/pdfexport2.cxx
+++ b/vcl/qa/cppunit/pdfexport/pdfexport2.cxx
@@ -5045,68 +5045,73 @@ CPPUNIT_TEST_FIXTURE(PdfExportTest2, testTdf134226)
     fnEqualPos(aRect[3], aRect[5]);
 }
 
-// tdf#71956 - Tests that glyphs can be individually styled
-CPPUNIT_TEST_FIXTURE(PdfExportTest2, testTdf71956)
-{
-    saveAsPDF(u"tdf71956-styled-diacritics.fodt");
-    std::unique_ptr<vcl::pdf::PDFiumDocument> pPdfDocument = parsePDFExport();
-
-    CPPUNIT_ASSERT_EQUAL(1, pPdfDocument->getPageCount());
-
-    // Get the first page
-    std::unique_ptr<vcl::pdf::PDFiumPage> pPdfPage = pPdfDocument->openPage(/*nIndex*/ 0);
-    CPPUNIT_ASSERT(pPdfPage);
-    std::unique_ptr<vcl::pdf::PDFiumTextPage> pTextPage = pPdfPage->getTextPage();
-    CPPUNIT_ASSERT(pTextPage);
-
-    int nPageObjectCount = pPdfPage->getObjectCount();
-    CPPUNIT_ASSERT_EQUAL(12, nPageObjectCount);
-
-    std::vector<OUString> aText;
-    std::vector<basegfx::B2DRectangle> aRect;
-
-    int nTextObjectCount = 0;
-    for (int i = 0; i < nPageObjectCount; ++i)
-    {
-        auto pPageObject = pPdfPage->getObject(i);
-        CPPUNIT_ASSERT_MESSAGE("no object", pPageObject != nullptr);
-        if (pPageObject->getType() == vcl::pdf::PDFPageObjectType::Text)
-        {
-            aText.push_back(pPageObject->getText(pTextPage));
-            aRect.push_back(pPageObject->getBounds());
-            ++nTextObjectCount;
-        }
-    }
-
-    CPPUNIT_ASSERT_EQUAL(12, nTextObjectCount);
-
-    CPPUNIT_ASSERT_EQUAL(u"ه"_ustr, aText[0].trim());
-    CPPUNIT_ASSERT_EQUAL(u"\u064e\u0651\u0670ل"_ustr, aText[1].trim());
-    CPPUNIT_ASSERT_EQUAL(u""_ustr, aText[2].trim());
-    CPPUNIT_ASSERT_EQUAL(u""_ustr, aText[3].trim());
-    CPPUNIT_ASSERT_EQUAL(u""_ustr, aText[4].trim());
-    CPPUNIT_ASSERT_EQUAL(u"ل"_ustr, aText[5].trim());
-    CPPUNIT_ASSERT_EQUAL(u"ل"_ustr, aText[6].trim());
-    CPPUNIT_ASSERT_EQUAL(u"\u064e\u0651\u0670ل"_ustr, aText[7].trim());
-    CPPUNIT_ASSERT_EQUAL(u""_ustr, aText[8].trim());
-    CPPUNIT_ASSERT_EQUAL(u""_ustr, aText[9].trim());
-    CPPUNIT_ASSERT_EQUAL(u""_ustr, aText[10].trim());
-    CPPUNIT_ASSERT_EQUAL(u"ه"_ustr, aText[11].trim());
-
-    // Verify that the corresponding text segments are positioned roughly equally
-    auto fnEqualPos
-        = [](const basegfx::B2DRectangle& stExpected, const basegfx::B2DRectangle& stFound) {
-              CPPUNIT_ASSERT_DOUBLES_EQUAL(stExpected.getMinX(), stFound.getMinX(), /*delta*/ 0.15);
-              CPPUNIT_ASSERT_DOUBLES_EQUAL(stExpected.getMaxX(), stFound.getMaxX(), /*delta*/ 0.15);
-          };
-
-    fnEqualPos(aRect[0], aRect[11]);
-    fnEqualPos(aRect[1], aRect[10]);
-    fnEqualPos(aRect[2], aRect[8]);
-    fnEqualPos(aRect[3], aRect[9]);
-    fnEqualPos(aRect[4], aRect[7]);
-    fnEqualPos(aRect[5], aRect[6]);
-}
+/* uses Noto Sans Arabic.
+ * visually looking at this this seems to work ; it seems even when having that one installed
+ * I get it cusive (not being there). In a clean VM I get it but not in the chroot even thoug
+ * fc-list shows it.
+ * Disable it for now.*/
+//// tdf#71956 - Tests that glyphs can be individually styled
+//CPPUNIT_TEST_FIXTURE(PdfExportTest2, testTdf71956)
+//{
+//    saveAsPDF(u"tdf71956-styled-diacritics.fodt");
+//    std::unique_ptr<vcl::pdf::PDFiumDocument> pPdfDocument = parsePDFExport();
+//
+//    CPPUNIT_ASSERT_EQUAL(1, pPdfDocument->getPageCount());
+//
+//    // Get the first page
+//    std::unique_ptr<vcl::pdf::PDFiumPage> pPdfPage = pPdfDocument->openPage(/*nIndex*/ 0);
+//    CPPUNIT_ASSERT(pPdfPage);
+//    std::unique_ptr<vcl::pdf::PDFiumTextPage> pTextPage = pPdfPage->getTextPage();
+//    CPPUNIT_ASSERT(pTextPage);
+//
+//    int nPageObjectCount = pPdfPage->getObjectCount();
+//    CPPUNIT_ASSERT_EQUAL(12, nPageObjectCount);
+//
+//    std::vector<OUString> aText;
+//    std::vector<basegfx::B2DRectangle> aRect;
+//
+//    int nTextObjectCount = 0;
+//    for (int i = 0; i < nPageObjectCount; ++i)
+//    {
+//        auto pPageObject = pPdfPage->getObject(i);
+//        CPPUNIT_ASSERT_MESSAGE("no object", pPageObject != nullptr);
+//        if (pPageObject->getType() == vcl::pdf::PDFPageObjectType::Text)
+//        {
+//            aText.push_back(pPageObject->getText(pTextPage));
+//            aRect.push_back(pPageObject->getBounds());
+//            ++nTextObjectCount;
+//        }
+//    }
+//
+//    CPPUNIT_ASSERT_EQUAL(12, nTextObjectCount);
+//
+//    CPPUNIT_ASSERT_EQUAL(u"ه"_ustr, aText[0].trim());
+//    CPPUNIT_ASSERT_EQUAL(u"\u064e\u0651\u0670ل"_ustr, aText[1].trim());
+//    CPPUNIT_ASSERT_EQUAL(u""_ustr, aText[2].trim());
+//    CPPUNIT_ASSERT_EQUAL(u""_ustr, aText[3].trim());
+//    CPPUNIT_ASSERT_EQUAL(u""_ustr, aText[4].trim());
+//    CPPUNIT_ASSERT_EQUAL(u"ل"_ustr, aText[5].trim());
+//    CPPUNIT_ASSERT_EQUAL(u"ل"_ustr, aText[6].trim());
+//    CPPUNIT_ASSERT_EQUAL(u"\u064e\u0651\u0670ل"_ustr, aText[7].trim());
+//    CPPUNIT_ASSERT_EQUAL(u""_ustr, aText[8].trim());
+//    CPPUNIT_ASSERT_EQUAL(u""_ustr, aText[9].trim());
+//    CPPUNIT_ASSERT_EQUAL(u""_ustr, aText[10].trim());
+//    CPPUNIT_ASSERT_EQUAL(u"ه"_ustr, aText[11].trim());
+//
+//    // Verify that the corresponding text segments are positioned roughly equally
+//    auto fnEqualPos
+//        = [](const basegfx::B2DRectangle& stExpected, const basegfx::B2DRectangle& stFound) {
+//              CPPUNIT_ASSERT_DOUBLES_EQUAL(stExpected.getMinX(), stFound.getMinX(), /*delta*/ 0.15);
+//              CPPUNIT_ASSERT_DOUBLES_EQUAL(stExpected.getMaxX(), stFound.getMaxX(), /*delta*/ 0.15);
+//          };
+//
+//    fnEqualPos(aRect[0], aRect[11]);
+//    fnEqualPos(aRect[1], aRect[10]);
+//    fnEqualPos(aRect[2], aRect[8]);
+//    fnEqualPos(aRect[3], aRect[9]);
+//    fnEqualPos(aRect[4], aRect[7]);
+//    fnEqualPos(aRect[5], aRect[6]);
+//}
 
 // tdf#101686 - Verifies that drawinglayer clears RTL flags while drawing Writer text boxes
 CPPUNIT_TEST_FIXTURE(PdfExportTest2, testTdf101686)
diff --git a/vcl/qa/cppunit/complextext.cxx b/vcl/qa/cppunit/complextext.cxx
index 9be428b59128..a833314bd23d 100644
--- a/vcl/qa/cppunit/complextext.cxx
+++ b/vcl/qa/cppunit/complextext.cxx
@@ -792,49 +792,6 @@ CPPUNIT_TEST_FIXTURE(VclComplexTextTest, testTdf165510)
     }
 }
 
-CPPUNIT_TEST_FIXTURE(VclComplexTextTest, testTdf154104)
-{
-    ScopedVclPtrInstance<VirtualDevice> pOutDev;
-
-    vcl::Font aBaseFont{ u"David Libre"_ustr, u"Regular"_ustr, Size{ 0, 72 } };
-    pOutDev->SetFont(aBaseFont);
-
-    vcl::Font aFallbackFont{ u"Noto Sans Arabic"_ustr, u"Regular"_ustr, Size{ 0, 72 } };
-    pOutDev->ForceFallbackFont(aFallbackFont);
-
-    pOutDev->SetLayoutMode(vcl::text::ComplexTextLayoutFlags::BiDiRtl
-                           | vcl::text::ComplexTextLayoutFlags::BiDiStrong);
-
-    auto aText = u"\u05D0\u05D0\u05D0\u0644\u0627"_ustr;
-    KernArray aKernArray = { 100, 200, 300, 350, 400 };
-    auto pLayout = pOutDev->ImplLayout(aText, /*nIndex*/ 0, /*nLen*/ aText.getLength(),
-                                       /*rLogicPos*/ Point(0, 0), /*nLogicWidth*/ 0, aKernArray);
-
-    // Fallback must have happened for this test to be meaningful
-    auto pMultiLayout = dynamic_cast<MultiSalLayout*>(pLayout.get());
-    CPPUNIT_ASSERT(pMultiLayout);
-
-    std::vector<double> aCharX;
-
-    const GlyphItem* pGlyph = nullptr;
-    basegfx::B2DPoint stPos;
-    int nCurrPos = 0;
-    while (pLayout->GetNextGlyph(&pGlyph, stPos, nCurrPos))
-    {
-        aCharX.push_back(stPos.getX());
-    }
-
-    // tdf#154104 caused overlapping glyphs in fallback runs:
-    //                           { -295.0, -195.0, -95.0, -341.0 }
-    std::vector<double> aRefCharX{ -245.0, -145.0, -45.0, -341.0 };
-
-    CPPUNIT_ASSERT_EQUAL(aRefCharX.size(), aCharX.size());
-    for (size_t i = 0; i < aRefCharX.size(); ++i)
-    {
-        CPPUNIT_ASSERT_DOUBLES_EQUAL(aRefCharX.at(i), aCharX.at(i), /*delta*/ 0.2);
-    }
-}
-
 CPPUNIT_TEST_FIXTURE(VclComplexTextTest, testTdf163761)
 {
     ScopedVclPtrInstance<VirtualDevice> pOutDev;