1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226
|
#!/usr/bin/perl
use strict;
use warnings;
use lib 'lib', 't/lib';
use MyTests tests => 29;
{
# test no conflicts here
package Role::A;
use Role::Basic;
sub bar { 'Role::A::bar' }
package Role::B;
use Role::Basic;
sub xxy { 'Role::B::xxy' }
package Role::C;
use Role::Basic;
::is( ::exception {
with qw(Role::A Role::B); # no conflict here
}, undef, "define role C" );
sub foo { 'Role::C::foo' }
sub zot { 'Role::C::zot' }
package Class::A;
use Role::Basic 'with';
sub new { bless {} => shift }
::is( ::exception {
with qw(Role::C);
}, undef, "define class A" );
sub zot { 'Class::A::zot' }
}
can_ok( Class::A->new, qw(foo bar xxy zot) );
is( Class::A->new->foo, "Role::C::foo", "... got the right foo method" );
is( Class::A->new->zot, "Class::A::zot", "... got the right zot method" );
is( Class::A->new->bar, "Role::A::bar", "... got the right bar method" );
is( Class::A->new->xxy, "Role::B::xxy", "... got the right xxy method" );
{
# check that when a role is added to another role
# and they conflict and the method they conflict
# with is then required.
package Role::A::Conflict;
use Role::Basic;
with 'Role::A';
sub bar { 'Role::A::Conflict::bar' }
package Class::A::Conflict;
use Role::Basic 'with';
::like(
::exception{ with 'Role::A::Conflict';
},
qr/Due to a method name conflict in roles 'Role::A' and 'Role::A::Conflict', the method 'bar' must be implemented or excluded by 'Class::A::Conflict'/,
'... did not fulfill the requirement of &bar method'
);
package Class::A::Resolved;
use Role::Basic 'with';
sub new { bless {} => shift }
::is( ::exception {
with 'Role::A::Conflict';
}, undef, '... did fufill the requirement of &bar method' );
sub bar { 'Class::A::Resolved::bar' }
}
TODO: {
local $TODO = 'Check to see why this is done and if we need it';
ok(
Role::Basic->requires_method( 'Role::A::Conflict', 'bar' ),
'... Role::A::Conflict created the bar requirement'
);
}
can_ok( Class::A::Resolved->new, qw(bar) );
is( Class::A::Resolved->new->bar, 'Class::A::Resolved::bar', "... got the right bar method" );
{
# check that when two roles are composed, they conflict
# but the composing role can resolve that conflict
package Role::D;
use Role::Basic;
sub foo { 'Role::D::foo' }
sub bar { 'Role::D::bar' }
package Role::E;
use Role::Basic;
sub foo { 'Role::E::foo' }
sub xxy { 'Role::E::xxy' }
package Role::F;
use Role::Basic;
::is( ::exception {
with qw(Role::D Role::E); # conflict between 'foo's here
}, undef, "define role Role::F" );
sub foo { 'Role::F::foo' }
sub zot { 'Role::F::zot' }
package Class::B;
use Role::Basic 'with';
sub new { bless {} => shift }
# XXX this is different from Moose. Traits are required, amongst other
# things, as being "associative". Moose breaks with that. We keep this
# behavior (for now) as it's easier to be restrictive and let up than the
# other way around. See
# http://blogs.perl.org/users/ovid/2011/01/rolebasic-what-is-a-conflict.html
# for more detail.
::like( ::exception {
with qw(Role::F);
}, qr/\QDue to a method name conflict in roles 'Role::D' and 'Role::E' and 'Role::F', the method 'foo' must be implemented or excluded by 'Class::B'/, "define class Class::B" );
sub zot { 'Class::B::zot' }
}
# XXX lots of Moose tests deleted as they don't apply to Role::Basic
{
# conflict propagation
package Role::H;
use Role::Basic;
sub foo { 'Role::H::foo' }
sub bar { 'Role::H::bar' }
package Role::J;
use Role::Basic;
sub foo { 'Role::J::foo' }
sub xxy { 'Role::J::xxy' }
package Role::I;
use Role::Basic;
# XXX another difference with Moose. Originally we deferred conflicts to
# the consuming class, but their was no syntax to allow the class to
# understand the role's composition and pick it apart (i.e., exclude
# methods from the roles this role consumed). Thus, we throw an exception
# as it's safer.
::isnt( ::exception {
with qw(Role::J Role::H); # conflict between 'foo's here
}, undef, "define role Role::I" );
sub zot { 'Role::I::zot' }
sub zzy { 'Role::I::zzy' }
package Class::C;
use Role::Basic 'with';
::like( ::exception {
with qw(Role::I);
}, qr/Due to a method name conflict in roles 'Role::H' and 'Role::J', the method 'foo' must be implemented or excluded by 'Class::C'/, "defining class Class::C fails" );
sub zot { 'Class::C::zot' }
package Class::E;
use Role::Basic 'with';
sub new { bless {} => shift }
::is( ::exception {
with qw(Role::I);
}, undef, "resolved with method" );
sub foo { 'Class::E::foo' }
sub zot { 'Class::E::zot' }
}
can_ok( Class::E->new, qw(foo bar xxy zot) );
is( Class::E->new->foo, "Class::E::foo", "... got the right &foo method" );
is( Class::E->new->zot, "Class::E::zot", "... got the right &zot method" );
is( Class::E->new->bar, "Role::H::bar", "... got the right &bar method" );
is( Class::E->new->xxy, "Role::J::xxy", "... got the right &xxy method" );
TODO: {
local $TODO = 'We do not convert conflicts to requirements. Should we?';
ok(
Role::Basic->requires_method( 'Role::I', 'foo' ),
'... Role::I still have the &foo requirement'
);
}
{
is( exception {
package Class::D;
use Role::Basic 'with';
sub new { bless {} => shift }
sub foo { "Class::D::foo" }
sub zot { 'Class::D::zot' }
with qw(Role::I);
}, undef, "resolved with attr" );
can_ok( Class::D->new, qw(foo bar xxy zot) );
is( eval { Class::D->new->bar }, "Role::H::bar", "bar" );
is( eval { Class::D->new->zzy }, "Role::I::zzy", "zzy" );
is( eval { Class::D->new->foo }, "Class::D::foo", "foo" );
is( eval { Class::D->new->zot }, "Class::D::zot", "zot" );
}
|