1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237
|
From: Simon McVittie <smcv@debian.org>
Date: Mon, 27 Dec 2021 16:33:33 +0000
Subject: Mark XMLRPC tests as flaky
They seem likely to fail during the PHP 8 transition, and don't seem to
be amazingly reliable in general.
Forwarded: not-needed, Debian-specific
---
tests/xmlrpc-old-test.c | 45 +++++++++++++++++++++++++++++++++++++++++++++
tests/xmlrpc-test.c | 45 +++++++++++++++++++++++++++++++++++++++++++++
2 files changed, 90 insertions(+)
diff --git a/tests/xmlrpc-old-test.c b/tests/xmlrpc-old-test.c
index 28a744d..b4b4baa 100644
--- a/tests/xmlrpc-old-test.c
+++ b/tests/xmlrpc-old-test.c
@@ -112,6 +112,11 @@ test_sum (void)
GValue retval;
gboolean ok;
+ if (g_getenv ("DEB_ALLOW_FLAKY_TESTS") == NULL) {
+ g_test_skip ("Not reliable?");
+ return;
+ }
+
SOUP_TEST_SKIP_IF_NO_XMLRPC_SERVER;
debug_printf (2, "sum (array of double -> double): ");
@@ -148,6 +153,11 @@ test_countBools (void)
gboolean val, ok;
GHashTable *result;
+ if (g_getenv ("DEB_ALLOW_FLAKY_TESTS") == NULL) {
+ g_test_skip ("Not reliable?");
+ return;
+ }
+
SOUP_TEST_SKIP_IF_NO_XMLRPC_SERVER;
debug_printf (2, "countBools (array of boolean -> struct of ints): ");
@@ -193,6 +203,11 @@ test_md5sum (void)
GValue retval;
gboolean ok;
+ if (g_getenv ("DEB_ALLOW_FLAKY_TESTS") == NULL) {
+ g_test_skip ("Not reliable?");
+ return;
+ }
+
SOUP_TEST_SKIP_IF_NO_XMLRPC_SERVER;
debug_printf (2, "md5sum (base64 -> base64)\n");
@@ -229,6 +244,11 @@ test_dateChange (void)
GValue retval;
gboolean ok;
+ if (g_getenv ("DEB_ALLOW_FLAKY_TESTS") == NULL) {
+ g_test_skip ("Not reliable?");
+ return;
+ }
+
SOUP_TEST_SKIP_IF_NO_XMLRPC_SERVER;
debug_printf (2, "dateChange (date, struct of ints -> time)\n");
@@ -331,6 +351,11 @@ test_echo (void)
GValue retval;
int i;
+ if (g_getenv ("DEB_ALLOW_FLAKY_TESTS") == NULL) {
+ g_test_skip ("Not reliable?");
+ return;
+ }
+
SOUP_TEST_SKIP_IF_NO_XMLRPC_SERVER;
debug_printf (2, "echo (array of string -> array of string):\n");
@@ -378,6 +403,11 @@ test_ping (gconstpointer include_params)
g_test_bug ("671661");
+ if (g_getenv ("DEB_ALLOW_FLAKY_TESTS") == NULL) {
+ g_test_skip ("Not reliable?");
+ return;
+ }
+
SOUP_TEST_SKIP_IF_NO_XMLRPC_SERVER;
debug_printf (2, "ping (void (%s) -> string)\n",
@@ -447,6 +477,11 @@ do_bad_xmlrpc (const char *body)
static void
test_fault_malformed (void)
{
+ if (g_getenv ("DEB_ALLOW_FLAKY_TESTS") == NULL) {
+ g_test_skip ("Not reliable?");
+ return;
+ }
+
SOUP_TEST_SKIP_IF_NO_XMLRPC_SERVER;
do_bad_xmlrpc ("<methodCall/>");
@@ -455,6 +490,11 @@ test_fault_malformed (void)
static void
test_fault_method (void)
{
+ if (g_getenv ("DEB_ALLOW_FLAKY_TESTS") == NULL) {
+ g_test_skip ("Not reliable?");
+ return;
+ }
+
SOUP_TEST_SKIP_IF_NO_XMLRPC_SERVER;
do_bad_xmlrpc ("<methodCall><methodName>no_such_method</methodName><params><param><value><int>1</int></value></param></params></methodCall>");
@@ -463,6 +503,11 @@ test_fault_method (void)
static void
test_fault_args (void)
{
+ if (g_getenv ("DEB_ALLOW_FLAKY_TESTS") == NULL) {
+ g_test_skip ("Not reliable?");
+ return;
+ }
+
SOUP_TEST_SKIP_IF_NO_XMLRPC_SERVER;
do_bad_xmlrpc ("<methodCall><methodName>sum</methodName><params><param><value><int>1</int></value></param></params></methodCall>");
diff --git a/tests/xmlrpc-test.c b/tests/xmlrpc-test.c
index 839f54b..01d594a 100644
--- a/tests/xmlrpc-test.c
+++ b/tests/xmlrpc-test.c
@@ -87,6 +87,11 @@ test_sum (void)
GVariant *retval;
gboolean ok;
+ if (g_getenv ("DEB_ALLOW_FLAKY_TESTS") == NULL) {
+ g_test_skip ("Not reliable?");
+ return;
+ }
+
SOUP_TEST_SKIP_IF_NO_XMLRPC_SERVER;
debug_printf (2, "sum (array of double -> double): ");
@@ -123,6 +128,11 @@ test_countBools (void)
int ret_trues, ret_falses;
gboolean val, ok;
+ if (g_getenv ("DEB_ALLOW_FLAKY_TESTS") == NULL) {
+ g_test_skip ("Not reliable?");
+ return;
+ }
+
SOUP_TEST_SKIP_IF_NO_XMLRPC_SERVER;
debug_printf (2, "countBools (array of boolean -> struct of ints): ");
@@ -166,6 +176,11 @@ test_md5sum (void)
GVariant *retval;
gboolean ok;
+ if (g_getenv ("DEB_ALLOW_FLAKY_TESTS") == NULL) {
+ g_test_skip ("Not reliable?");
+ return;
+ }
+
SOUP_TEST_SKIP_IF_NO_XMLRPC_SERVER;
debug_printf (2, "md5sum (base64 -> base64)\n");
@@ -205,6 +220,11 @@ test_dateChange (void)
gboolean ok;
GError *error = NULL;
+ if (g_getenv ("DEB_ALLOW_FLAKY_TESTS") == NULL) {
+ g_test_skip ("Not reliable?");
+ return;
+ }
+
SOUP_TEST_SKIP_IF_NO_XMLRPC_SERVER;
debug_printf (2, "dateChange (date, struct of ints -> time)\n");
@@ -312,6 +332,11 @@ test_echo (void)
GVariant *retval;
char *str;
+ if (g_getenv ("DEB_ALLOW_FLAKY_TESTS") == NULL) {
+ g_test_skip ("Not reliable?");
+ return;
+ }
+
SOUP_TEST_SKIP_IF_NO_XMLRPC_SERVER;
debug_printf (2, "echo (array of string -> array of string):\n");
@@ -349,6 +374,11 @@ test_ping (gconstpointer include_params)
g_test_bug ("671661");
+ if (g_getenv ("DEB_ALLOW_FLAKY_TESTS") == NULL) {
+ g_test_skip ("Not reliable?");
+ return;
+ }
+
SOUP_TEST_SKIP_IF_NO_XMLRPC_SERVER;
debug_printf (2, "ping (void (%s) -> string)\n",
@@ -414,6 +444,11 @@ do_bad_xmlrpc (const char *body)
static void
test_fault_malformed (void)
{
+ if (g_getenv ("DEB_ALLOW_FLAKY_TESTS") == NULL) {
+ g_test_skip ("Not reliable?");
+ return;
+ }
+
SOUP_TEST_SKIP_IF_NO_XMLRPC_SERVER;
do_bad_xmlrpc ("<methodCall/>");
@@ -422,6 +457,11 @@ test_fault_malformed (void)
static void
test_fault_method (void)
{
+ if (g_getenv ("DEB_ALLOW_FLAKY_TESTS") == NULL) {
+ g_test_skip ("Not reliable?");
+ return;
+ }
+
SOUP_TEST_SKIP_IF_NO_XMLRPC_SERVER;
do_bad_xmlrpc ("<methodCall><methodName>no_such_method</methodName><params><param><value><int>1</int></value></param></params></methodCall>");
@@ -430,6 +470,11 @@ test_fault_method (void)
static void
test_fault_args (void)
{
+ if (g_getenv ("DEB_ALLOW_FLAKY_TESTS") == NULL) {
+ g_test_skip ("Not reliable?");
+ return;
+ }
+
SOUP_TEST_SKIP_IF_NO_XMLRPC_SERVER;
do_bad_xmlrpc ("<methodCall><methodName>sum</methodName><params><param><value><int>1</int></value></param></params></methodCall>");
|