File: TCP_client_test.cc

package info (click to toggle)
libtoxcore 0.2.22-1
  • links: PTS, VCS
  • area: main
  • in suites: forky, sid
  • size: 6,992 kB
  • sloc: ansic: 70,235; cpp: 14,770; sh: 1,576; python: 649; makefile: 255; perl: 39
file content (374 lines) | stat: -rw-r--r-- 15,164 bytes parent folder | download
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
// clang-format off
#include "../testing/support/public/simulated_environment.hh"
#include "TCP_client.h"
// clang-format on

#include <gtest/gtest.h>

#include <cstdio>
#include <cstring>
#include <vector>

#include "TCP_common.h"
#include "attributes.h"
#include "crypto_core.h"
#include "logger.h"
#include "mono_time.h"
#include "net_profile.h"
#include "network.h"
#include "test_util.hh"
#include "util.h"

namespace {

using namespace tox::test;

class TCPClientTest : public ::testing::Test {
protected:
    SimulatedEnvironment env;

    Mono_Time *_Nonnull create_mono_time(const Memory *_Nonnull mem)
    {
        Mono_Time *_Nonnull mt = REQUIRE_NOT_NULL(mono_time_new(mem, nullptr, nullptr));
        mono_time_set_current_time_callback(
            mt,
            [](void *_Nullable user_data) -> std::uint64_t {
                auto *clock = static_cast<FakeClock *>(user_data);
                return clock->current_time_ms();
            },
            &env.fake_clock());
        return mt;
    }

    static void log_cb(void *_Nullable context, Logger_Level level, const char *_Nonnull file,
        std::uint32_t line, const char *_Nonnull func, const char *_Nonnull message,
        void *_Nullable userdata)
    {
        if (level > LOGGER_LEVEL_TRACE) {
            fprintf(stderr, "[%d] %s:%u %s: %s\n", level, file, line, func, message);
        }
    }

    static void net_profile_deleter(Net_Profile *_Nullable p, const Memory *_Nonnull mem)
    {
        netprof_kill(mem, p);
    }
};

TEST_F(TCPClientTest, ConnectsToRelay)
{
    auto server_node = env.create_node(33445);
    auto client_node = env.create_node(0);  // Ephemeral port

    Logger *server_log = logger_new(&server_node->c_memory);
    logger_callback_log(server_log, &TCPClientTest::log_cb, nullptr, nullptr);
    Logger *client_log = logger_new(&client_node->c_memory);
    logger_callback_log(client_log, &TCPClientTest::log_cb, nullptr, nullptr);

    Mono_Time *client_time = create_mono_time(&client_node->c_memory);

    // 1. Setup Server Socket
    Socket server_sock
        = net_socket(&server_node->c_network, net_family_ipv4(), TOX_SOCK_STREAM, TOX_PROTO_TCP);
    ASSERT_TRUE(sock_valid(server_sock));
    ASSERT_TRUE(set_socket_nonblock(&server_node->c_network, server_sock));
    ASSERT_TRUE(bind_to_port(&server_node->c_network, server_sock, net_family_ipv4(), 33445));
    ASSERT_EQ(0, net_listen(&server_node->c_network, server_sock, 5));

    // Server Keys
    std::uint8_t server_pk[CRYPTO_PUBLIC_KEY_SIZE];
    std::uint8_t server_sk[CRYPTO_SECRET_KEY_SIZE];
    crypto_new_keypair(&server_node->c_random, server_pk, server_sk);

    // Client Keys
    std::uint8_t client_pk[CRYPTO_PUBLIC_KEY_SIZE];
    std::uint8_t client_sk[CRYPTO_SECRET_KEY_SIZE];
    crypto_new_keypair(&client_node->c_random, client_pk, client_sk);

    Net_Profile *client_profile = netprof_new(client_log, &client_node->c_memory);

    // 2. Client connects to Server
    IP_Port server_ip_port;
    server_ip_port.ip = server_node->node->ip;
    server_ip_port.port = net_htons(33445);

    TCP_Client_Connection *client_conn = new_tcp_connection(client_log, &client_node->c_memory,
        client_time, &client_node->c_random, &client_node->c_network, &server_ip_port, server_pk,
        client_pk, client_sk, nullptr, client_profile);
    ASSERT_NE(client_conn, nullptr);

    // 3. Simulation Loop
    bool connected = false;
    Socket accepted_sock = net_invalid_socket();
    std::uint64_t start_time = env.clock().current_time_ms();

    while (env.clock().current_time_ms() - start_time < 5000) {
        env.advance_time(10);
        do_tcp_connection(client_log, client_time, client_conn, nullptr);

        // Server accepts connection
        if (!sock_valid(accepted_sock)) {
            accepted_sock = net_accept(&server_node->c_network, server_sock);
            if (sock_valid(accepted_sock)) {
                fprintf(stderr, "Server accepted connection! Socket: %d\n", accepted_sock.value);
                set_socket_nonblock(&server_node->c_network, accepted_sock);
            }
        }

        // Server handles handshake
        if (sock_valid(accepted_sock)) {
            std::uint8_t buf[TCP_CLIENT_HANDSHAKE_SIZE];
            IP_Port remote = {{{0}}};
            int len = net_recv(
                &server_node->c_network, server_log, accepted_sock, buf, sizeof(buf), &remote);

            if (len > 0) {
                fprintf(stderr, "Server received %d bytes\n", len);
            }

            if (len == TCP_CLIENT_HANDSHAKE_SIZE) {
                // Verify client PK
                EXPECT_EQ(0, std::memcmp(buf, client_pk, CRYPTO_PUBLIC_KEY_SIZE));

                // Decrypt
                std::uint8_t shared_key[CRYPTO_SHARED_KEY_SIZE];
                encrypt_precompute(client_pk, server_sk, shared_key);

                std::uint8_t plain[TCP_HANDSHAKE_PLAIN_SIZE];
                const std::uint8_t *nonce_ptr = buf + CRYPTO_PUBLIC_KEY_SIZE;
                const std::uint8_t *ciphertext_ptr
                    = buf + CRYPTO_PUBLIC_KEY_SIZE + CRYPTO_NONCE_SIZE;

                int res = decrypt_data_symmetric(&server_node->c_memory, shared_key, nonce_ptr,
                    ciphertext_ptr,
                    TCP_CLIENT_HANDSHAKE_SIZE - (CRYPTO_PUBLIC_KEY_SIZE + CRYPTO_NONCE_SIZE),
                    plain);

                if (res != TCP_HANDSHAKE_PLAIN_SIZE) {
                    fprintf(stderr, "Decryption failed: res=%d\n", res);
                }

                if (res == TCP_HANDSHAKE_PLAIN_SIZE) {
                    // Generate Response
                    // [Nonce (24)] [Encrypted (PK(32)+Nonce(24)+MAC(16))]

                    std::uint8_t resp_nonce[CRYPTO_NONCE_SIZE];
                    random_nonce(&server_node->c_random, resp_nonce);

                    std::uint8_t temp_pk[CRYPTO_PUBLIC_KEY_SIZE];
                    std::uint8_t temp_sk[CRYPTO_SECRET_KEY_SIZE];
                    crypto_new_keypair(&server_node->c_random, temp_pk, temp_sk);

                    std::uint8_t resp_plain[TCP_HANDSHAKE_PLAIN_SIZE];
                    std::memcpy(resp_plain, temp_pk, CRYPTO_PUBLIC_KEY_SIZE);
                    random_nonce(&server_node->c_random, resp_plain + CRYPTO_PUBLIC_KEY_SIZE);

                    std::uint8_t response[TCP_SERVER_HANDSHAKE_SIZE];
                    std::memcpy(response, resp_nonce, CRYPTO_NONCE_SIZE);

                    encrypt_data_symmetric(&server_node->c_memory, shared_key,
                        resp_nonce,  // nonce
                        resp_plain,  // plain
                        TCP_HANDSHAKE_PLAIN_SIZE,  // plain len
                        response + CRYPTO_NONCE_SIZE  // dest
                    );

                    net_send(&server_node->c_network, server_log, accepted_sock, response,
                        sizeof(response), &remote, nullptr);
                }
            }
        }

        if (tcp_con_status(client_conn) == TCP_CLIENT_CONFIRMED) {
            connected = true;
            break;
        }
    }

    EXPECT_TRUE(connected);

    // Cleanup
    kill_tcp_connection(client_conn);
    net_profile_deleter(client_profile, &client_node->c_memory);
    kill_sock(&server_node->c_network, server_sock);
    if (sock_valid(accepted_sock))
        kill_sock(&server_node->c_network, accepted_sock);

    logger_kill(client_log);
    logger_kill(server_log);
    mono_time_free(&client_node->c_memory, client_time);
}

TEST_F(TCPClientTest, SendDataIntegerOverflow)
{
    auto server_node = env.create_node(33446);
    auto client_node = env.create_node(0);

    Logger *server_log = logger_new(&server_node->c_memory);
    logger_callback_log(server_log, &TCPClientTest::log_cb, nullptr, nullptr);
    Logger *client_log = logger_new(&client_node->c_memory);
    logger_callback_log(client_log, &TCPClientTest::log_cb, nullptr, nullptr);

    Mono_Time *client_time = create_mono_time(&client_node->c_memory);

    Socket server_sock
        = net_socket(&server_node->c_network, net_family_ipv4(), TOX_SOCK_STREAM, TOX_PROTO_TCP);
    ASSERT_TRUE(sock_valid(server_sock));
    ASSERT_TRUE(set_socket_nonblock(&server_node->c_network, server_sock));
    ASSERT_TRUE(bind_to_port(&server_node->c_network, server_sock, net_family_ipv4(), 33446));
    ASSERT_EQ(0, net_listen(&server_node->c_network, server_sock, 5));

    std::uint8_t server_pk[CRYPTO_PUBLIC_KEY_SIZE];
    std::uint8_t server_sk[CRYPTO_SECRET_KEY_SIZE];
    crypto_new_keypair(&server_node->c_random, server_pk, server_sk);

    std::uint8_t client_pk[CRYPTO_PUBLIC_KEY_SIZE];
    std::uint8_t client_sk[CRYPTO_SECRET_KEY_SIZE];
    crypto_new_keypair(&client_node->c_random, client_pk, client_sk);

    Net_Profile *client_profile = netprof_new(client_log, &client_node->c_memory);

    IP_Port server_ip_port;
    server_ip_port.ip = server_node->node->ip;
    server_ip_port.port = net_htons(33446);

    TCP_Client_Connection *client_conn = new_tcp_connection(client_log, &client_node->c_memory,
        client_time, &client_node->c_random, &client_node->c_network, &server_ip_port, server_pk,
        client_pk, client_sk, nullptr, client_profile);
    ASSERT_NE(client_conn, nullptr);

    bool connected = false;
    Socket accepted_sock = net_invalid_socket();
    std::uint64_t start_time = env.clock().current_time_ms();
    std::uint8_t shared_key[CRYPTO_SHARED_KEY_SIZE];
    std::uint8_t sent_nonce[CRYPTO_NONCE_SIZE] = {0};
    std::uint8_t recv_nonce[CRYPTO_NONCE_SIZE] = {0};

    // Helper to send encrypted packet from server to client
    auto server_send_packet = [&](const std::uint8_t *data, std::uint16_t length) {
        std::uint16_t packet_size = sizeof(std::uint16_t) + length + CRYPTO_MAC_SIZE;
        std::vector<std::uint8_t> packet(packet_size);
        std::uint16_t c_length = net_htons(length + CRYPTO_MAC_SIZE);
        std::memcpy(packet.data(), &c_length, sizeof(std::uint16_t));

        encrypt_data_symmetric(&server_node->c_memory, shared_key, sent_nonce, data, length,
            packet.data() + sizeof(std::uint16_t));
        increment_nonce(sent_nonce);

        IP_Port remote = {{{0}}};
        net_send(&server_node->c_network, server_log, accepted_sock, packet.data(), packet_size,
            &remote, nullptr);
    };

    while (env.clock().current_time_ms() - start_time < 5000) {
        env.advance_time(10);
        do_tcp_connection(client_log, client_time, client_conn, nullptr);

        if (!sock_valid(accepted_sock)) {
            accepted_sock = net_accept(&server_node->c_network, server_sock);
            if (sock_valid(accepted_sock)) {
                set_socket_nonblock(&server_node->c_network, accepted_sock);
            }
        }

        if (sock_valid(accepted_sock) && !connected) {
            std::uint8_t buf[TCP_CLIENT_HANDSHAKE_SIZE];
            IP_Port remote = {{{0}}};
            int len = net_recv(
                &server_node->c_network, server_log, accepted_sock, buf, sizeof(buf), &remote);

            if (len == TCP_CLIENT_HANDSHAKE_SIZE) {
                encrypt_precompute(client_pk, server_sk, shared_key);
                std::uint8_t plain[TCP_HANDSHAKE_PLAIN_SIZE];
                if (decrypt_data_symmetric(&server_node->c_memory, shared_key,
                        buf + CRYPTO_PUBLIC_KEY_SIZE,
                        buf + CRYPTO_PUBLIC_KEY_SIZE + CRYPTO_NONCE_SIZE,
                        TCP_CLIENT_HANDSHAKE_SIZE - (CRYPTO_PUBLIC_KEY_SIZE + CRYPTO_NONCE_SIZE),
                        plain)
                    == TCP_HANDSHAKE_PLAIN_SIZE) {
                    std::memcpy(recv_nonce, plain + CRYPTO_PUBLIC_KEY_SIZE, CRYPTO_NONCE_SIZE);

                    std::uint8_t resp_nonce[CRYPTO_NONCE_SIZE];
                    random_nonce(&server_node->c_random, resp_nonce);
                    std::memcpy(sent_nonce, resp_nonce, CRYPTO_NONCE_SIZE);

                    std::uint8_t temp_pk[CRYPTO_PUBLIC_KEY_SIZE];
                    std::uint8_t temp_sk[CRYPTO_SECRET_KEY_SIZE];
                    crypto_new_keypair(&server_node->c_random, temp_pk, temp_sk);

                    std::uint8_t resp_plain[TCP_HANDSHAKE_PLAIN_SIZE];
                    std::memcpy(resp_plain, temp_pk, CRYPTO_PUBLIC_KEY_SIZE);
                    random_nonce(&server_node->c_random, resp_plain + CRYPTO_PUBLIC_KEY_SIZE);

                    // FIX: Save the nonce that client will use for receiving
                    std::memcpy(sent_nonce, resp_plain + CRYPTO_PUBLIC_KEY_SIZE, CRYPTO_NONCE_SIZE);

                    std::uint8_t response[TCP_SERVER_HANDSHAKE_SIZE];
                    std::memcpy(response, resp_nonce, CRYPTO_NONCE_SIZE);
                    encrypt_data_symmetric(&server_node->c_memory, shared_key, resp_nonce,
                        resp_plain, TCP_HANDSHAKE_PLAIN_SIZE, response + CRYPTO_NONCE_SIZE);
                    net_send(&server_node->c_network, server_log, accepted_sock, response,
                        sizeof(response), &remote, nullptr);

                    // FIX: Update shared key using Client's Ephemeral PK and Server's Ephemeral SK
                    encrypt_precompute(plain, temp_sk, shared_key);
                }
            }
        }

        if (tcp_con_status(client_conn) == TCP_CLIENT_CONFIRMED) {
            connected = true;
            break;
        }
    }
    ASSERT_TRUE(connected);

    // Establish sub-connection 0
    std::uint8_t con_id = 0;
    std::uint8_t other_pk[CRYPTO_PUBLIC_KEY_SIZE] = {0};  // Dummy PK
    // 1. Send Routing Response to set status=1
    {
        std::uint8_t packet[1 + 1 + CRYPTO_PUBLIC_KEY_SIZE];
        packet[0] = TCP_PACKET_ROUTING_RESPONSE;
        packet[1] = con_id + NUM_RESERVED_PORTS;
        std::memcpy(packet + 2, other_pk, CRYPTO_PUBLIC_KEY_SIZE);
        server_send_packet(packet, sizeof(packet));
    }

    // Pump loop to process packet
    for (int i = 0; i < 10; ++i) {
        env.advance_time(10);
        do_tcp_connection(client_log, client_time, client_conn, nullptr);
    }

    // 2. Send Connection Notification to set status=2
    {
        std::uint8_t packet[1 + 1];
        packet[0] = TCP_PACKET_CONNECTION_NOTIFICATION;
        packet[1] = con_id + NUM_RESERVED_PORTS;
        server_send_packet(packet, sizeof(packet));
    }

    // Pump loop to process packet
    for (int i = 0; i < 10; ++i) {
        env.advance_time(10);
        do_tcp_connection(client_log, client_time, client_conn, nullptr);
    }

    // Now call send_data with 65535 bytes
    std::vector<std::uint8_t> large_data(65535);
    // This should trigger integer overflow: 1 + 65535 = 0. VLA(0). packet[0] write -> Crash/UB
    send_data(client_log, client_conn, con_id, large_data.data(), 65535);

    // Cleanup
    kill_tcp_connection(client_conn);
    net_profile_deleter(client_profile, &client_node->c_memory);
    kill_sock(&server_node->c_network, server_sock);
    if (sock_valid(accepted_sock))
        kill_sock(&server_node->c_network, accepted_sock);
    logger_kill(client_log);
    logger_kill(server_log);
    mono_time_free(&client_node->c_memory, client_time);
}

}  // namespace