1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
|
/*
* Copyright (C) 2019 Red Hat, Inc.
*
* This library is free software; you can redistribute it and/or
* modify it under the terms of the GNU Lesser General Public
* License as published by the Free Software Foundation; either
* version 2.1 of the License, or (at your option) any later version.
*
* This library is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
* Lesser General Public License for more details.
*
* You should have received a copy of the GNU Lesser General Public
* License along with this library. If not, see
* <http://www.gnu.org/licenses/>.
*/
#include <config.h>
#include "testutils.h"
#define LIBVIRT_VIRCOMMANDPRIV_H_ALLOW
#include "vircommandpriv.h"
#include "virnetdevbandwidth.h"
#include "virnetdevopenvswitch.h"
#include "netdev_bandwidth_conf.c"
#define VIR_FROM_THIS VIR_FROM_NONE
typedef struct _InterfaceParseStatsData InterfaceParseStatsData;
struct _InterfaceParseStatsData {
const char *filename;
const virDomainInterfaceStatsStruct stats;
};
struct testSetQosStruct {
const char *band;
const char *exp_cmd;
const char *iface;
};
struct testClearQosStruct {
const char *exp_cmd;
const char *iface;
const unsigned char *vmid;
};
static int
testVirNetDevBandwidthParse(virNetDevBandwidth **var,
const char *xml)
{
g_autoptr(xmlDoc) doc = NULL;
g_autoptr(xmlXPathContext) ctxt = NULL;
if (!xml)
return 0;
if (!(doc = virXMLParseStringCtxt((xml),
"bandwidth definition",
&ctxt)))
return -1;
return virNetDevBandwidthParse(var,
NULL,
ctxt->node,
true);
}
static const unsigned char vm_id[VIR_UUID_BUFLEN] = "fakeuuid";
static int
testInterfaceParseStats(const void *opaque)
{
const InterfaceParseStatsData *data = opaque;
g_autofree char *filename = NULL;
g_autofree char *buf = NULL;
virDomainInterfaceStatsStruct actual;
filename = g_strdup_printf("%s/virnetdevopenvswitchdata/%s", abs_srcdir,
data->filename);
if (virFileReadAll(filename, 1024, &buf) < 0)
return -1;
if (virNetDevOpenvswitchInterfaceParseStats(buf, &actual) < 0)
return -1;
if (memcmp(&actual, &data->stats, sizeof(actual)) != 0) {
fprintf(stderr,
"Expected stats: %lld %lld %lld %lld %lld %lld %lld %lld\n"
"Actual stats: %lld %lld %lld %lld %lld %lld %lld %lld",
data->stats.rx_bytes,
data->stats.rx_packets,
data->stats.rx_errs,
data->stats.rx_drop,
data->stats.tx_bytes,
data->stats.tx_packets,
data->stats.tx_errs,
data->stats.tx_drop,
actual.rx_bytes,
actual.rx_packets,
actual.rx_errs,
actual.rx_drop,
actual.tx_bytes,
actual.tx_packets,
actual.tx_errs,
actual.tx_drop);
return -1;
}
return 0;
}
typedef struct _escapeData escapeData;
struct _escapeData {
const char *input;
const char *expect;
};
static int
testNameEscape(const void *opaque)
{
const escapeData *data = opaque;
g_autofree char *reply = g_strdup(data->input);
int rv;
rv = virNetDevOpenvswitchMaybeUnescapeReply(reply);
if (data->expect) {
if (rv < 0 || STRNEQ(reply, data->expect)) {
fprintf(stderr,
"Unexpected failure, expected: %s for input %s got %s\n",
data->expect, data->input, reply);
return -1;
}
} else {
if (rv >= 0) {
fprintf(stderr,
"Unexpected success, input %s got %s\n",
data->input, reply);
return -1;
}
}
return 0;
}
static int
testVirNetDevOpenvswitchInterfaceSetQos(const void *data)
{
const struct testSetQosStruct *info = data;
const char *iface = info->iface;
g_autoptr(virNetDevBandwidth) band = NULL;
g_auto(virBuffer) buf = VIR_BUFFER_INITIALIZER;
g_autofree char *actual_cmd = NULL;
g_autoptr(virCommandDryRunToken) dryRunToken = virCommandDryRunTokenNew();
if (testVirNetDevBandwidthParse(&band, info->band) < 0)
return -1;
if (!iface)
iface = "tap-fake";
virCommandSetDryRun(dryRunToken, &buf, false, false, NULL, NULL);
if (virNetDevOpenvswitchInterfaceSetQos(iface, band, vm_id, true) < 0)
return -1;
if (!(actual_cmd = virBufferContentAndReset(&buf))) {
/* This is interesting, no command has been executed.
* Maybe that's expected, actually. */
}
if (virTestCompareToString(info->exp_cmd, actual_cmd) < 0) {
return -1;
}
return 0;
}
static int
testVirNetDevOpenvswitchInterfaceClearQos(const void *data)
{
const struct testClearQosStruct *info = data;
g_auto(virBuffer) buf = VIR_BUFFER_INITIALIZER;
g_autofree char *actual_cmd = NULL;
const char *iface = info->iface;
const unsigned char *vmid = info->vmid;
g_autoptr(virCommandDryRunToken) dryRunToken = virCommandDryRunTokenNew();
virCommandSetDryRun(dryRunToken, &buf, false, false, NULL, NULL);
if (virNetDevOpenvswitchInterfaceClearQos(iface, vmid) < 0)
return -1;
if (!(actual_cmd = virBufferContentAndReset(&buf))) {
/* This is interesting, no command has been executed.
* Maybe that's expected, actually. */
}
if (virTestCompareToString(info->exp_cmd, actual_cmd) < 0) {
return -1;
}
return 0;
}
static int
mymain(void)
{
int ret = 0;
#define TEST_INTERFACE_STATS(file, \
rxBytes, rxPackets, rxErrs, rxDrop, \
txBytes, txPackets, txErrs, txDrop) \
do { \
const InterfaceParseStatsData data = {.filename = file, .stats = { \
rxBytes, rxPackets, rxErrs, rxDrop, \
txBytes, txPackets, txErrs, txDrop}}; \
if (virTestRun("Interface stats " file, testInterfaceParseStats, &data) < 0) \
ret = -1; \
} while (0)
TEST_INTERFACE_STATS("stats1.json", 9, 12, 11, 10, 2, 8, 5, 4);
TEST_INTERFACE_STATS("stats2.json", 12406, 173, 0, 0, 0, 0, 0, 0);
#define TEST_NAME_ESCAPE(str, fail) \
do { \
const escapeData data = {str, fail};\
if (virTestRun("Name escape " str, testNameEscape, &data) < 0) \
ret = -1; \
} while (0)
TEST_NAME_ESCAPE("", "");
TEST_NAME_ESCAPE("\"\"", "");
TEST_NAME_ESCAPE("vhost-user1", "vhost-user1");
TEST_NAME_ESCAPE("\"vhost-user1\"", "vhost-user1");
TEST_NAME_ESCAPE("\"vhost_user-name.to.escape1", NULL);
TEST_NAME_ESCAPE("\"vhost_user-name.to\\\"escape1\"", "vhost_user-name.to\"escape1");
TEST_NAME_ESCAPE("\"vhost\"user1\"", NULL);
TEST_NAME_ESCAPE("\"\\\\", NULL);
#define DO_TEST_SET(Band, Exp_cmd, ...) \
do { \
struct testSetQosStruct data = {.band = Band, \
.exp_cmd = Exp_cmd, \
__VA_ARGS__}; \
if (virTestRun("virNetDevOpenvswitchInterfaceSetQos", \
testVirNetDevOpenvswitchInterfaceSetQos, \
&data) < 0) \
ret = -1; \
} while (0)
DO_TEST_SET(("<bandwidth>"
" <inbound average='20000'/>"
"</bandwidth>"),
("ovs-vsctl --timeout=5 --no-heading --columns=_uuid find queue"
" 'external-ids:vm-id=\"66616b65-7575-6964-0000-000000000000\"'"
" 'external-ids:ifname=\"tap-fake\"'\n"
"ovs-vsctl --timeout=5 --no-heading --columns=_uuid find qos"
" 'external-ids:vm-id=\"66616b65-7575-6964-0000-000000000000\"'"
" 'external-ids:ifname=\"tap-fake\"'\n"
"ovs-vsctl --timeout=5 set port tap-fake qos=@qos1"
" 'external-ids:vm-id=\"66616b65-7575-6964-0000-000000000000\"'"
" 'external-ids:ifname=\"tap-fake\"'"
" -- --id=@qos1 create qos type=linux-htb other_config:min-rate=160000000"
" queues:0=@queue0 'external-ids:vm-id=\"66616b65-7575-6964-0000-000000000000\"'"
" 'external-ids:ifname=\"tap-fake\"'"
" -- --id=@queue0 create queue other_config:min-rate=160000000 "
"'external-ids:vm-id=\"66616b65-7575-6964-0000-000000000000\"'"
" 'external-ids:ifname=\"tap-fake\"'\n"
"ovs-vsctl --timeout=5 set Interface tap-fake ingress_policing_rate=0 ingress_policing_burst=0\n"));
DO_TEST_SET(NULL, NULL);
DO_TEST_SET("<bandwidth/>", NULL);
DO_TEST_SET(("<bandwidth>"
" <inbound average='0' />"
"</bandwidth>"),
("ovs-vsctl --timeout=5 --no-heading --columns=_uuid find queue"
" 'external-ids:vm-id=\"66616b65-7575-6964-0000-000000000000\"'"
" 'external-ids:ifname=\"tap-fake\"'\n"
"ovs-vsctl --timeout=5 --no-heading --columns=_uuid find qos"
" 'external-ids:vm-id=\"66616b65-7575-6964-0000-000000000000\"'"
" 'external-ids:ifname=\"tap-fake\"'\n"
"ovs-vsctl --timeout=5 set Interface tap-fake ingress_policing_rate=0 ingress_policing_burst=0\n"));
DO_TEST_SET(("<bandwidth>"
" <inbound average='0' />"
" <outbound average='5000' />"
"</bandwidth>"),
("ovs-vsctl --timeout=5 --no-heading --columns=_uuid find queue"
" 'external-ids:vm-id=\"66616b65-7575-6964-0000-000000000000\"'"
" 'external-ids:ifname=\"tap-fake\"'\n"
"ovs-vsctl --timeout=5 --no-heading --columns=_uuid find qos"
" 'external-ids:vm-id=\"66616b65-7575-6964-0000-000000000000\"'"
" 'external-ids:ifname=\"tap-fake\"'\n"
"ovs-vsctl --timeout=5 set Interface tap-fake ingress_policing_rate=40000\n"));
#define DO_TEST_CLEAR_QOS(Iface, Vmid, Exp_cmd, ...) \
do { \
struct testClearQosStruct data = {.iface = Iface, \
.vmid = Vmid, \
.exp_cmd = Exp_cmd, \
__VA_ARGS__}; \
if (virTestRun("virNetDevOpenvswitchInterfaceClearQos", \
testVirNetDevOpenvswitchInterfaceClearQos, \
&data) < 0) \
ret = -1; \
} while (0)
DO_TEST_CLEAR_QOS(("fake-iface"), vm_id,
("ovs-vsctl --timeout=5 --no-heading --columns=_uuid find queue"
" 'external-ids:vm-id=\"66616b65-7575-6964-0000-000000000000\"'"
" 'external-ids:ifname=\"fake-iface\"'\n"
"ovs-vsctl --timeout=5 --no-heading --columns=_uuid find qos"
" 'external-ids:vm-id=\"66616b65-7575-6964-0000-000000000000\"'"
" 'external-ids:ifname=\"fake-iface\"'\n"
"ovs-vsctl --timeout=5 set Interface fake-iface ingress_policing_rate=0 ingress_policing_burst=0\n"));
return ret == 0 ? EXIT_SUCCESS : EXIT_FAILURE;
}
VIR_TEST_MAIN_PRELOAD(mymain,
VIR_TEST_MOCK("virnetdevbandwidth"))
|
