1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
|
# udev -- lintian check script -*- perl -*-
# Copyright (C) 2016 Petter Reinholdtsen
# Copyright (C) 2018 Chris Lamb <lamby@debian.org>
#
# This program is free software; you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
# the Free Software Foundation; either version 2 of the License, or
# (at your option) any later version.
#
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with this program. If not, you can find it on the World Wide
# Web at https://www.gnu.org/copyleft/gpl.html, or write to the Free
# Software Foundation, Inc., 51 Franklin St, Fifth Floor, Boston,
# MA 02110-1301, USA.
package Lintian::Check::Udev;
use v5.20;
use warnings;
use utf8;
use autodie qw(open);
use Const::Fast;
const my $EMPTY => q{};
use Moo;
use namespace::clean;
with 'Lintian::Check';
# Check /lib/udev/rules.d/, detect use of MODE="0666" and use of
# GROUP="plugdev" without TAG+="uaccess".
sub installable {
my ($self) = @_;
foreach my $lib_dir (qw(usr/lib lib)) {
my $rules_dir
= $self->processable->installed->resolve_path(
"$lib_dir/udev/rules.d/");
next
unless $rules_dir;
for my $item ($rules_dir->children) {
if (!$item->is_open_ok) {
$self->pointed_hint('udev-rule-unreadable', $item->pointer);
next;
}
$self->check_udev_rules($item);
}
}
return;
}
sub check_rule {
my ($self, $item, $position, $in_goto, $rule) = @_;
# for USB, if everyone or the plugdev group members are
# allowed access, the uaccess tag should be used too.
$self->pointed_hint(
'udev-rule-missing-uaccess',
$item->pointer($position),
'user accessible device missing TAG+="uaccess"'
)
if $rule =~ m/SUBSYSTEM=="usb"/
&& ( $rule =~ m/GROUP="plugdev"/
|| $rule =~ m/MODE="0666"/)
&& $rule !~ m/ENV\{COLOR_MEASUREMENT_DEVICE\}/
&& $rule !~ m/ENV\{DDC_DEVICE\}/
&& $rule !~ m/ENV\{ID_CDROM\}/
&& $rule !~ m/ENV\{ID_FFADO\}/
&& $rule !~ m/ENV\{ID_GPHOTO2\}/
&& $rule !~ m/ENV\{ID_HPLIP\}/
&& $rule !~ m/ENV\{ID_INPUT_JOYSTICK\}/
&& $rule !~ m/ENV\{ID_MAKER_TOOL\}/
&& $rule !~ m/ENV\{ID_MEDIA_PLAYER\}/
&& $rule !~ m/ENV\{ID_PDA\}/
&& $rule !~ m/ENV\{ID_REMOTE_CONTROL\}/
&& $rule !~ m/ENV\{ID_SECURITY_TOKEN\}/
&& $rule !~ m/ENV\{ID_SMARTCARD_READER\}/
&& $rule !~ m/ENV\{ID_SOFTWARE_RADIO\}/
&& $rule !~ m/TAG\+="uaccess"/;
# Matching rules mentioning vendor/product should also specify
# subsystem, as vendor/product is subsystem specific.
$self->pointed_hint(
'udev-rule-missing-subsystem',
$item->pointer($position),
'vendor/product matching missing SUBSYSTEM specifier'
)
if $rule =~ m/ATTR\{idVendor\}=="[0-9a-fA-F]+"/
&& $rule =~ m/ATTR\{idProduct\}=="[0-9a-fA-F]*"/
&& !$in_goto
&& $rule !~ m/SUBSYSTEM=="[^"]+"/;
return 0;
}
sub check_udev_rules {
my ($self, $item) = @_;
my $contents = $item->decoded_utf8;
my @lines = split(/\n/, $contents);
my $continued = $EMPTY;
my $in_goto = $EMPTY;
my $result = 0;
my $position = 1;
while (defined(my $line = shift @lines)) {
if (length $continued) {
$line = $continued . $line;
$continued = $EMPTY;
}
if ($line =~ /^(.*)\\$/) {
$continued = $1;
next;
}
# Skip comments
next
if $line =~ /^#.*/;
$in_goto = $EMPTY
if $line =~ /LABEL="[^"]+"/;
$in_goto = $line
if $line =~ /SUBSYSTEM!="[^"]+"/
&& $line =~ /GOTO="[^"]+"/;
$result |= $self->check_rule($item, $position, $in_goto, $line);
} continue {
$position++;
}
return $result;
}
sub visit_installed_files {
my ($self, $item) = @_;
return
unless $item->name =~ m{^etc/udev/};
# /etc/udev/rules.d
$self->pointed_hint('udev-rule-in-etc', $item->pointer)
if $item->name =~ m{^etc/udev/rules\.d/\S};
return;
}
1;
# Local Variables:
# indent-tabs-mode: nil
# cperl-indent-level: 4
# End:
# vim: syntax=perl sw=4 sts=4 sr et
|
