1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
|
import pytest
from _testutils import VirtualSmbus
from liquidctl.driver.ddr4 import *
from liquidctl.error import *
# SPD samples
def patch_spd_dump(spd_dump, slice, new):
spd_dump = bytearray(spd_dump)
spd_dump[slice] = new
return bytes(spd_dump)
_VENGEANCE_RGB_SAMPLE = bytes.fromhex(
'23100c028521000800000003090300000000080cfc0300006c6c6c110874f00a'
'2008000500a81e2b2b0000000000000000000000000000000000000016361636'
'1636163600002b0c2b0c2b0c2b0c000000000000000000000000000000000000'
'000000000000000000000000000000000000000000edb5ce0000000000c24da7'
'1111010100000000000000000000000000000000000000000000000000000000'
'0000000000000000000000000000000000000000000000000000000000000000'
'0000000000000000000000000000000000000000000000000000000000000000'
'000000000000000000000000000000000000000000000000000000000000de27'
'0000000000000000000000000000000000000000000000000000000000000000'
'0000000000000000000000000000000000000000000000000000000000000000'
'029e00000000000000434d5233324758344d32433333333343313620200080ce'
'0000000000000000000000000000000000000000000000000000000000000000'
'0c4a01200000000000a3000005fc3f04004d575710ac03f00a2008000500b022'
'2c00000000000000009cceb5b5b5e7e700000000000000000000000000000000'
'0000000000000000000000000000000000000000000000000000000000000000'
'0000000000000000000000000000000000000000000000000000000000000000'
)
# clear the part number; the Vengeance RGB sample already didn't set the TS bit
_NON_TS_SPD = patch_spd_dump(_VENGEANCE_RGB_SAMPLE, slice(0x149, 0x15d), b' ' * 20)
# set the TS bit
_TS_SPD = patch_spd_dump(_NON_TS_SPD, 0x0e, 0x80)
# DDR4 SPD decoding
@pytest.fixture
def cmr_spd():
return Ddr4Spd(_VENGEANCE_RGB_SAMPLE)
def test_spd_bytes_used(cmr_spd):
assert cmr_spd.spd_bytes_used == 384
def test_spd_bytes_total(cmr_spd):
assert cmr_spd.spd_bytes_total == 512
def test_spd_revision(cmr_spd):
assert cmr_spd.spd_revision == (1, 0)
def test_dram_device_type(cmr_spd):
assert cmr_spd.dram_device_type == Ddr4Spd.DramDeviceType.DDR4_SDRAM
def test_module_type(cmr_spd):
assert cmr_spd.module_type == (Ddr4Spd.BaseModuleType.UDIMM, None)
def test_module_thermal_sensor(cmr_spd):
assert not cmr_spd.module_thermal_sensor
def test_module_manufacturer(cmr_spd):
assert cmr_spd.module_manufacturer == 'Corsair'
def test_module_part_number(cmr_spd):
assert cmr_spd.module_part_number == 'CMR32GX4M2C3333C16'
def test_dram_manufacturer(cmr_spd):
assert cmr_spd.dram_manufacturer == 'Samsung'
@pytest.fixture
def smbus():
smbus = VirtualSmbus(parent_driver='i801_smbus')
# hack: clear all spd addresses
for address in range(0x50, 0x58):
smbus._data[address] = None
return smbus
# DDR4 modules using a TSE2004-compatible SPD EEPROM with temperature sensor
def test_tse2004_ignores_not_allowed_buses(smbus, monkeypatch):
smbus.emulate_eeprom_at(0x51, 'ee1004', _TS_SPD)
checks = [
('parent_driver', 'other'),
]
for attr, val in checks:
with monkeypatch.context() as m:
m.setattr(smbus, attr, val)
assert list(Ddr4Temperature.probe(smbus)) == [], \
f'changing {attr} did not cause a mismatch'
def test_tse2004_does_not_match_non_ee1004_device(smbus):
smbus.emulate_eeprom_at(0x51, 'other', _TS_SPD)
assert list(map(type, Ddr4Temperature.probe(smbus))) == []
def test_tse2004_does_not_match_non_ts_devices(smbus):
smbus.emulate_eeprom_at(0x51, 'ee1004', _NON_TS_SPD)
assert list(map(type, Ddr4Temperature.probe(smbus))) == []
def test_tse2004_finds_ts_devices(smbus):
smbus.emulate_eeprom_at(0x51, 'ee1004', _TS_SPD)
smbus.emulate_eeprom_at(0x53, 'ee1004', _TS_SPD)
smbus.emulate_eeprom_at(0x55, 'ee1004', _TS_SPD)
smbus.emulate_eeprom_at(0x57, 'ee1004', _TS_SPD)
devs = list(Ddr4Temperature.probe(smbus))
assert list(map(type, devs)) == [Ddr4Temperature] * 4
assert devs[1].description.startswith('Corsair DIMM4')
def test_tse2004_get_status_is_unsafe(smbus):
smbus.emulate_eeprom_at(0x51, 'ee1004', _TS_SPD)
dimm = next(Ddr4Temperature.probe(smbus))
assert dimm.get_status() == []
def test_tse2004_get_status_reads_temperature(smbus):
enable = ['smbus', 'ddr4_temperature']
smbus.emulate_eeprom_at(0x51, 'ee1004', _TS_SPD)
dimm = next(Ddr4Temperature.probe(smbus))
with dimm.connect(unsafe=enable):
smbus.write_word_data(0x19, 0x05, 0x9ce1)
status = dimm.get_status(unsafe=enable)
expected = [
('Temperature', 25.75, '°C'),
]
assert status == expected
def test_tse2004_get_status_reads_negative_temperature(smbus):
enable = ['smbus', 'ddr4_temperature']
smbus.emulate_eeprom_at(0x51, 'ee1004', _TS_SPD)
dimm = next(Ddr4Temperature.probe(smbus))
with dimm.connect(unsafe=enable):
smbus.write_word_data(0x19, 0x05, 0x741e)
status = dimm.get_status(unsafe=enable)
expected = [
('Temperature', -24.75, '°C'),
]
assert status == expected
# Corsair Vengeance RGB
@pytest.fixture
def vengeance_rgb(smbus):
smbus.emulate_eeprom_at(0x51, 'ee1004', _VENGEANCE_RGB_SAMPLE)
dimm = next(VengeanceRgb.probe(smbus))
smbus.open()
for reg in range(256):
smbus.write_byte_data(0x59, reg, 0xba)
smbus.close()
return (smbus, dimm)
def test_vengeance_rgb_finds_devices(smbus):
smbus.emulate_eeprom_at(0x51, 'ee1004', _VENGEANCE_RGB_SAMPLE)
smbus.emulate_eeprom_at(0x53, 'ee1004', _VENGEANCE_RGB_SAMPLE)
smbus.emulate_eeprom_at(0x55, 'ee1004', _VENGEANCE_RGB_SAMPLE)
smbus.emulate_eeprom_at(0x57, 'ee1004', _VENGEANCE_RGB_SAMPLE)
devs = list(VengeanceRgb.probe(smbus))
assert list(map(type, devs)) == [VengeanceRgb] * 4
assert devs[1].description.startswith('Corsair Vengeance RGB DIMM4')
def test_vengeance_get_status_reads_temperature(vengeance_rgb):
enable = ['smbus', 'vengeance_rgb']
smbus, dimm = vengeance_rgb
def forbid(*args, **kwargs):
assert False, 'should not reach here'
smbus.read_block_data = forbid
with dimm.connect(unsafe=enable):
smbus.write_word_data(0x19, 0x05, 0x9ce1)
status = dimm.get_status(unsafe=enable)
expected = [
('Temperature', 25.75, '°C'),
]
assert status == expected
def test_vengeance_rgb_set_color_is_unsafe(vengeance_rgb):
_, dimm = vengeance_rgb
with pytest.raises(UnsafeFeaturesNotEnabled):
assert dimm.set_color('led', 'off', [])
with pytest.raises(UnsafeFeaturesNotEnabled):
assert dimm.set_color('led', 'off', [], unsafe='vengeance_rgb')
with pytest.raises(UnsafeFeaturesNotEnabled):
assert dimm.set_color('led', 'off', [], unsafe='smbus')
def test_vengeance_rgb_asserts_rgb_address_validity(vengeance_rgb):
enable = ['smbus', 'vengeance_rgb']
smbus, dimm = vengeance_rgb
with dimm.connect(unsafe=enable):
smbus.write_byte_data(0x59, 0xa6, 0x00)
with pytest.raises(ExpectationNotMet):
dimm.set_color('led', 'off', [], unsafe=enable)
def test_vengeance_rgb_sets_color_to_off(vengeance_rgb):
enable = ['smbus', 'vengeance_rgb']
smbus, dimm = vengeance_rgb
with dimm.connect(unsafe=enable):
dimm.set_color('led', 'off', [], unsafe=enable)
assert smbus.read_byte_data(0x59, 0xa4) == 0x00
assert smbus.read_byte_data(0x59, 0xa6) == 0x00
assert smbus.read_byte_data(0x59, 0xa7) == 0x01
for color_component in range(0xb0, 0xb3):
assert smbus.read_byte_data(0x59, color_component) == 0x00
def test_vengeance_rgb_sets_color_to_fixed(vengeance_rgb):
enable = ['smbus', 'vengeance_rgb']
smbus, dimm = vengeance_rgb
with dimm.connect(unsafe=enable):
radical_red = [0xff, 0x35, 0x5e]
dimm.set_color('led', 'fixed', [radical_red], unsafe=enable)
assert smbus.read_byte_data(0x59, 0xa4) == 0x00
assert smbus.read_byte_data(0x59, 0xa6) == 0x00
assert smbus.read_byte_data(0x59, 0xa7) == 0x01
assert smbus.read_byte_data(0x59, 0xb0) == 0xff
assert smbus.read_byte_data(0x59, 0xb1) == 0x35
assert smbus.read_byte_data(0x59, 0xb2) == 0x5e
def test_vengeance_rgb_sets_color_to_breathing(vengeance_rgb):
enable = ['smbus', 'vengeance_rgb']
smbus, dimm = vengeance_rgb
with dimm.connect(unsafe=enable):
radical_red = [0xff, 0x35, 0x5e]
mountain_meadow = [0x1a, 0xb3, 0x85]
dimm.set_color('led', 'breathing', [radical_red, mountain_meadow],
unsafe=enable)
assert smbus.read_byte_data(0x59, 0xa4) == 0x20
assert smbus.read_byte_data(0x59, 0xa5) == 0x20
assert smbus.read_byte_data(0x59, 0xa6) == 0x02
assert smbus.read_byte_data(0x59, 0xa7) == 0x02
assert smbus.read_byte_data(0x59, 0xb0) == 0xff
assert smbus.read_byte_data(0x59, 0xb1) == 0x35
assert smbus.read_byte_data(0x59, 0xb2) == 0x5e
assert smbus.read_byte_data(0x59, 0xb3) == 0x1a
assert smbus.read_byte_data(0x59, 0xb4) == 0xb3
assert smbus.read_byte_data(0x59, 0xb5) == 0x85
def test_vengeance_rgb_sets_single_color_to_breathing(vengeance_rgb):
enable = ['smbus', 'vengeance_rgb']
smbus, dimm = vengeance_rgb
with dimm.connect(unsafe=enable):
radical_red = [0xff, 0x35, 0x5e]
dimm.set_color('led', 'breathing', [radical_red],
unsafe=enable)
assert smbus.read_byte_data(0x59, 0xa4) == 0x20
assert smbus.read_byte_data(0x59, 0xa5) == 0x20
assert smbus.read_byte_data(0x59, 0xa6) == 0x00 # special case
assert smbus.read_byte_data(0x59, 0xa7) == 0x01
assert smbus.read_byte_data(0x59, 0xb0) == 0xff
assert smbus.read_byte_data(0x59, 0xb1) == 0x35
assert smbus.read_byte_data(0x59, 0xb2) == 0x5e
def test_vengeance_rgb_sets_color_to_fading(vengeance_rgb):
enable = ['smbus', 'vengeance_rgb']
smbus, dimm = vengeance_rgb
with dimm.connect(unsafe=enable):
radical_red = [0xff, 0x35, 0x5e]
mountain_meadow = [0x1a, 0xb3, 0x85]
dimm.set_color('led', 'fading', [radical_red, mountain_meadow],
unsafe=enable)
assert smbus.read_byte_data(0x59, 0xa4) == 0x20
assert smbus.read_byte_data(0x59, 0xa5) == 0x20
assert smbus.read_byte_data(0x59, 0xa6) == 0x01
assert smbus.read_byte_data(0x59, 0xa7) == 0x02
assert smbus.read_byte_data(0x59, 0xb0) == 0xff
assert smbus.read_byte_data(0x59, 0xb1) == 0x35
assert smbus.read_byte_data(0x59, 0xb2) == 0x5e
assert smbus.read_byte_data(0x59, 0xb3) == 0x1a
assert smbus.read_byte_data(0x59, 0xb4) == 0xb3
assert smbus.read_byte_data(0x59, 0xb5) == 0x85
def test_vengeance_rgb_animation_speed_presets_set_correct_timings(vengeance_rgb):
enable = ['smbus', 'vengeance_rgb']
smbus, dimm = vengeance_rgb
with dimm.connect(unsafe=enable):
radical_red = [0xff, 0x35, 0x5e]
mountain_meadow = [0x1a, 0xb3, 0x85]
presets = ['slowest', 'slower', 'normal', 'faster', 'fastest']
timings = [0x3f, 0x30, 0x20, 0x10, 0x01]
for preset, timing in zip(presets, timings):
dimm.set_color('led', 'fading', [radical_red, mountain_meadow],
speed=preset, unsafe=enable)
assert smbus.read_byte_data(0x59, 0xa4) == timing, f'wrong tp1 for {preset!r}'
assert smbus.read_byte_data(0x59, 0xa5) == timing, f'wrong tp2 for {preset!r}'
def test_vengeance_rgb_animation_transition_ticks_overrides_tp1(vengeance_rgb):
enable = ['smbus', 'vengeance_rgb']
smbus, dimm = vengeance_rgb
with dimm.connect(unsafe=enable):
radical_red = [0xff, 0x35, 0x5e]
mountain_meadow = [0x1a, 0xb3, 0x85]
dimm.set_color('led', 'fading', [radical_red, mountain_meadow],
transition_ticks=0x01, unsafe=enable)
assert smbus.read_byte_data(0x59, 0xa4) == 0x01
assert smbus.read_byte_data(0x59, 0xa5) == 0x20
def test_vengeance_rgb_animation_transition_ticks_overrides_tp2(vengeance_rgb):
enable = ['smbus', 'vengeance_rgb']
smbus, dimm = vengeance_rgb
with dimm.connect(unsafe=enable):
radical_red = [0xff, 0x35, 0x5e]
mountain_meadow = [0x1a, 0xb3, 0x85]
dimm.set_color('led', 'fading', [radical_red, mountain_meadow],
stable_ticks=0x01, unsafe=enable)
assert smbus.read_byte_data(0x59, 0xa4) == 0x20
assert smbus.read_byte_data(0x59, 0xa5) == 0x01
|
