1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
|
//===--- DeletedDefaultCheck.cpp - clang-tidy------------------------------===//
//
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//
//===----------------------------------------------------------------------===//
#include "DeletedDefaultCheck.h"
#include "clang/AST/ASTContext.h"
#include "clang/ASTMatchers/ASTMatchFinder.h"
using namespace clang::ast_matchers;
namespace clang {
namespace tidy {
namespace readability {
void DeletedDefaultCheck::registerMatchers(MatchFinder *Finder) {
// We match constructors/assignment operators that are:
// - explicitly marked '= default'
// - actually deleted
// - not in template instantiation.
// We bind the declaration to "method-decl" and also to "constructor" when
// it is a constructor.
Finder->addMatcher(
cxxMethodDecl(anyOf(cxxConstructorDecl().bind("constructor"),
isCopyAssignmentOperator(),
isMoveAssignmentOperator()),
isDefaulted(), unless(isImplicit()), isDeleted(),
unless(isInstantiated()))
.bind("method-decl"),
this);
}
void DeletedDefaultCheck::check(const MatchFinder::MatchResult &Result) {
const StringRef Message = "%0 is explicitly defaulted but implicitly "
"deleted, probably because %1; definition can "
"either be removed or explicitly deleted";
if (const auto *Constructor =
Result.Nodes.getNodeAs<CXXConstructorDecl>("constructor")) {
auto Diag = diag(Constructor->getBeginLoc(), Message);
if (Constructor->isDefaultConstructor()) {
Diag << "default constructor"
<< "a non-static data member or a base class is lacking a default "
"constructor";
} else if (Constructor->isCopyConstructor()) {
Diag << "copy constructor"
<< "a non-static data member or a base class is not copyable";
} else if (Constructor->isMoveConstructor()) {
Diag << "move constructor"
<< "a non-static data member or a base class is neither copyable "
"nor movable";
}
} else if (const auto *Assignment =
Result.Nodes.getNodeAs<CXXMethodDecl>("method-decl")) {
diag(Assignment->getBeginLoc(), Message)
<< (Assignment->isCopyAssignmentOperator() ? "copy assignment operator"
: "move assignment operator")
<< "a base class or a non-static data member is not assignable, e.g. "
"because the latter is marked 'const'";
}
}
} // namespace readability
} // namespace tidy
} // namespace clang
|
