1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
|
// RUN: %check_clang_tidy %s bugprone-misplaced-operator-in-strlen-in-alloc %t
namespace std {
typedef __typeof(sizeof(int)) size_t;
void *malloc(size_t);
size_t strlen(const char *);
} // namespace std
namespace non_std {
typedef __typeof(sizeof(int)) size_t;
void *malloc(size_t);
size_t strlen(const char *);
} // namespace non_std
void bad_std_malloc_std_strlen(char *name) {
char *new_name = (char *)std::malloc(std::strlen(name + 1));
// CHECK-MESSAGES: :[[@LINE-1]]:28: warning: addition operator is applied to the argument of strlen
// CHECK-FIXES: {{^ char \*new_name = \(char \*\)std::malloc\(}}std::strlen(name) + 1{{\);$}}
}
void ignore_non_std_malloc_std_strlen(char *name) {
char *new_name = (char *)non_std::malloc(std::strlen(name + 1));
// CHECK-MESSAGES-NOT: :[[@LINE-1]]:28: warning: addition operator is applied to the argument of strlen
// Ignore functions of the malloc family in custom namespaces
}
void ignore_std_malloc_non_std_strlen(char *name) {
char *new_name = (char *)std::malloc(non_std::strlen(name + 1));
// CHECK-MESSAGES-NOT: :[[@LINE-1]]:28: warning: addition operator is applied to the argument of strlen
// Ignore functions of the strlen family in custom namespaces
}
void bad_new_strlen(char *name) {
char *new_name = new char[std::strlen(name + 1)];
// CHECK-MESSAGES: :[[@LINE-1]]:20: warning: addition operator is applied to the argument of strlen
// CHECK-FIXES: {{^ char \*new_name = new char\[}}std::strlen(name) + 1{{\];$}}
}
void good_new_strlen(char *name) {
char *new_name = new char[std::strlen(name) + 1];
// CHECK-MESSAGES-NOT: :[[@LINE-1]]:20: warning: addition operator is applied to the argument of strlen
}
class C {
char c;
public:
static void *operator new[](std::size_t count) {
return ::operator new(count);
}
};
void bad_custom_new_strlen(char *name) {
C *new_name = new C[std::strlen(name + 1)];
// CHECK-MESSAGES: :[[@LINE-1]]:17: warning: addition operator is applied to the argument of strlen
// CHECK-FIXES: {{^ C \*new_name = new C\[}}std::strlen(name) + 1{{\];$}}
}
|
