1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56
|
// RUN: %check_clang_tidy %s bugprone-misplaced-pointer-arithmetic-in-alloc %t
typedef __typeof(sizeof(int)) size_t;
void *malloc(size_t);
void *alloca(size_t);
void *calloc(size_t, size_t);
void *realloc(void *, size_t);
void bad_malloc(int n) {
char *p = (char *)malloc(n) + 10;
// CHECK-MESSAGES: :[[@LINE-1]]:13: warning: arithmetic operation is applied to the result of malloc() instead of its size-like argument
// CHECK-FIXES: char *p = (char *)malloc(n + 10);
p = (char *)malloc(n) - 10;
// CHECK-MESSAGES: :[[@LINE-1]]:7: warning: arithmetic operation is applied to the result of malloc() instead of its size-like argument
// CHECK-FIXES: p = (char *)malloc(n - 10);
p = (char *)malloc(n) + n;
// CHECK-MESSAGES: :[[@LINE-1]]:7: warning: arithmetic operation is applied to the result of malloc() instead of its size-like argument
// CHECK-FIXES: p = (char *)malloc(n + n);
p = (char *)malloc(n) - (n + 10);
// CHECK-MESSAGES: :[[@LINE-1]]:7: warning: arithmetic operation is applied to the result of malloc() instead of its size-like argument
// CHECK-FIXES: p = (char *)malloc(n - (n + 10));
p = (char *)malloc(n) - n + 10;
// CHECK-MESSAGES: :[[@LINE-1]]:7: warning: arithmetic operation is applied to the result of malloc() instead of its size-like argument
// CHECK-FIXES: p = (char *)malloc(n - n) + 10;
// FIXME: should be p = (char *)malloc(n - n + 10);
}
void bad_alloca(int n) {
char *p = (char *)alloca(n) + 10;
// CHECK-MESSAGES: :[[@LINE-1]]:13: warning: arithmetic operation is applied to the result of alloca() instead of its size-like argument
// CHECK-FIXES: char *p = (char *)alloca(n + 10);
}
void bad_realloc(char *s, int n) {
char *p = (char *)realloc(s, n) + 10;
// CHECK-MESSAGES: :[[@LINE-1]]:13: warning: arithmetic operation is applied to the result of realloc() instead of its size-like argument
// CHECK-FIXES: char *p = (char *)realloc(s, n + 10);
}
void bad_calloc(int n, int m) {
char *p = (char *)calloc(m, n) + 10;
// CHECK-MESSAGES: :[[@LINE-1]]:13: warning: arithmetic operation is applied to the result of calloc() instead of its size-like argument
// CHECK-FIXES: char *p = (char *)calloc(m, n + 10);
}
void (*(*const alloc_ptr)(size_t)) = malloc;
void bad_indirect_alloc(int n) {
char *p = (char *)alloc_ptr(n) + 10;
// CHECK-MESSAGES: :[[@LINE-1]]:13: warning: arithmetic operation is applied to the result of alloc_ptr() instead of its size-like argument
// CHECK-FIXES: char *p = (char *)alloc_ptr(n + 10);
}
|