1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
|
// RUN: %check_clang_tidy %s bugprone-misplaced-widening-cast %t -- -config="{CheckOptions: [{key: bugprone-misplaced-widening-cast.CheckImplicitCasts, value: 1}]}" --
void func(long arg) {}
void assign(int a, int b) {
long l;
l = a * b;
// CHECK-MESSAGES: :[[@LINE-1]]:7: warning: either cast from 'int' to 'long' is ineffective, or there is loss of precision before the conversion [bugprone-misplaced-widening-cast]
l = (long)(a * b);
// CHECK-MESSAGES: :[[@LINE-1]]:7: warning: either cast from 'int' to 'long'
l = (long)a * b;
l = a << 8;
// CHECK-MESSAGES: :[[@LINE-1]]:7: warning: either cast from 'int' to 'long'
l = (long)(a << 8);
// CHECK-MESSAGES: :[[@LINE-1]]:7: warning: either cast from 'int' to 'long'
l = (long)b << 8;
l = static_cast<long>(a * b);
// CHECK-MESSAGES: :[[@LINE-1]]:7: warning: either cast from 'int' to 'long'
}
void compare(int a, int b, long c) {
bool l;
l = a * b == c;
// CHECK-MESSAGES: :[[@LINE-1]]:7: warning: either cast from 'int' to 'long'
l = c == a * b;
// CHECK-MESSAGES: :[[@LINE-1]]:12: warning: either cast from 'int' to 'long'
l = (long)(a * b) == c;
// CHECK-MESSAGES: :[[@LINE-1]]:7: warning: either cast from 'int' to 'long'
l = c == (long)(a * b);
// CHECK-MESSAGES: :[[@LINE-1]]:12: warning: either cast from 'int' to 'long'
l = (long)a * b == c;
l = c == (long)a * b;
}
void init(unsigned int n) {
long l1 = n << 8;
// CHECK-MESSAGES: :[[@LINE-1]]:13: warning: either cast from 'unsigned int' to 'long'
long l2 = (long)(n << 8);
// CHECK-MESSAGES: :[[@LINE-1]]:13: warning: either cast from 'unsigned int' to 'long'
long l3 = (long)n << 8;
}
void call(unsigned int n) {
func(n << 8);
// CHECK-MESSAGES: :[[@LINE-1]]:8: warning: either cast from 'unsigned int' to 'long'
func((long)(n << 8));
// CHECK-MESSAGES: :[[@LINE-1]]:8: warning: either cast from 'unsigned int' to 'long'
func((long)n << 8);
}
long ret(int a) {
if (a < 0) {
return a * 1000;
// CHECK-MESSAGES: :[[@LINE-1]]:12: warning: either cast from 'int' to 'long'
} else if (a > 0) {
return (long)(a * 1000);
// CHECK-MESSAGES: :[[@LINE-1]]:12: warning: either cast from 'int' to 'long'
} else {
return (long)a * 1000;
}
}
void dontwarn1(unsigned char a, int i, unsigned char *p) {
long l;
// The result is a 9 bit value, there is no truncation in the implicit cast.
l = (long)(a + 15);
// The result is a 12 bit value, there is no truncation in the implicit cast.
l = (long)(a << 4);
// The result is a 3 bit value, there is no truncation in the implicit cast.
l = (long)((i % 5) + 1);
// The result is a 16 bit value, there is no truncation in the implicit cast.
l = (long)(((*p) << 8) + *(p + 1));
}
template <class T> struct DontWarn2 {
void assign(T a, T b) {
long l;
l = (long)(a * b);
}
};
DontWarn2<int> DW2;
// Cast is not suspicious when casting macro.
#define A (X<<2)
long macro1(int X) {
return (long)A;
}
// Don't warn about cast in macro.
#define B(X,Y) (long)(X*Y)
long macro2(int x, int y) {
return B(x,y);
}
void floatingpoint(float a, float b) {
double d = (double)(a * b); // Currently we don't warn for this.
}
|
