1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
|
// RUN: %check_clang_tidy %s bugprone-signed-char-misuse %t \
// RUN: -config='{CheckOptions: \
// RUN: [{key: bugprone-signed-char-misuse.CharTypdefsToIgnore, value: "sal_Int8;int8_t"}]}' \
// RUN: --
///////////////////////////////////////////////////////////////////
/// Test cases correctly caught by the check.
// Check that a simple test case is still caught.
int SimpleAssignment() {
signed char CCharacter = -5;
int NCharacter;
NCharacter = CCharacter;
// CHECK-MESSAGES: [[@LINE-1]]:16: warning: 'signed char' to 'int' conversion; consider casting to 'unsigned char' first. [bugprone-signed-char-misuse]
return NCharacter;
}
typedef signed char sal_Char;
int TypedefNotInIgnorableList() {
sal_Char CCharacter = 'a';
int NCharacter = CCharacter;
// CHECK-MESSAGES: [[@LINE-1]]:20: warning: 'signed char' to 'int' conversion; consider casting to 'unsigned char' first. [bugprone-signed-char-misuse]
return NCharacter;
}
///////////////////////////////////////////////////////////////////
/// Test cases correctly ignored by the check.
typedef signed char sal_Int8;
int OneIgnorableTypedef() {
sal_Int8 CCharacter = 'a';
int NCharacter = CCharacter;
return NCharacter;
}
typedef signed char int8_t;
int OtherIgnorableTypedef() {
int8_t CCharacter = 'a';
int NCharacter = CCharacter;
return NCharacter;
}
///////////////////////////////////////////////////////////////////
/// Test cases which should be caught by the check.
namespace boost {
template <class T>
class optional {
T *member;
public:
optional(T value) {
member = new T(value);
}
T operator*() { return *member; }
};
} // namespace boost
int DereferenceWithTypdef(boost::optional<sal_Int8> param) {
int NCharacter = *param;
// CHECK-MESSAGES: [[@LINE-1]]:20: warning: 'signed char' to 'int' conversion; consider casting to 'unsigned char' first. [bugprone-signed-char-misuse]
return NCharacter;
}
|
