File: readability-misplaced-array-index.cpp

package info (click to toggle)
llvm-toolchain-11 1%3A11.0.1-2
  • links: PTS, VCS
  • area: main
  • in suites: bullseye
  • size: 995,808 kB
  • sloc: cpp: 4,767,656; ansic: 760,916; asm: 477,436; python: 170,940; objc: 69,804; lisp: 29,914; sh: 23,855; f90: 18,173; pascal: 7,551; perl: 7,471; ml: 5,603; awk: 3,489; makefile: 2,573; xml: 915; cs: 573; fortran: 503; javascript: 452
file content (34 lines) | stat: -rw-r--r-- 1,009 bytes parent folder | download | duplicates (28) 
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
 
// RUN: %check_clang_tidy %s readability-misplaced-array-index %t

#define ABC  "abc"

struct XY { int *X; int *Y; };

void dostuff(int);

void unusualSyntax(int *P1, struct XY *P2) {
  10[P1] = 0;
  // CHECK-MESSAGES: :[[@LINE-1]]:3: warning: confusing array subscript expression, usually the index is inside the []
  // CHECK-FIXES: P1[10] = 0;

  10[P2->X] = 0;
  // CHECK-MESSAGES: :[[@LINE-1]]:3: warning: confusing array subscript expression
  // CHECK-FIXES: P2->X[10] = 0;

  dostuff(1["abc"]);
  // CHECK-MESSAGES: :[[@LINE-1]]:11: warning: confusing array subscript expression
  // CHECK-FIXES:  dostuff("abc"[1]);

  dostuff(1[ABC]);
  // CHECK-MESSAGES: :[[@LINE-1]]:11: warning: confusing array subscript expression
  // CHECK-FIXES:  dostuff(ABC[1]);

  dostuff(0[0 + ABC]);
  // CHECK-MESSAGES: :[[@LINE-1]]:11: warning: confusing array subscript expression
  // CHECK-FIXES:  dostuff(0[0 + ABC]);
  // No fixit. Probably the code should be ABC[0]
}

void normalSyntax(int *X) {
  X[10] = 0;
}