1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
|
// RUN: %check_clang_tidy -std=c++11,c++14 %s readability-redundant-string-init %t \
// RUN: -config="{CheckOptions: \
// RUN: [{key: readability-redundant-string-init.StringNames, \
// RUN: value: '::std::basic_string;our::TestString'}] \
// RUN: }"
// FIXME: Fix the checker to work in C++17 mode.
namespace std {
template <typename T>
class allocator {};
template <typename T>
class char_traits {};
template <typename C, typename T = std::char_traits<C>, typename A = std::allocator<C>>
struct basic_string {
basic_string();
basic_string(const basic_string&);
basic_string(const C *, const A &a = A());
~basic_string();
};
typedef basic_string<char> string;
typedef basic_string<wchar_t> wstring;
}
void f() {
std::string a = "";
// CHECK-MESSAGES: [[@LINE-1]]:15: warning: redundant string initialization [readability-redundant-string-init]
// CHECK-FIXES: std::string a;
std::string b("");
// CHECK-MESSAGES: [[@LINE-1]]:15: warning: redundant string initialization
// CHECK-FIXES: std::string b;
std::string c = R"()";
// CHECK-MESSAGES: [[@LINE-1]]:15: warning: redundant string initialization
// CHECK-FIXES: std::string c;
std::string d(R"()");
// CHECK-MESSAGES: [[@LINE-1]]:15: warning: redundant string initialization
// CHECK-FIXES: std::string d;
std::string e{""};
// CHECK-MESSAGES: [[@LINE-1]]:15: warning: redundant string initialization
// CHECK-FIXES: std::string e;
std::string f = {""};
// CHECK-MESSAGES: [[@LINE-1]]:15: warning: redundant string initialization
// CHECK-FIXES: std::string f;
std::string u = "u";
std::string w("w");
std::string x = R"(x)";
std::string y(R"(y)");
std::string z;
}
void g() {
std::wstring a = L"";
// CHECK-MESSAGES: [[@LINE-1]]:16: warning: redundant string initialization
// CHECK-FIXES: std::wstring a;
std::wstring b(L"");
// CHECK-MESSAGES: [[@LINE-1]]:16: warning: redundant string initialization
// CHECK-FIXES: std::wstring b;
std::wstring c = LR"()";
// CHECK-MESSAGES: [[@LINE-1]]:16: warning: redundant string initialization
// CHECK-FIXES: std::wstring c;
std::wstring d(LR"()");
// CHECK-MESSAGES: [[@LINE-1]]:16: warning: redundant string initialization
// CHECK-FIXES: std::wstring d;
std::wstring u = L"u";
std::wstring w(L"w");
std::wstring x = LR"(x)";
std::wstring y(LR"(y)");
std::wstring z;
}
template <typename T>
void templ() {
std::string s = "";
// CHECK-MESSAGES: [[@LINE-1]]:15: warning: redundant string initialization
// CHECK-FIXES: std::string s;
}
#define M(x) x
#define N { std::string s = ""; }
// CHECK-FIXES: #define N { std::string s = ""; }
void h() {
templ<int>();
templ<double>();
M({ std::string s = ""; })
// CHECK-MESSAGES: [[@LINE-1]]:19: warning: redundant string initialization
// CHECK-FIXES: M({ std::string s; })
N
// CHECK-MESSAGES: [[@LINE-1]]:3: warning: redundant string initialization
// CHECK-FIXES: N
N
// CHECK-MESSAGES: [[@LINE-1]]:3: warning: redundant string initialization
// CHECK-FIXES: N
}
typedef std::string MyString;
#define STRING MyString
#define DECL_STRING(name, val) STRING name = val
void i() {
MyString a = "";
// CHECK-MESSAGES: [[@LINE-1]]:12: warning: redundant string initialization
// CHECK-FIXES: MyString a;
STRING b = "";
// CHECK-MESSAGES: [[@LINE-1]]:10: warning: redundant string initialization
// CHECK-FIXES: STRING b;
MyString c = "" "" "";
// CHECK-MESSAGES: [[@LINE-1]]:12: warning: redundant string initialization
// CHECK-FIXES: MyString c;
STRING d = "" "" "";
// CHECK-MESSAGES: [[@LINE-1]]:10: warning: redundant string initialization
// CHECK-FIXES: STRING d;
DECL_STRING(e, "");
// CHECK-MESSAGES: [[@LINE-1]]:15: warning: redundant string initialization
MyString f = "u";
STRING g = "u";
DECL_STRING(h, "u");
}
#define EMPTY_STR ""
void j() {
std::string a(EMPTY_STR);
// CHECK-MESSAGES: [[@LINE-1]]:15: warning: redundant string initialization
// CHECK-FIXES: std::string a;
std::string b = (EMPTY_STR);
// CHECK-MESSAGES: [[@LINE-1]]:15: warning: redundant string initialization
// CHECK-FIXES: std::string b;
std::string c(EMPTY_STR "u" EMPTY_STR);
}
void k() {
std::string a = "", b = "", c = "";
// CHECK-MESSAGES: [[@LINE-1]]:15: warning: redundant string initialization
// CHECK-MESSAGES: [[@LINE-2]]:23: warning: redundant string initialization
// CHECK-MESSAGES: [[@LINE-3]]:31: warning: redundant string initialization
// CHECK-FIXES: std::string a, b, c;
std::string d = "u", e = "u", f = "u";
std::string g = "u", h = "", i = "uuu", j = "", k;
// CHECK-MESSAGES: [[@LINE-1]]:24: warning: redundant string initialization
// CHECK-MESSAGES: [[@LINE-2]]:43: warning: redundant string initialization
// CHECK-FIXES: std::string g = "u", h, i = "uuu", j, k;
}
// These cases should not generate warnings.
extern void Param1(std::string param = "");
extern void Param2(const std::string& param = "");
void Param3(std::string param = "") {}
void Param4(STRING param = "") {}
namespace our {
struct TestString {
TestString();
TestString(const TestString &);
TestString(const char *);
~TestString();
};
}
void ourTestStringTests() {
our::TestString a = "";
// CHECK-MESSAGES: [[@LINE-1]]:19: warning: redundant string initialization
// CHECK-FIXES: our::TestString a;
our::TestString b("");
// CHECK-MESSAGES: [[@LINE-1]]:19: warning: redundant string initialization
// CHECK-FIXES: our::TestString b;
our::TestString c = R"()";
// CHECK-MESSAGES: [[@LINE-1]]:19: warning: redundant string initialization
// CHECK-FIXES: our::TestString c;
our::TestString d(R"()");
// CHECK-MESSAGES: [[@LINE-1]]:19: warning: redundant string initialization
// CHECK-FIXES: our::TestString d;
our::TestString u = "u";
our::TestString w("w");
our::TestString x = R"(x)";
our::TestString y(R"(y)");
our::TestString z;
}
namespace their {
using TestString = our::TestString;
}
// their::TestString is the same type so should warn / fix
void theirTestStringTests() {
their::TestString a = "";
// CHECK-MESSAGES: [[@LINE-1]]:21: warning: redundant string initialization
// CHECK-FIXES: their::TestString a;
their::TestString b("");
// CHECK-MESSAGES: [[@LINE-1]]:21: warning: redundant string initialization
// CHECK-FIXES: their::TestString b;
}
namespace other {
// Identical declarations to above but different type
struct TestString {
TestString();
TestString(const TestString &);
TestString(const char *);
~TestString();
};
// Identical declarations to above but different type
template <typename T>
class allocator {};
template <typename T>
class char_traits {};
template <typename C, typename T = std::char_traits<C>, typename A = std::allocator<C>>
struct basic_string {
basic_string();
basic_string(const basic_string &);
basic_string(const C *, const A &a = A());
~basic_string();
};
typedef basic_string<char> string;
typedef basic_string<wchar_t> wstring;
}
// other::TestString, other::string, other::wstring are unrelated to the types
// being checked. No warnings / fixes should be produced for these types.
void otherTestStringTests() {
other::TestString a = "";
other::TestString b("");
other::string c = "";
other::string d("");
other::wstring e = L"";
other::wstring f(L"");
}
class Foo {
std::string A = "";
// CHECK-MESSAGES: [[@LINE-1]]:15: warning: redundant string initialization
// CHECK-FIXES: std::string A;
std::string B;
std::string C;
std::string D;
std::string E = "NotEmpty";
public:
// Check redundant constructor where Field has a redundant initializer.
Foo() : A("") {}
// CHECK-MESSAGES: [[@LINE-1]]:11: warning: redundant string initialization
// CHECK-FIXES: Foo() {}
// Check redundant constructor where Field has no initializer.
Foo(char) : B("") {}
// CHECK-MESSAGES: [[@LINE-1]]:15: warning: redundant string initialization
// CHECK-FIXES: Foo(char) {}
// Check redundant constructor where Field has a valid initializer.
Foo(long) : E("") {}
// CHECK-MESSAGES: [[@LINE-1]]:15: warning: redundant string initialization
// CHECK-FIXES: Foo(long) : E() {}
// Check how it handles removing 1 initializer, and defaulting the other.
Foo(int) : B(""), E("") {}
// CHECK-MESSAGES: [[@LINE-1]]:14: warning: redundant string initialization
// CHECK-MESSAGES: [[@LINE-2]]:21: warning: redundant string initialization
// CHECK-FIXES: Foo(int) : E() {}
Foo(short) : B{""} {}
// CHECK-MESSAGES: [[@LINE-1]]:16: warning: redundant string initialization
// CHECK-FIXES: Foo(short) {}
Foo(float) : A{""}, B{""} {}
// CHECK-MESSAGES: [[@LINE-1]]:16: warning: redundant string initialization
// CHECK-MESSAGES: [[@LINE-2]]:23: warning: redundant string initialization
// CHECK-FIXES: Foo(float) {}
// Check how it handles removing some redundant initializers while leaving
// valid initializers intact.
Foo(std::string Arg) : A(Arg), B(""), C("NonEmpty"), D(R"()"), E("") {}
// CHECK-MESSAGES: [[@LINE-1]]:34: warning: redundant string initialization
// CHECK-MESSAGES: [[@LINE-2]]:56: warning: redundant string initialization
// CHECK-MESSAGES: [[@LINE-3]]:66: warning: redundant string initialization
// CHECK-FIXES: Foo(std::string Arg) : A(Arg), C("NonEmpty"), E() {}
};
|
