1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
|
// RUN: %check_clang_tidy %s llvmlibc-callee-namespace %t
namespace __llvm_libc {
namespace nested {
void nested_func() {}
} // namespace nested
void libc_api_func() {}
} // namespace __llvm_libc
// Emulate a function from the public headers like string.h
void libc_api_func() {}
namespace __llvm_libc {
void Test() {
// Allow calls with the fully qualified name.
__llvm_libc::libc_api_func();
__llvm_libc::nested::nested_func();
void (*qualifiedPtr)(void) = __llvm_libc::libc_api_func;
qualifiedPtr();
// Should not trigger on compiler provided function calls.
(void)__builtin_abs(-1);
// Bare calls are allowed as long as they resolve to the correct namespace.
libc_api_func();
nested::nested_func();
void (*barePtr)(void) = __llvm_libc::libc_api_func;
barePtr();
// Disallow calling into global namespace for implemented entrypoints.
::libc_api_func();
// CHECK-MESSAGES: :[[@LINE-1]]:3: warning: 'libc_api_func' must resolve to a function declared within the '__llvm_libc' namespace
// CHECK-MESSAGES: :11:6: note: resolves to this declaration
// Disallow indirect references to functions in global namespace.
void (*badPtr)(void) = ::libc_api_func;
badPtr();
// CHECK-MESSAGES: :[[@LINE-2]]:26: warning: 'libc_api_func' must resolve to a function declared within the '__llvm_libc' namespace
// CHECK-MESSAGES: :11:6: note: resolves to this declaration
}
} // namespace __llvm_libc
|
