1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
|
// RUN: %clang_analyze_cc1 -analyzer-checker=core,alpha.core\
// RUN: -analyzer-checker=debug.ExprInspection -verify\
// RUN: -Wno-tautological-compare\
// RUN: -x c %s
// RUN: %clang_analyze_cc1 -analyzer-checker=core,alpha.core\
// RUN: -analyzer-checker=debug.ExprInspection -verify\
// RUN: -Wno-tautological-compare\
// RUN: -x c++ -std=c++14 %s
// RUN: %clang_analyze_cc1 -analyzer-checker=core,alpha.core\
// RUN: -analyzer-checker=debug.ExprInspection -verify\
// RUN: -Wno-tautological-compare\
// RUN: -x c++ -std=c++17 %s
// RUN: %clang_analyze_cc1 -analyzer-checker=core,alpha.core\
// RUN: -analyzer-checker=debug.ExprInspection -verify\
// RUN: -Wno-tautological-compare\
// RUN: -DINLINE -x c %s
// RUN: %clang_analyze_cc1 -analyzer-checker=core,alpha.core\
// RUN: -analyzer-checker=debug.ExprInspection -verify\
// RUN: -Wno-tautological-compare\
// RUN: -DINLINE -x c++ -std=c++14 %s
// RUN: %clang_analyze_cc1 -analyzer-checker=core,alpha.core\
// RUN: -analyzer-checker=debug.ExprInspection -verify\
// RUN: -Wno-tautological-compare\
// RUN: -DINLINE -x c++ -std=c++17 %s
void clang_analyzer_eval(int);
struct S {
int field;
#if __cplusplus
const struct S *getThis() const { return this; }
const struct S *operator +() const { return this; }
bool check() const { return this == this; }
bool operator !() const { return this != this; }
int operator *() const { return field; }
#endif
};
#if __cplusplus
const struct S *operator -(const struct S &s) { return &s; }
bool operator ~(const struct S &s) { return (&s) != &s; }
#endif
#ifdef INLINE
struct S getS() {
struct S s = { 42 };
return s;
}
#else
struct S getS();
#endif
void testAssignment() {
struct S s = getS();
if (s.field != 42) return;
clang_analyzer_eval(s.field == 42); // expected-warning{{TRUE}}
s.field = 0;
clang_analyzer_eval(s.field == 0); // expected-warning{{TRUE}}
#if __cplusplus
clang_analyzer_eval(s.getThis() == &s); // expected-warning{{TRUE}}
clang_analyzer_eval(+s == &s); // expected-warning{{TRUE}}
clang_analyzer_eval(-s == &s); // expected-warning{{TRUE}}
clang_analyzer_eval(s.check()); // expected-warning{{TRUE}}
clang_analyzer_eval(!s); // expected-warning{{FALSE}}
clang_analyzer_eval(~s); // expected-warning{{FALSE}}
clang_analyzer_eval(*s == 0); // expected-warning{{TRUE}}
#endif
}
void testImmediateUse() {
int x = getS().field;
if (x != 42) return;
clang_analyzer_eval(x == 42); // expected-warning{{TRUE}}
#if __cplusplus
clang_analyzer_eval((void *)getS().getThis() == (void *)&x); // expected-warning{{FALSE}}
clang_analyzer_eval((void *)+getS() == (void *)&x); // expected-warning{{FALSE}}
clang_analyzer_eval((void *)-getS() == (void *)&x); // expected-warning{{FALSE}}
clang_analyzer_eval(getS().check()); // expected-warning{{TRUE}}
clang_analyzer_eval(!getS()); // expected-warning{{FALSE}}
clang_analyzer_eval(~getS()); // expected-warning{{FALSE}}
#endif
}
int getConstrainedField(struct S s) {
if (s.field != 42) return 42;
return s.field;
}
int getAssignedField(struct S s) {
s.field = 42;
return s.field;
}
void testArgument() {
clang_analyzer_eval(getConstrainedField(getS()) == 42); // expected-warning{{TRUE}}
clang_analyzer_eval(getAssignedField(getS()) == 42); // expected-warning{{TRUE}}
}
void testImmediateUseParens() {
int x = ((getS())).field;
if (x != 42) return;
clang_analyzer_eval(x == 42); // expected-warning{{TRUE}}
clang_analyzer_eval(getConstrainedField(((getS()))) == 42); // expected-warning{{TRUE}}
clang_analyzer_eval(getAssignedField(((getS()))) == 42); // expected-warning{{TRUE}}
#if __cplusplus
clang_analyzer_eval(((getS())).check()); // expected-warning{{TRUE}}
clang_analyzer_eval(!((getS()))); // expected-warning{{FALSE}}
clang_analyzer_eval(~((getS()))); // expected-warning{{FALSE}}
#endif
}
//--------------------
// C++-only tests
//--------------------
#if __cplusplus
void testReferenceAssignment() {
const S &s = getS();
if (s.field != 42) return;
clang_analyzer_eval(s.field == 42); // expected-warning{{TRUE}}
clang_analyzer_eval(s.getThis() == &s); // expected-warning{{TRUE}}
clang_analyzer_eval(+s == &s); // expected-warning{{TRUE}}
clang_analyzer_eval(s.check()); // expected-warning{{TRUE}}
clang_analyzer_eval(!s); // expected-warning{{FALSE}}
clang_analyzer_eval(~s); // expected-warning{{FALSE}}
clang_analyzer_eval(*s == 42); // expected-warning{{TRUE}}
}
int getConstrainedFieldRef(const S &s) {
if (s.field != 42) return 42;
return s.field;
}
bool checkThis(const S &s) {
return s.getThis() == &s;
}
bool checkThisOp(const S &s) {
return +s == &s;
}
bool checkThisStaticOp(const S &s) {
return -s == &s;
}
void testReferenceArgument() {
clang_analyzer_eval(getConstrainedFieldRef(getS()) == 42); // expected-warning{{TRUE}}
clang_analyzer_eval(checkThis(getS())); // expected-warning{{TRUE}}
clang_analyzer_eval(checkThisOp(getS())); // expected-warning{{TRUE}}
clang_analyzer_eval(checkThisStaticOp(getS())); // expected-warning{{TRUE}}
}
int getConstrainedFieldOp(S s) {
if (*s != 42) return 42;
return *s;
}
int getConstrainedFieldRefOp(const S &s) {
if (*s != 42) return 42;
return *s;
}
void testImmediateUseOp() {
int x = *getS();
if (x != 42) return;
clang_analyzer_eval(x == 42); // expected-warning{{TRUE}}
clang_analyzer_eval(getConstrainedFieldOp(getS()) == 42); // expected-warning{{TRUE}}
clang_analyzer_eval(getConstrainedFieldRefOp(getS()) == 42); // expected-warning{{TRUE}}
}
namespace EmptyClass {
struct Base {
int& x;
Base(int& x) : x(x) {}
};
struct Derived : public Base {
Derived(int& x) : Base(x) {}
void operator=(int a) { x = a; }
};
Derived ref(int& a) { return Derived(a); }
// There used to be a warning here, because analyzer treated Derived as empty.
int test() {
int a;
ref(a) = 42;
return a; // no warning
}
}
#if __cplusplus >= 201703L
namespace aggregate_inheritance_cxx17 {
struct A {
int x;
};
struct B {
int y;
};
struct C: B {
int z;
};
struct D: A, C {
int w;
};
void foo() {
D d{1, 2, 3, 4};
clang_analyzer_eval(d.x == 1); // expected-warning{{TRUE}}
clang_analyzer_eval(d.y == 2); // expected-warning{{TRUE}}
clang_analyzer_eval(d.z == 3); // expected-warning{{TRUE}}
clang_analyzer_eval(d.w == 4); // expected-warning{{TRUE}}
}
} // namespace aggregate_inheritance_cxx17
#endif
namespace flex_array_inheritance_cxx17 {
struct A {
int flexible_array[];
};
struct B {
long cookie;
};
struct C : B {
A a;
};
void foo() {
C c{}; // no-crash
}
} // namespace flex_array_inheritance_cxx17
#endif
|
