File: readability-else-after-return-no-cond-var-refactor.cpp

package info (click to toggle)
llvm-toolchain-13 1%3A13.0.1-6~deb10u4
  • links: PTS, VCS
  • area: main
  • in suites: buster
  • size: 1,418,792 kB
  • sloc: cpp: 5,290,827; ansic: 996,570; asm: 544,593; python: 188,212; objc: 72,027; lisp: 30,291; f90: 25,395; sh: 24,900; javascript: 9,780; pascal: 9,398; perl: 7,484; ml: 5,432; awk: 3,523; makefile: 2,892; xml: 953; cs: 573; fortran: 539
file content (42 lines) | stat: -rw-r--r-- 1,135 bytes parent folder | download | duplicates (13) 
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
 
// RUN: %check_clang_tidy %s readability-else-after-return %t -- \
// RUN:     -config='{CheckOptions: [ \
// RUN:         {key: readability-else-after-return.WarnOnConditionVariables, value: false}, \
// RUN:     ]}'

bool foo(int Y) {
  // Excess scopes are here so that the check would have to opportunity to
  // refactor the variable out of the condition.

  // Expect warnings here as we don't need to move declaration of 'X' out of the
  // if condition as its not used in the else.
  {
    if (int X = Y)
      return X < 0;
    else
      // CHECK-MESSAGES: :[[@LINE-1]]:5: warning: do not use 'else' after 'return'
      return false;
  }
  {
    if (int X = Y; X)
      return X < 0;
    else
      // CHECK-MESSAGES: :[[@LINE-1]]:5: warning: do not use 'else' after 'return'
      return false;
  }

  // Expect no warnings for these cases, as even though its safe to move
  // declaration of 'X' out of the if condition, that has been disabled
  // by the options.
  {
    if (int X = Y)
      return false;
    else
      return X < 0;
  }
  {
    if (int X = Y; X)
      return false;
    else
      return X < 0;
  }
}