1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
|
<!DOCTYPE html>
<html>
<head>
<meta charset="utf-8" />
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<title>Code Reviews with Phabricator — LLVM 13 documentation</title>
<link rel="stylesheet" href="_static/pygments.css" type="text/css" />
<link rel="stylesheet" href="_static/llvm-theme.css" type="text/css" />
<script id="documentation_options" data-url_root="./" src="_static/documentation_options.js"></script>
<script src="_static/jquery.js"></script>
<script src="_static/underscore.js"></script>
<script src="_static/doctools.js"></script>
<link rel="index" title="Index" href="genindex.html" />
<link rel="search" title="Search" href="search.html" />
<link rel="next" title="LLVM’s Analysis and Transform Passes" href="Passes.html" />
<link rel="prev" title="User Guide for NVPTX Back-end" href="NVPTXUsage.html" />
<style type="text/css">
table.right { float: right; margin-left: 20px; }
table.right td { border: 1px solid #ccc; }
</style>
</head><body>
<div class="logo">
<a href="index.html">
<img src="_static/logo.png"
alt="LLVM Logo" width="250" height="88"/></a>
</div>
<div class="related" role="navigation" aria-label="related navigation">
<h3>Navigation</h3>
<ul>
<li class="right" style="margin-right: 10px">
<a href="genindex.html" title="General Index"
accesskey="I">index</a></li>
<li class="right" >
<a href="Passes.html" title="LLVM’s Analysis and Transform Passes"
accesskey="N">next</a> |</li>
<li class="right" >
<a href="NVPTXUsage.html" title="User Guide for NVPTX Back-end"
accesskey="P">previous</a> |</li>
<li><a href="https://llvm.org/">LLVM Home</a> | </li>
<li><a href="index.html">Documentation</a>»</li>
<li class="nav-item nav-item-1"><a href="UserGuides.html" accesskey="U">User Guides</a> »</li>
<li class="nav-item nav-item-this"><a href="">Code Reviews with Phabricator</a></li>
</ul>
</div>
<div class="sphinxsidebar" role="navigation" aria-label="main navigation">
<div class="sphinxsidebarwrapper">
<h3>Documentation</h3>
<ul class="want-points">
<li><a href="https://llvm.org/docs/GettingStartedTutorials.html">Getting Started/Tutorials</a></li>
<li><a href="https://llvm.org/docs/UserGuides.html">User Guides</a></li>
<li><a href="https://llvm.org/docs/Reference.html">Reference</a></li>
</ul>
<h3>Getting Involved</h3>
<ul class="want-points">
<li><a href="https://llvm.org/docs/Contributing.html">Contributing to LLVM</a></li>
<li><a href="https://llvm.org/docs/HowToSubmitABug.html">Submitting Bug Reports</a></li>
<li><a href="https://llvm.org/docs/GettingInvolved.html#mailing-lists">Mailing Lists</a></li>
<li><a href="https://llvm.org/docs/GettingInvolved.html#irc">IRC</a></li>
<li><a href="https://llvm.org/docs/GettingInvolved.html#meetups-and-social-events">Meetups and Social Events</a></li>
</ul>
<h3>Additional Links</h3>
<ul class="want-points">
<li><a href="https://llvm.org/docs/FAQ.html">FAQ</a></li>
<li><a href="https://llvm.org/docs/Lexicon.html">Glossary</a></li>
<li><a href="https://llvm.org/pubs">Publications</a></li>
<li><a href="https://github.com/llvm/llvm-project//">Github Repository</a></li>
</ul>
<div role="note" aria-label="source link">
<h3>This Page</h3>
<ul class="this-page-menu">
<li><a href="_sources/Phabricator.rst.txt"
rel="nofollow">Show Source</a></li>
</ul>
</div>
<div id="searchbox" style="display: none" role="search">
<h3 id="searchlabel">Quick search</h3>
<div class="searchformwrapper">
<form class="search" action="search.html" method="get">
<input type="text" name="q" aria-labelledby="searchlabel" />
<input type="submit" value="Go" />
</form>
</div>
</div>
<script>$('#searchbox').show(0);</script>
</div>
</div>
<div class="document">
<div class="documentwrapper">
<div class="bodywrapper">
<div class="body" role="main">
<div class="section" id="code-reviews-with-phabricator">
<span id="phabricator-reviews"></span><h1>Code Reviews with Phabricator<a class="headerlink" href="#code-reviews-with-phabricator" title="Permalink to this headline">¶</a></h1>
<div class="contents local topic" id="contents">
<ul class="simple">
<li><p><a class="reference internal" href="#sign-up" id="id3">Sign up</a></p></li>
<li><p><a class="reference internal" href="#requesting-a-review-via-the-command-line" id="id4">Requesting a review via the command line</a></p></li>
<li><p><a class="reference internal" href="#requesting-a-review-via-the-web-interface" id="id5">Requesting a review via the web interface</a></p></li>
<li><p><a class="reference internal" href="#finding-potential-reviewers" id="id6">Finding potential reviewers</a></p></li>
<li><p><a class="reference internal" href="#reviewing-code-with-phabricator" id="id7">Reviewing code with Phabricator</a></p></li>
<li><p><a class="reference internal" href="#pre-merge-testing" id="id8">Pre-merge testing</a></p>
<ul>
<li><p><a class="reference internal" href="#requirements" id="id9">Requirements</a></p></li>
<li><p><a class="reference internal" href="#accessing-build-results" id="id10">Accessing build results</a></p></li>
</ul>
</li>
<li><p><a class="reference internal" href="#committing-a-change" id="id11">Committing a change</a></p>
<ul>
<li><p><a class="reference internal" href="#committing-someone-s-change-from-phabricator" id="id12">Committing someone’s change from Phabricator</a></p></li>
</ul>
</li>
<li><p><a class="reference internal" href="#abandoning-a-change" id="id13">Abandoning a change</a></p></li>
<li><p><a class="reference internal" href="#status" id="id14">Status</a></p></li>
</ul>
</div>
<p>If you prefer to use a web user interface for code reviews, you can now submit
your patches for Clang and LLVM at <a class="reference external" href="https://reviews.llvm.org">LLVM’s Phabricator</a> instance.</p>
<p>While Phabricator is a useful tool for some, the relevant -commits mailing list
is the system of record for all LLVM code review. The mailing list should be
added as a subscriber on all reviews, and Phabricator users should be prepared
to respond to free-form comments in mail sent to the commits list.</p>
<div class="section" id="sign-up">
<h2><a class="toc-backref" href="#id3">Sign up</a><a class="headerlink" href="#sign-up" title="Permalink to this headline">¶</a></h2>
<p>To get started with Phabricator, navigate to <a class="reference external" href="https://reviews.llvm.org">https://reviews.llvm.org</a> and
click the power icon in the top right. You can register with a GitHub account,
a Google account, or you can create your own profile.</p>
<p>Make <em>sure</em> that the email address registered with Phabricator is subscribed
to the relevant -commits mailing list. If you are not subscribed to the commit
list, all mail sent by Phabricator on your behalf will be held for moderation.</p>
<p>Note that if you use your git user name as Phabricator user name,
Phabricator will automatically connect your submits to your Phabricator user in
the <a class="reference external" href="https://reviews.llvm.org/diffusion/">Code Repository Browser</a>.</p>
</div>
<div class="section" id="requesting-a-review-via-the-command-line">
<h2><a class="toc-backref" href="#id4">Requesting a review via the command line</a><a class="headerlink" href="#requesting-a-review-via-the-command-line" title="Permalink to this headline">¶</a></h2>
<p>Phabricator has a tool called <em>Arcanist</em> to upload patches from
the command line. To get you set up, follow the
<a class="reference external" href="https://secure.phabricator.com/book/phabricator/article/arcanist_quick_start/">Arcanist Quick Start</a> instructions.</p>
<p>You can learn more about how to use arc to interact with
Phabricator in the <a class="reference external" href="https://secure.phabricator.com/book/phabricator/article/arcanist/">Arcanist User Guide</a>.
The basic way of creating a revision for the current commit in your local
repository is to run:</p>
<div class="highlight-default notranslate"><div class="highlight"><pre><span></span><span class="n">arc</span> <span class="n">diff</span> <span class="n">HEAD</span><span class="o">~</span>
</pre></div>
</div>
<p>Sometime you may want to create a draft revision to show the proof of concept
or for experimental purposes, In that case you can use the <cite>–draft</cite> option. It
will either create a new draft revisoin or convert the original revision to a
draft revision depending on your local branch status. The good part is: it will not
send mail to llvm-commit mailing list, patch reviewers, and all other subscribers,
buildbot will also run on every patch update:</p>
<div class="highlight-default notranslate"><div class="highlight"><pre><span></span><span class="n">arc</span> <span class="n">diff</span> <span class="o">--</span><span class="n">draft</span> <span class="n">HEAD</span><span class="o">~</span>
</pre></div>
</div>
<p>If you later update your commit message, you need to add the <cite>–verbatim</cite>
option to have <cite>arc</cite> update the description on Phabricator:</p>
<div class="highlight-default notranslate"><div class="highlight"><pre><span></span><span class="n">arc</span> <span class="n">diff</span> <span class="o">--</span><span class="n">edit</span> <span class="o">--</span><span class="n">verbatim</span>
</pre></div>
</div>
</div>
<div class="section" id="requesting-a-review-via-the-web-interface">
<span id="phabricator-request-review-web"></span><h2><a class="toc-backref" href="#id5">Requesting a review via the web interface</a><a class="headerlink" href="#requesting-a-review-via-the-web-interface" title="Permalink to this headline">¶</a></h2>
<p>The tool to create and review patches in Phabricator is called
<em>Differential</em>.</p>
<p>Note that you can upload patches created through git, but using <cite>arc</cite> on the
command line (see previous section) is preferred: it adds more metadata to
Phabricator which are useful for the pre-merge testing system and for
propagating attribution on commits when someone else has to push it for you.</p>
<p>To make reviews easier, please always include <strong>as much context as
possible</strong> with your diff! Don’t worry, Phabricator
will automatically send a diff with a smaller context in the review
email, but having the full file in the web interface will help the
reviewer understand your code.</p>
<p>To get a full diff, use one of the following commands (or just use Arcanist
to upload your patch):</p>
<ul class="simple">
<li><p><code class="docutils literal notranslate"><span class="pre">git</span> <span class="pre">show</span> <span class="pre">HEAD</span> <span class="pre">-U999999</span> <span class="pre">></span> <span class="pre">mypatch.patch</span></code></p></li>
<li><p><code class="docutils literal notranslate"><span class="pre">git</span> <span class="pre">diff</span> <span class="pre">-U999999</span> <span class="pre">@{u}</span> <span class="pre">></span> <span class="pre">mypatch.patch</span></code></p></li>
<li><p><code class="docutils literal notranslate"><span class="pre">git</span> <span class="pre">diff</span> <span class="pre">HEAD~1</span> <span class="pre">-U999999</span> <span class="pre">></span> <span class="pre">mypatch.patch</span></code></p></li>
</ul>
<p>Before uploading your patch, please make sure it is formatted properly, as
described in <a class="reference internal" href="Contributing.html#format-patches"><span class="std std-ref">How to Submit a Patch</span></a>.</p>
<p>To upload a new patch:</p>
<ul class="simple">
<li><p>Click <em>Differential</em>.</p></li>
<li><p>Click <em>+ Create Diff</em>.</p></li>
<li><p>Paste the text diff or browse to the patch file. Click <em>Create Diff</em>.</p></li>
<li><p>Leave this first Repository field blank. (We’ll fill in the Repository
later, when sending the review.)</p></li>
<li><p>Leave the drop down on <em>Create a new Revision…</em> and click <em>Continue</em>.</p></li>
<li><p>Enter a descriptive title and summary. The title and summary are usually
in the form of a <a class="reference internal" href="DeveloperPolicy.html#commit-messages"><span class="std std-ref">commit message</span></a>.</p></li>
<li><p>Add reviewers (see below for advice). (If you set the Repository field
correctly, llvm-commits or cfe-commits will be subscribed automatically;
otherwise, you will have to manually subscribe them.)</p></li>
<li><p>In the Repository field, enter “rG LLVM Github Monorepo”.</p></li>
<li><p>Click <em>Save</em>.</p></li>
</ul>
<p>To submit an updated patch:</p>
<ul class="simple">
<li><p>Click <em>Differential</em>.</p></li>
<li><p>Click <em>+ Create Diff</em>.</p></li>
<li><p>Paste the updated diff or browse to the updated patch file. Click <em>Create Diff</em>.</p></li>
<li><p>Select the review you want to from the <em>Attach To</em> dropdown and click
<em>Continue</em>.</p></li>
<li><p>Leave the Repository field blank. (We previously filled out the Repository
for the review request.)</p></li>
<li><p>Add comments about the changes in the new diff. Click <em>Save</em>.</p></li>
</ul>
<p>Choosing reviewers: You typically pick one or two people as initial reviewers.
This choice is not crucial, because you are merely suggesting and not requiring
them to participate. Many people will see the email notification on cfe-commits
or llvm-commits, and if the subject line suggests the patch is something they
should look at, they will.</p>
</div>
<div class="section" id="finding-potential-reviewers">
<span id="id1"></span><h2><a class="toc-backref" href="#id6">Finding potential reviewers</a><a class="headerlink" href="#finding-potential-reviewers" title="Permalink to this headline">¶</a></h2>
<p>Here are a couple of ways to pick the initial reviewer(s):</p>
<ul class="simple">
<li><p>Use <code class="docutils literal notranslate"><span class="pre">git</span> <span class="pre">blame</span></code> and the commit log to find names of people who have
recently modified the same area of code that you are modifying.</p></li>
<li><p>Look in CODE_OWNERS.TXT to see who might be responsible for that area.</p></li>
<li><p>If you’ve discussed the change on a dev list, the people who participated
might be appropriate reviewers.</p></li>
</ul>
<p>Even if you think the code owner is the busiest person in the world, it’s still
okay to put them as a reviewer. Being the code owner means they have accepted
responsibility for making sure the review happens.</p>
</div>
<div class="section" id="reviewing-code-with-phabricator">
<h2><a class="toc-backref" href="#id7">Reviewing code with Phabricator</a><a class="headerlink" href="#reviewing-code-with-phabricator" title="Permalink to this headline">¶</a></h2>
<p>Phabricator allows you to add inline comments as well as overall comments
to a revision. To add an inline comment, select the lines of code you want
to comment on by clicking and dragging the line numbers in the diff pane.
When you have added all your comments, scroll to the bottom of the page and
click the Submit button.</p>
<p>You can add overall comments in the text box at the bottom of the page.
When you’re done, click the Submit button.</p>
<p>Phabricator has many useful features, for example allowing you to select
diffs between different versions of the patch as it was reviewed in the
<em>Revision Update History</em>. Most features are self descriptive - explore, and
if you have a question, drop by on #llvm in IRC to get help.</p>
<p>Note that as e-mail is the system of reference for code reviews, and some
people prefer it over a web interface, we do not generate automated mail
when a review changes state, for example by clicking “Accept Revision” in
the web interface. Thus, please type LGTM into the comment box to accept
a change from Phabricator.</p>
</div>
<div class="section" id="pre-merge-testing">
<span id="id2"></span><h2><a class="toc-backref" href="#id8">Pre-merge testing</a><a class="headerlink" href="#pre-merge-testing" title="Permalink to this headline">¶</a></h2>
<p>The pre-merge tests are a continuous integration (CI) workflow. The workflow
checks the patches uploaded to Phabricator before a user merges them to the main
branch - thus the term <em>pre-merge testing</em>.</p>
<p>When a user uploads a patch to Phabricator, Phabricator triggers the checks and
then displays the results. This way bugs in a patch are contained during the
code review stage and do not pollute the main branch.</p>
<p>If you notice issues or have an idea on how to improve pre-merge checks, please
<a class="reference external" href="https://github.com/google/llvm-premerge-checks/issues/new">create a new issue</a>
or give a ❤️ to an existing one.</p>
<div class="section" id="requirements">
<h3><a class="toc-backref" href="#id9">Requirements</a><a class="headerlink" href="#requirements" title="Permalink to this headline">¶</a></h3>
<p>To get a patch on Phabricator tested, the build server must be able to apply the
patch to the checked out git repository. Please make sure that either:</p>
<ul class="simple">
<li><p>You set a git hash as <code class="docutils literal notranslate"><span class="pre">sourceControlBaseRevision</span></code> in Phabricator which is
available on the GitHub repository,</p></li>
<li><p><strong>or</strong> you define the dependencies of your patch in Phabricator,</p></li>
<li><p><strong>or</strong> your patch can be applied to the main branch.</p></li>
</ul>
<p>Only then can the build server apply the patch locally and run the builds and
tests.</p>
</div>
<div class="section" id="accessing-build-results">
<h3><a class="toc-backref" href="#id10">Accessing build results</a><a class="headerlink" href="#accessing-build-results" title="Permalink to this headline">¶</a></h3>
<p>Phabricator will automatically trigger a build for every new patch you upload or
modify. Phabricator shows the build results at the top of the entry. Clicking on
the links (in the red box) will show more details:</p>
<blockquote>
<div><img alt="_images/Phabricator_premerge_results.png" src="_images/Phabricator_premerge_results.png" />
</div></blockquote>
<p>The CI will compile and run tests, run clang-format and clang-tidy on lines
changed.</p>
<p>If a unit test failed, this is shown below the build status. You can also expand
the unit test to see the details:</p>
<blockquote>
<div><img alt="_images/Phabricator_premerge_unit_tests.png" src="_images/Phabricator_premerge_unit_tests.png" />
</div></blockquote>
</div>
</div>
<div class="section" id="committing-a-change">
<h2><a class="toc-backref" href="#id11">Committing a change</a><a class="headerlink" href="#committing-a-change" title="Permalink to this headline">¶</a></h2>
<p>Once a patch has been reviewed and approved on Phabricator it can then be
committed to trunk. If you do not have commit access, someone has to
commit the change for you (with attribution). It is sufficient to add
a comment to the approved review indicating you cannot commit the patch
yourself. If you have commit access, there are multiple workflows to commit the
change. Whichever method you follow it is recommended that your commit message
ends with the line:</p>
<div class="highlight-default notranslate"><div class="highlight"><pre><span></span><span class="n">Differential</span> <span class="n">Revision</span><span class="p">:</span> <span class="o"><</span><span class="n">URL</span><span class="o">></span>
</pre></div>
</div>
<p>where <code class="docutils literal notranslate"><span class="pre"><URL></span></code> is the URL for the code review, starting with
<code class="docutils literal notranslate"><span class="pre">https://reviews.llvm.org/</span></code>.</p>
<p>This allows people reading the version history to see the review for
context. This also allows Phabricator to detect the commit, close the
review, and add a link from the review to the commit.</p>
<p>Note that if you use the Arcanist tool the <code class="docutils literal notranslate"><span class="pre">Differential</span> <span class="pre">Revision</span></code> line will
be added automatically. If you don’t want to use Arcanist, you can add the
<code class="docutils literal notranslate"><span class="pre">Differential</span> <span class="pre">Revision</span></code> line (as the last line) to the commit message
yourself.</p>
<p>Using the Arcanist tool can simplify the process of committing reviewed code as
it will retrieve reviewers, the <code class="docutils literal notranslate"><span class="pre">Differential</span> <span class="pre">Revision</span></code>, etc from the review
and place it in the commit message. You may also commit an accepted change
directly using <code class="docutils literal notranslate"><span class="pre">git</span> <span class="pre">push</span></code>, per the section in the <a class="reference internal" href="GettingStarted.html#commit-from-git"><span class="std std-ref">getting started
guide</span></a>.</p>
<p>Note that if you commit the change without using Arcanist and forget to add the
<code class="docutils literal notranslate"><span class="pre">Differential</span> <span class="pre">Revision</span></code> line to your commit message then it is recommended
that you close the review manually. In the web UI, under “Leap Into Action” put
the git revision number in the Comment, set the Action to “Close Revision” and
click Submit. Note the review must have been Accepted first.</p>
<div class="section" id="committing-someone-s-change-from-phabricator">
<h3><a class="toc-backref" href="#id12">Committing someone’s change from Phabricator</a><a class="headerlink" href="#committing-someone-s-change-from-phabricator" title="Permalink to this headline">¶</a></h3>
<p>On a clean Git repository on an up to date <code class="docutils literal notranslate"><span class="pre">main</span></code> branch run the
following (where <code class="docutils literal notranslate"><span class="pre"><Revision></span></code> is the Phabricator review number):</p>
<div class="highlight-default notranslate"><div class="highlight"><pre><span></span><span class="n">arc</span> <span class="n">patch</span> <span class="n">D</span><span class="o"><</span><span class="n">Revision</span><span class="o">></span>
</pre></div>
</div>
<p>This will create a new branch called <code class="docutils literal notranslate"><span class="pre">arcpatch-D<Revision></span></code> based on the
current <code class="docutils literal notranslate"><span class="pre">main</span></code> and will create a commit corresponding to <code class="docutils literal notranslate"><span class="pre">D<Revision></span></code> with a
commit message derived from information in the Phabricator review.</p>
<p>Check you are happy with the commit message and amend it if necessary.
For example, ensure the ‘Author’ property of the commit is set to the original author.
You can use a command to correct the author property if it is incorrect:</p>
<div class="highlight-default notranslate"><div class="highlight"><pre><span></span><span class="n">git</span> <span class="n">commit</span> <span class="o">--</span><span class="n">amend</span> <span class="o">--</span><span class="n">author</span><span class="o">=</span><span class="s2">"John Doe <jdoe@llvm.org>"</span>
</pre></div>
</div>
<p>Then, make sure the commit is up-to-date, and commit it. This can be done by running
the following:</p>
<div class="highlight-default notranslate"><div class="highlight"><pre><span></span>git pull --rebase https://github.com/llvm/llvm-project.git main
git show # Ensure the patch looks correct.
ninja check-$whatever # Rerun the appropriate tests if needed.
git push https://github.com/llvm/llvm-project.git HEAD:main
</pre></div>
</div>
</div>
</div>
<div class="section" id="abandoning-a-change">
<h2><a class="toc-backref" href="#id13">Abandoning a change</a><a class="headerlink" href="#abandoning-a-change" title="Permalink to this headline">¶</a></h2>
<p>If you decide you should not commit the patch, you should explicitly abandon
the review so that reviewers don’t think it is still open. In the web UI,
scroll to the bottom of the page where normally you would enter an overall
comment. In the drop-down Action list, which defaults to “Comment,” you should
select “Abandon Revision” and then enter a comment explaining why. Click the
Submit button to finish closing the review.</p>
</div>
<div class="section" id="status">
<h2><a class="toc-backref" href="#id14">Status</a><a class="headerlink" href="#status" title="Permalink to this headline">¶</a></h2>
<p>Please let us know whether you like it and what could be improved! We’re still
working on setting up a bug tracker, but you can email klimek-at-google-dot-com
and chandlerc-at-gmail-dot-com and CC the llvm-dev mailing list with questions
until then. We also could use help implementing improvements. This sadly is
really painful and hard because the Phabricator codebase is in PHP and not as
testable as you might like. However, we’ve put exactly what we’re deploying up
on an <a class="reference external" href="https://github.com/r4nt/llvm-reviews/">llvm-reviews GitHub project</a> where folks can hack on it and post pull
requests. We’re looking into what the right long-term hosting for this is, but
note that it is a derivative of an existing open source project, and so not
trivially a good fit for an official LLVM project.</p>
</div>
</div>
<div class="clearer"></div>
</div>
</div>
</div>
<div class="clearer"></div>
</div>
<div class="related" role="navigation" aria-label="related navigation">
<h3>Navigation</h3>
<ul>
<li class="right" style="margin-right: 10px">
<a href="genindex.html" title="General Index"
>index</a></li>
<li class="right" >
<a href="Passes.html" title="LLVM’s Analysis and Transform Passes"
>next</a> |</li>
<li class="right" >
<a href="NVPTXUsage.html" title="User Guide for NVPTX Back-end"
>previous</a> |</li>
<li><a href="https://llvm.org/">LLVM Home</a> | </li>
<li><a href="index.html">Documentation</a>»</li>
<li class="nav-item nav-item-1"><a href="UserGuides.html" >User Guides</a> »</li>
<li class="nav-item nav-item-this"><a href="">Code Reviews with Phabricator</a></li>
</ul>
</div>
<div class="footer" role="contentinfo">
© Copyright 2003-2021, LLVM Project.
Last updated on 2021-09-18.
Created using <a href="https://www.sphinx-doc.org/">Sphinx</a> 3.5.4.
</div>
</body>
</html>
|
