1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
|
//===--- MutatingCopyCheck.cpp - clang-tidy -------------------------------===//
//
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//
//===----------------------------------------------------------------------===//
#include "MutatingCopyCheck.h"
#include "clang/AST/ASTContext.h"
#include "clang/ASTMatchers/ASTMatchFinder.h"
using namespace clang::ast_matchers;
namespace clang {
namespace tidy {
namespace cert {
static constexpr llvm::StringLiteral SourceDeclName = "ChangedPVD";
static constexpr llvm::StringLiteral MutatingOperatorName = "MutatingOp";
static constexpr llvm::StringLiteral MutatingCallName = "MutatingCall";
void MutatingCopyCheck::registerMatchers(MatchFinder *Finder) {
const auto MemberExprOrSourceObject = anyOf(
memberExpr(),
declRefExpr(to(decl(equalsBoundNode(std::string(SourceDeclName))))));
const auto IsPartOfSource =
allOf(unless(hasDescendant(expr(unless(MemberExprOrSourceObject)))),
MemberExprOrSourceObject);
const auto IsSourceMutatingAssignment = traverse(
TK_AsIs, binaryOperation(hasOperatorName("="), hasLHS(IsPartOfSource))
.bind(MutatingOperatorName));
const auto MemberExprOrSelf = anyOf(memberExpr(), cxxThisExpr());
const auto IsPartOfSelf = allOf(
unless(hasDescendant(expr(unless(MemberExprOrSelf)))), MemberExprOrSelf);
const auto IsSelfMutatingAssignment =
binaryOperation(isAssignmentOperator(), hasLHS(IsPartOfSelf));
const auto IsSelfMutatingMemberFunction =
functionDecl(hasBody(hasDescendant(IsSelfMutatingAssignment)));
const auto IsSourceMutatingMemberCall =
cxxMemberCallExpr(on(IsPartOfSource),
callee(IsSelfMutatingMemberFunction))
.bind(MutatingCallName);
const auto MutatesSource = allOf(
hasParameter(
0, parmVarDecl(hasType(lValueReferenceType())).bind(SourceDeclName)),
anyOf(forEachDescendant(IsSourceMutatingAssignment),
forEachDescendant(IsSourceMutatingMemberCall)));
Finder->addMatcher(cxxConstructorDecl(isCopyConstructor(), MutatesSource),
this);
Finder->addMatcher(cxxMethodDecl(isCopyAssignmentOperator(), MutatesSource),
this);
}
void MutatingCopyCheck::check(const MatchFinder::MatchResult &Result) {
if (const auto *MemberCall =
Result.Nodes.getNodeAs<CXXMemberCallExpr>(MutatingCallName))
diag(MemberCall->getBeginLoc(), "call mutates copied object");
else if (const auto *Assignment =
Result.Nodes.getNodeAs<Expr>(MutatingOperatorName))
diag(Assignment->getBeginLoc(), "mutating copied object");
}
} // namespace cert
} // namespace tidy
} // namespace clang
|
