1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
|
//===--- RedundantAccessSpecifiersCheck.cpp - clang-tidy ------------------===//
//
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//
//===----------------------------------------------------------------------===//
#include "RedundantAccessSpecifiersCheck.h"
#include "clang/AST/ASTContext.h"
#include "clang/ASTMatchers/ASTMatchFinder.h"
using namespace clang::ast_matchers;
namespace clang {
namespace tidy {
namespace readability {
void RedundantAccessSpecifiersCheck::registerMatchers(MatchFinder *Finder) {
Finder->addMatcher(
cxxRecordDecl(has(accessSpecDecl())).bind("redundant-access-specifiers"),
this);
}
void RedundantAccessSpecifiersCheck::check(
const MatchFinder::MatchResult &Result) {
const auto *MatchedDecl =
Result.Nodes.getNodeAs<CXXRecordDecl>("redundant-access-specifiers");
const AccessSpecDecl *LastASDecl = nullptr;
for (DeclContext::specific_decl_iterator<AccessSpecDecl>
AS(MatchedDecl->decls_begin()),
ASEnd(MatchedDecl->decls_end());
AS != ASEnd; ++AS) {
const AccessSpecDecl *ASDecl = *AS;
// Ignore macro expansions.
if (ASDecl->getLocation().isMacroID()) {
LastASDecl = ASDecl;
continue;
}
if (LastASDecl == nullptr) {
// First declaration.
LastASDecl = ASDecl;
if (CheckFirstDeclaration) {
AccessSpecifier DefaultSpecifier =
MatchedDecl->isClass() ? AS_private : AS_public;
if (ASDecl->getAccess() == DefaultSpecifier) {
diag(ASDecl->getLocation(),
"redundant access specifier has the same accessibility as the "
"implicit access specifier")
<< FixItHint::CreateRemoval(ASDecl->getSourceRange());
}
}
continue;
}
if (LastASDecl->getAccess() == ASDecl->getAccess()) {
// Ignore macro expansions.
if (LastASDecl->getLocation().isMacroID()) {
LastASDecl = ASDecl;
continue;
}
diag(ASDecl->getLocation(),
"redundant access specifier has the same accessibility as the "
"previous access specifier")
<< FixItHint::CreateRemoval(ASDecl->getSourceRange());
diag(LastASDecl->getLocation(), "previously declared here",
DiagnosticIDs::Note);
} else {
LastASDecl = ASDecl;
}
}
}
} // namespace readability
} // namespace tidy
} // namespace clang
|
