1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
|
#include "ClangTidy.h"
#include "ClangTidyTest.h"
#include "gtest/gtest.h"
namespace clang {
namespace tidy {
namespace test {
namespace {
class TestCheck : public ClangTidyCheck {
public:
TestCheck(StringRef Name, ClangTidyContext *Context)
: ClangTidyCheck(Name, Context) {
diag("DiagWithNoLoc");
}
void registerMatchers(ast_matchers::MatchFinder *Finder) override {
Finder->addMatcher(ast_matchers::varDecl().bind("var"), this);
}
void check(const ast_matchers::MatchFinder::MatchResult &Result) override {
const auto *Var = Result.Nodes.getNodeAs<VarDecl>("var");
// Add diagnostics in the wrong order.
diag(Var->getLocation(), "variable");
diag(Var->getTypeSpecStartLoc(), "type specifier");
}
};
class HighlightTestCheck : public ClangTidyCheck {
public:
HighlightTestCheck(StringRef Name, ClangTidyContext *Context)
: ClangTidyCheck(Name, Context) {}
void registerMatchers(ast_matchers::MatchFinder *Finder) override {
Finder->addMatcher(ast_matchers::varDecl().bind("var"), this);
}
void check(const ast_matchers::MatchFinder::MatchResult &Result) override {
const auto *Var = Result.Nodes.getNodeAs<VarDecl>("var");
diag(Var->getLocation(), "highlight range") << Var->getSourceRange();
}
};
class InvalidRangeTestCheck : public ClangTidyCheck {
public:
InvalidRangeTestCheck(StringRef Name, ClangTidyContext *Context)
: ClangTidyCheck(Name, Context) {}
void registerMatchers(ast_matchers::MatchFinder *Finder) override {
Finder->addMatcher(ast_matchers::varDecl().bind("var"), this);
}
void check(const ast_matchers::MatchFinder::MatchResult &Result) override {
const auto *Var = Result.Nodes.getNodeAs<VarDecl>("var");
SourceLocation ValidBeginLoc = Var->getBeginLoc();
SourceLocation ValidEndLoc = Var->getEndLoc();
SourceLocation InvalidLoc;
ASSERT_TRUE(ValidBeginLoc.isValid());
ASSERT_TRUE(ValidEndLoc.isValid());
ASSERT_TRUE(InvalidLoc.isInvalid());
diag(ValidBeginLoc, "valid->valid")
<< SourceRange(ValidBeginLoc, ValidEndLoc);
diag(ValidBeginLoc, "valid->invalid")
<< SourceRange(ValidBeginLoc, InvalidLoc);
diag(ValidBeginLoc, "invalid->valid")
<< SourceRange(InvalidLoc, ValidEndLoc);
diag(ValidBeginLoc, "invalid->invalid")
<< SourceRange(InvalidLoc, InvalidLoc);
}
};
} // namespace
TEST(ClangTidyDiagnosticConsumer, SortsErrors) {
std::vector<ClangTidyError> Errors;
runCheckOnCode<TestCheck>("int a;", &Errors);
EXPECT_EQ(3ul, Errors.size());
EXPECT_EQ("DiagWithNoLoc", Errors[0].Message.Message);
EXPECT_EQ("type specifier", Errors[1].Message.Message);
EXPECT_EQ("variable", Errors[2].Message.Message);
}
TEST(ClangTidyDiagnosticConsumer, HandlesSourceRangeHighlight) {
std::vector<ClangTidyError> Errors;
runCheckOnCode<HighlightTestCheck>("int abc;", &Errors);
EXPECT_EQ(1ul, Errors.size());
EXPECT_EQ("highlight range", Errors[0].Message.Message);
// int abc;
// ____^
// 01234
EXPECT_EQ(4ul, Errors[0].Message.FileOffset);
// int abc
// ~~~~~~~ -> Length 7. (0-length highlights are nonsensical.)
EXPECT_EQ(1ul, Errors[0].Message.Ranges.size());
EXPECT_EQ(0ul, Errors[0].Message.Ranges[0].FileOffset);
EXPECT_EQ(7ul, Errors[0].Message.Ranges[0].Length);
}
TEST(ClangTidyDiagnosticConsumer, InvalidSourceLocationRangesIgnored) {
std::vector<ClangTidyError> Errors;
runCheckOnCode<InvalidRangeTestCheck>("int x;", &Errors);
EXPECT_EQ(4ul, Errors.size());
EXPECT_EQ("invalid->invalid", Errors[0].Message.Message);
EXPECT_TRUE(Errors[0].Message.Ranges.empty());
EXPECT_EQ("invalid->valid", Errors[1].Message.Message);
EXPECT_TRUE(Errors[1].Message.Ranges.empty());
EXPECT_EQ("valid->invalid", Errors[2].Message.Message);
EXPECT_TRUE(Errors[2].Message.Ranges.empty());
EXPECT_EQ("valid->valid", Errors[3].Message.Message);
EXPECT_EQ(1ul, Errors[3].Message.Ranges.size());
}
} // namespace test
} // namespace tidy
} // namespace clang
|
