1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366
|
// RUN: %clang_analyze_cc1 -analyzer-checker=core,unix.Malloc,debug.ExprInspection -analyzer-store region -std=c++11 -verify -analyzer-config eagerly-assume=false %s
// RUN: %clang_analyze_cc1 -analyzer-checker=core,unix.Malloc,debug.ExprInspection -analyzer-store region -std=c++11 -DTEST_INLINABLE_ALLOCATORS -verify -analyzer-config eagerly-assume=false %s
#include "Inputs/system-header-simulator-cxx.h"
void clang_analyzer_eval(bool);
typedef __typeof__(sizeof(int)) size_t;
extern "C" void *malloc(size_t);
extern "C" void free(void *);
int someGlobal;
class SomeClass {
public:
void f(int *p);
};
void testImplicitlyDeclaredGlobalNew() {
if (someGlobal != 0)
return;
// This used to crash because the global operator new is being implicitly
// declared and it does not have a valid source location. (PR13090)
void *x = ::operator new(0);
::operator delete(x);
// Check that the new/delete did not invalidate someGlobal;
clang_analyzer_eval(someGlobal == 0); // expected-warning{{TRUE}}
}
void *testPlacementNew() {
int *x = (int *)malloc(sizeof(int));
*x = 1;
clang_analyzer_eval(*x == 1); // expected-warning{{TRUE}};
void *y = new (x) int;
clang_analyzer_eval(x == y); // expected-warning{{TRUE}};
clang_analyzer_eval(*x == 1); // expected-warning{{TRUE}};
return y;
}
void *operator new(size_t, size_t, int *);
void *testCustomNew() {
int x[1] = {1};
clang_analyzer_eval(*x == 1); // expected-warning{{TRUE}};
void *y = new (0, x) int;
clang_analyzer_eval(*x == 1); // expected-warning{{UNKNOWN}};
return y; // no-warning
}
void *operator new(size_t, void *, void *);
void *testCustomNewMalloc() {
int *x = (int *)malloc(sizeof(int));
// Should be no-warning (the custom allocator could have freed x).
void *y = new (0, x) int; // no-warning
return y;
}
void testScalarInitialization() {
int *n = new int(3);
clang_analyzer_eval(*n == 3); // expected-warning{{TRUE}}
new (n) int();
clang_analyzer_eval(*n == 0); // expected-warning{{TRUE}}
new (n) int{3};
clang_analyzer_eval(*n == 3); // expected-warning{{TRUE}}
new (n) int{};
clang_analyzer_eval(*n == 0); // expected-warning{{TRUE}}
}
struct PtrWrapper {
int *x;
PtrWrapper(int *input) : x(input) {}
};
PtrWrapper *testNewInvalidation() {
// Ensure that we don't consider this a leak.
return new PtrWrapper(static_cast<int *>(malloc(4))); // no-warning
}
void testNewInvalidationPlacement(PtrWrapper *w) {
// Ensure that we don't consider this a leak.
new (w) PtrWrapper(static_cast<int *>(malloc(4))); // no-warning
}
int **testNewInvalidationScalar() {
// Ensure that we don't consider this a leak.
return new (int *)(static_cast<int *>(malloc(4))); // no-warning
}
void testNewInvalidationScalarPlacement(int **p) {
// Ensure that we don't consider this a leak.
new (p) (int *)(static_cast<int *>(malloc(4))); // no-warning
}
void testCacheOut(PtrWrapper w) {
extern bool coin();
if (coin())
w.x = 0;
new (&w.x) (int*)(0); // we cache out here; don't crash
}
void testUseAfter(int *p) {
SomeClass *c = new SomeClass;
free(p);
c->f(p); // expected-warning{{Use of memory after it is freed}}
delete c;
}
// new/delete oparators are subjects of cplusplus.NewDelete.
void testNewDeleteNoWarn() {
int i;
delete &i; // no-warning
int *p1 = new int;
delete ++p1; // no-warning
int *p2 = new int;
delete p2;
delete p2; // no-warning
int *p3 = new int; // no-warning
}
void testDeleteMallocked() {
int *x = (int *)malloc(sizeof(int));
// unix.MismatchedDeallocator would catch this, but we're not testing it here.
delete x;
}
void testDeleteOpAfterFree() {
int *p = (int *)malloc(sizeof(int));
free(p);
operator delete(p); // expected-warning{{Use of memory after it is freed}}
}
void testDeleteAfterFree() {
int *p = (int *)malloc(sizeof(int));
free(p);
delete p; // expected-warning{{Use of memory after it is freed}}
}
void testStandardPlacementNewAfterFree() {
int *p = (int *)malloc(sizeof(int));
free(p);
p = new(p) int; // expected-warning{{Use of memory after it is freed}}
}
void testCustomPlacementNewAfterFree() {
int *p = (int *)malloc(sizeof(int));
free(p);
p = new(0, p) int; // expected-warning{{Use of memory after it is freed}}
}
void testUsingThisAfterDelete() {
SomeClass *c = new SomeClass;
delete c;
c->f(0); // no-warning
}
void testAggregateNew() {
struct Point { int x, y; };
new Point{1, 2}; // no crash
Point p;
new (&p) Point{1, 2}; // no crash
clang_analyzer_eval(p.x == 1); // expected-warning{{TRUE}}
clang_analyzer_eval(p.y == 2); // expected-warning{{TRUE}}
}
//--------------------------------
// Incorrectly-modelled behavior
//--------------------------------
int testNoInitialization() {
int *n = new int;
// Should warn that *n is uninitialized.
if (*n) { // no-warning
delete n;
return 0;
}
delete n;
return 1;
}
int testNoInitializationPlacement() {
int n;
new (&n) int;
if (n) { // expected-warning{{Branch condition evaluates to a garbage value}}
return 0;
}
return 1;
}
// Test modelling destructor call on call to delete
class IntPair{
public:
int x;
int y;
IntPair() {};
~IntPair() {x = x/y;}; //expected-warning {{Division by zero}}
};
void testCallToDestructor() {
IntPair *b = new IntPair();
b->x = 1;
b->y = 0;
delete b; // This results in divide by zero in destructor
}
// Test Deleting a value that's passed as an argument.
class DerefClass{
public:
int *x;
DerefClass() {};
~DerefClass() {*x = 1;}; //expected-warning {{Dereference of null pointer (loaded from field 'x')}}
};
void testDestCall(DerefClass *arg) {
delete arg;
}
void test_delete_dtor_Arg() {
DerefClass *pair = new DerefClass();
pair->x = 0;
testDestCall(pair);
}
//Deleting the address of a local variable, null pointer
void abort(void) __attribute__((noreturn));
class NoReturnDtor {
public:
NoReturnDtor() {}
~NoReturnDtor() {abort();}
};
void test_delete_dtor_LocalVar() {
NoReturnDtor test;
delete &test; // no warn or crash
}
class DerivedNoReturn:public NoReturnDtor {
public:
DerivedNoReturn() {};
~DerivedNoReturn() {};
};
void testNullDtorDerived() {
DerivedNoReturn *p = new DerivedNoReturn();
delete p; // Calls the base destructor which aborts, checked below
clang_analyzer_eval(true); // no warn
}
//Deleting a non-class pointer should not crash/warn
void test_var_delete() {
int *v = new int;
delete v; // no crash/warn
clang_analyzer_eval(true); // expected-warning{{TRUE}}
}
void test_array_delete() {
class C {
public:
~C() {}
};
auto c1 = new C[2][3];
delete[] c1; // no-crash // no-warning
C c2[4];
// FIXME: Should warn.
delete[] &c2; // no-crash
C c3[7][6];
// FIXME: Should warn.
delete[] &c3; // no-crash
}
void testDeleteNull() {
NoReturnDtor *foo = 0;
delete foo; // should not call destructor, checked below
clang_analyzer_eval(true); // expected-warning{{TRUE}}
}
void testNullAssigneddtor() {
NoReturnDtor *p = 0;
NoReturnDtor *s = p;
delete s; // should not call destructor, checked below
clang_analyzer_eval(true); // expected-warning{{TRUE}}
}
void deleteArg(NoReturnDtor *test) {
delete test;
}
void testNulldtorArg() {
NoReturnDtor *p = 0;
deleteArg(p);
clang_analyzer_eval(true); // expected-warning{{TRUE}}
}
void testDeleteUnknown(NoReturnDtor *foo) {
delete foo; // should assume non-null and call noreturn destructor
clang_analyzer_eval(true); // no-warning
}
void testArrayNull() {
NoReturnDtor *fooArray = 0;
delete[] fooArray; // should not call destructor, checked below
clang_analyzer_eval(true); // expected-warning{{TRUE}}
}
void testArrayDestr() {
NoReturnDtor *p = new NoReturnDtor[2];
delete[] p; // Calls the base destructor which aborts, checked below
//TODO: clang_analyzer_eval should not be called
clang_analyzer_eval(true); // expected-warning{{TRUE}}
}
// Invalidate Region even in case of default destructor
class InvalidateDestTest {
public:
int x;
int *y;
~InvalidateDestTest();
};
int test_member_invalidation() {
//test invalidation of member variable
InvalidateDestTest *test = new InvalidateDestTest();
test->x = 5;
int *k = &(test->x);
clang_analyzer_eval(*k == 5); // expected-warning{{TRUE}}
delete test;
clang_analyzer_eval(*k == 5); // expected-warning{{UNKNOWN}}
//test invalidation of member pointer
int localVar = 5;
test = new InvalidateDestTest();
test->y = &localVar;
delete test;
clang_analyzer_eval(localVar == 5); // expected-warning{{UNKNOWN}}
// Test aray elements are invalidated.
int Var1 = 5;
int Var2 = 5;
InvalidateDestTest *a = new InvalidateDestTest[2];
a[0].y = &Var1;
a[1].y = &Var2;
delete[] a;
clang_analyzer_eval(Var1 == 5); // expected-warning{{UNKNOWN}}
clang_analyzer_eval(Var2 == 5); // expected-warning{{UNKNOWN}}
return 0;
}
|