File: inefficient-string-concatenation.rst

package info (click to toggle)
llvm-toolchain-15 1%3A15.0.6-4
  • links: PTS, VCS
  • area: main
  • in suites: bookworm
  • size: 1,554,644 kB
  • sloc: cpp: 5,922,452; ansic: 1,012,136; asm: 674,362; python: 191,568; objc: 73,855; f90: 42,327; lisp: 31,913; pascal: 11,973; javascript: 10,144; sh: 9,421; perl: 7,447; ml: 5,527; awk: 3,523; makefile: 2,520; xml: 885; cs: 573; fortran: 567
file content (59 lines) | stat: -rw-r--r-- 1,366 bytes parent folder | download | duplicates (22)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
.. title:: clang-tidy - performance-inefficient-string-concatenation

performance-inefficient-string-concatenation
============================================

This check warns about the performance overhead arising from concatenating
strings using the ``operator+``, for instance:

.. code-block:: c++

    std::string a("Foo"), b("Bar");
    a = a + b;

Instead of this structure you should use ``operator+=`` or ``std::string``'s
(``std::basic_string``) class member function ``append()``. For instance:

.. code-block:: c++

   std::string a("Foo"), b("Baz");
   for (int i = 0; i < 20000; ++i) {
       a = a + "Bar" + b;
   }

Could be rewritten in a greatly more efficient way like:

.. code-block:: c++

   std::string a("Foo"), b("Baz");
   for (int i = 0; i < 20000; ++i) {
       a.append("Bar").append(b);
   }

And this can be rewritten too:

.. code-block:: c++

   void f(const std::string&) {}
   std::string a("Foo"), b("Baz");
   void g() {
       f(a + "Bar" + b);
   }

In a slightly more efficient way like:

.. code-block:: c++

   void f(const std::string&) {}
   std::string a("Foo"), b("Baz");
   void g() {
       f(std::string(a).append("Bar").append(b));
   }

Options
-------

.. option:: StrictMode

   When `false`, the check will only check the string usage in ``while``, ``for``
   and ``for-range`` statements. Default is `false`.