1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
|
// RUN: %check_clang_tidy %s bugprone-assert-side-effect %t -- -config="{CheckOptions: [{key: bugprone-assert-side-effect.CheckFunctionCalls, value: true}, {key: bugprone-assert-side-effect.AssertMacros, value: 'assert,assert2,my_assert,convoluted_assert,msvc_assert'}, {key: bugprone-assert-side-effect.IgnoredFunctions, value: 'MyClass::badButIgnoredFunc'}]}" -- -fexceptions
//===--- assert definition block ------------------------------------------===//
int abort() { return 0; }
#ifdef NDEBUG
#define assert(x) 1
#else
#define assert(x) \
if (!(x)) \
(void)abort()
#endif
void print(...);
#define assert2(e) (__builtin_expect(!(e), 0) ? \
print (#e, __FILE__, __LINE__) : (void)0)
#ifdef NDEBUG
#define my_assert(x) 1
#else
#define my_assert(x) \
((void)((x) ? 1 : abort()))
#endif
#ifdef NDEBUG
#define not_my_assert(x) 1
#else
#define not_my_assert(x) \
if (!(x)) \
(void)abort()
#endif
#define real_assert(x) ((void)((x) ? 1 : abort()))
#define wrap1(x) real_assert(x)
#define wrap2(x) wrap1(x)
#define convoluted_assert(x) wrap2(x)
#define msvc_assert(expression) (void)( \
(!!(expression)) || \
(abort(), 0) \
)
//===----------------------------------------------------------------------===//
bool badButIgnoredFunc(int a, int b) { return a * b > 0; }
class MyClass {
public:
bool badFunc(int a, int b) { return a * b > 0; }
bool badButIgnoredFunc(int a, int b) { return a * b > 0; }
bool goodFunc(int a, int b) const { return a * b > 0; }
MyClass &operator=(const MyClass &rhs) { return *this; }
int operator-() { return 1; }
operator bool() const { return true; }
void operator delete(void *p) {}
};
class SomeoneElseClass {
public:
bool badButIgnoredFunc(int a, int b) { return a * b > 0; }
};
bool freeFunction() {
return true;
}
int main() {
int X = 0;
bool B = false;
assert(X == 1);
assert(X = 1);
// CHECK-MESSAGES: :[[@LINE-1]]:3: warning: side effect in assert() condition discarded in release builds [bugprone-assert-side-effect]
my_assert(X = 1);
// CHECK-MESSAGES: :[[@LINE-1]]:3: warning: side effect in my_assert() condition discarded in release builds
convoluted_assert(X = 1);
// CHECK-MESSAGES: :[[@LINE-1]]:3: warning: side effect in convoluted_assert() condition discarded in release builds
not_my_assert(X = 1);
assert(++X);
// CHECK-MESSAGES: :[[@LINE-1]]:3: warning: side effect in assert() condition discarded in release builds
assert(!B);
assert(B || true);
assert(freeFunction());
// CHECK-MESSAGES: :[[@LINE-1]]:3: warning: side effect in assert() condition discarded in release builds
MyClass mc;
SomeoneElseClass sec;
assert(mc.badFunc(0, 1));
// CHECK-MESSAGES: :[[@LINE-1]]:3: warning: side effect in assert() condition discarded in release builds
assert(mc.badButIgnoredFunc(0, 1));
// badButIgnoredFunc is not ignored as only class members are ignored by the config
assert(badButIgnoredFunc(0, 1));
// CHECK-MESSAGES: :[[@LINE-1]]:3: warning: side effect in assert() condition discarded in release builds
// sec.badButIgnoredFunc is not ignored as only MyClass members are ignored by the config
assert(sec.badButIgnoredFunc(0, 1));
// CHECK-MESSAGES: :[[@LINE-1]]:3: warning: side effect in assert() condition discarded in release builds
assert(mc.goodFunc(0, 1));
MyClass mc2;
assert(mc2 = mc);
// CHECK-MESSAGES: :[[@LINE-1]]:3: warning: side effect in assert() condition discarded in release builds
assert(-mc > 0);
MyClass *mcp;
assert(mcp = new MyClass);
// CHECK-MESSAGES: :[[@LINE-1]]:3: warning: side effect in assert() condition discarded in release builds
assert((delete mcp, false));
// CHECK-MESSAGES: :[[@LINE-1]]:3: warning: side effect in assert() condition discarded in release builds
assert((throw 1, false));
// CHECK-MESSAGES: :[[@LINE-1]]:3: warning: side effect in assert() condition discarded in release builds
assert2(1 == 2 - 1);
msvc_assert(mc2 = mc);
// CHECK-MESSAGES: :[[@LINE-1]]:3: warning: side effect in msvc_assert() condition discarded in release builds
return 0;
}
|
