1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249
|
//=== ErrnoChecker.cpp ------------------------------------------*- C++ -*-===//
//
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//
//===----------------------------------------------------------------------===//
//
// This defines an "errno checker" that can detect some invalid use of the
// system-defined value 'errno'. This checker works together with the
// ErrnoModeling checker and other checkers like StdCLibraryFunctions.
//
//===----------------------------------------------------------------------===//
#include "ErrnoModeling.h"
#include "clang/AST/ParentMapContext.h"
#include "clang/StaticAnalyzer/Checkers/BuiltinCheckerRegistration.h"
#include "clang/StaticAnalyzer/Core/Checker.h"
#include "clang/StaticAnalyzer/Core/CheckerManager.h"
#include "clang/StaticAnalyzer/Core/PathSensitive/CallDescription.h"
#include "clang/StaticAnalyzer/Core/PathSensitive/CheckerContext.h"
#include "clang/StaticAnalyzer/Core/PathSensitive/ProgramState.h"
#include "clang/StaticAnalyzer/Core/PathSensitive/SVals.h"
#include "llvm/ADT/STLExtras.h"
using namespace clang;
using namespace ento;
using namespace errno_modeling;
namespace {
class ErrnoChecker
: public Checker<check::Location, check::PreCall, check::RegionChanges> {
public:
void checkLocation(SVal Loc, bool IsLoad, const Stmt *S,
CheckerContext &) const;
void checkPreCall(const CallEvent &Call, CheckerContext &C) const;
ProgramStateRef
checkRegionChanges(ProgramStateRef State,
const InvalidatedSymbols *Invalidated,
ArrayRef<const MemRegion *> ExplicitRegions,
ArrayRef<const MemRegion *> Regions,
const LocationContext *LCtx, const CallEvent *Call) const;
void checkBranchCondition(const Stmt *Condition, CheckerContext &Ctx) const;
/// Indicates if a read (load) of \c errno is allowed in a non-condition part
/// of \c if, \c switch, loop and conditional statements when the errno
/// value may be undefined.
bool AllowErrnoReadOutsideConditions = true;
private:
void generateErrnoNotCheckedBug(CheckerContext &C, ProgramStateRef State,
const MemRegion *ErrnoRegion,
const CallEvent *CallMayChangeErrno) const;
BugType BT_InvalidErrnoRead{this, "Value of 'errno' could be undefined",
"Error handling"};
BugType BT_ErrnoNotChecked{this, "Value of 'errno' was not checked",
"Error handling"};
};
} // namespace
static ProgramStateRef setErrnoStateIrrelevant(ProgramStateRef State) {
return setErrnoState(State, Irrelevant);
}
/// Check if a statement (expression) or an ancestor of it is in a condition
/// part of a (conditional, loop, switch) statement.
static bool isInCondition(const Stmt *S, CheckerContext &C) {
ParentMapContext &ParentCtx = C.getASTContext().getParentMapContext();
bool CondFound = false;
while (S && !CondFound) {
const DynTypedNodeList Parents = ParentCtx.getParents(*S);
if (Parents.empty())
break;
const auto *ParentS = Parents[0].get<Stmt>();
if (!ParentS || isa<CallExpr>(ParentS))
break;
switch (ParentS->getStmtClass()) {
case Expr::IfStmtClass:
CondFound = (S == cast<IfStmt>(ParentS)->getCond());
break;
case Expr::ForStmtClass:
CondFound = (S == cast<ForStmt>(ParentS)->getCond());
break;
case Expr::DoStmtClass:
CondFound = (S == cast<DoStmt>(ParentS)->getCond());
break;
case Expr::WhileStmtClass:
CondFound = (S == cast<WhileStmt>(ParentS)->getCond());
break;
case Expr::SwitchStmtClass:
CondFound = (S == cast<SwitchStmt>(ParentS)->getCond());
break;
case Expr::ConditionalOperatorClass:
CondFound = (S == cast<ConditionalOperator>(ParentS)->getCond());
break;
case Expr::BinaryConditionalOperatorClass:
CondFound = (S == cast<BinaryConditionalOperator>(ParentS)->getCommon());
break;
default:
break;
}
S = ParentS;
}
return CondFound;
}
void ErrnoChecker::generateErrnoNotCheckedBug(
CheckerContext &C, ProgramStateRef State, const MemRegion *ErrnoRegion,
const CallEvent *CallMayChangeErrno) const {
if (ExplodedNode *N = C.generateNonFatalErrorNode(State)) {
SmallString<100> StrBuf;
llvm::raw_svector_ostream OS(StrBuf);
if (CallMayChangeErrno) {
OS << "Value of 'errno' was not checked and may be overwritten by "
"function '";
const auto *CallD =
dyn_cast_or_null<FunctionDecl>(CallMayChangeErrno->getDecl());
assert(CallD && CallD->getIdentifier());
OS << CallD->getIdentifier()->getName() << "'";
} else {
OS << "Value of 'errno' was not checked and is overwritten here";
}
auto BR = std::make_unique<PathSensitiveBugReport>(BT_ErrnoNotChecked,
OS.str(), N);
BR->markInteresting(ErrnoRegion);
C.emitReport(std::move(BR));
}
}
void ErrnoChecker::checkLocation(SVal Loc, bool IsLoad, const Stmt *S,
CheckerContext &C) const {
Optional<ento::Loc> ErrnoLoc = getErrnoLoc(C.getState());
if (!ErrnoLoc)
return;
auto L = Loc.getAs<ento::Loc>();
if (!L || *ErrnoLoc != *L)
return;
ProgramStateRef State = C.getState();
ErrnoCheckState EState = getErrnoState(State);
if (IsLoad) {
switch (EState) {
case MustNotBeChecked:
// Read of 'errno' when it may have undefined value.
if (!AllowErrnoReadOutsideConditions || isInCondition(S, C)) {
if (ExplodedNode *N = C.generateErrorNode()) {
auto BR = std::make_unique<PathSensitiveBugReport>(
BT_InvalidErrnoRead,
"An undefined value may be read from 'errno'", N);
BR->markInteresting(ErrnoLoc->getAsRegion());
C.emitReport(std::move(BR));
}
}
break;
case MustBeChecked:
// 'errno' has to be checked. A load is required for this, with no more
// information we can assume that it is checked somehow.
// After this place 'errno' is allowed to be read and written.
State = setErrnoStateIrrelevant(State);
C.addTransition(State);
break;
default:
break;
}
} else {
switch (EState) {
case MustBeChecked:
// 'errno' is overwritten without a read before but it should have been
// checked.
generateErrnoNotCheckedBug(C, setErrnoStateIrrelevant(State),
ErrnoLoc->getAsRegion(), nullptr);
break;
case MustNotBeChecked:
// Write to 'errno' when it is not allowed to be read.
// After this place 'errno' is allowed to be read and written.
State = setErrnoStateIrrelevant(State);
C.addTransition(State);
break;
default:
break;
}
}
}
void ErrnoChecker::checkPreCall(const CallEvent &Call,
CheckerContext &C) const {
const auto *CallF = dyn_cast_or_null<FunctionDecl>(Call.getDecl());
if (!CallF)
return;
CallF = CallF->getCanonicalDecl();
// If 'errno' must be checked, it should be done as soon as possible, and
// before any other call to a system function (something in a system header).
// To avoid use of a long list of functions that may change 'errno'
// (which may be different with standard library versions) assume that any
// function can change it.
// A list of special functions can be used that are allowed here without
// generation of diagnostic. For now the only such case is 'errno' itself.
// Probably 'strerror'?
if (CallF->isExternC() && CallF->isGlobal() &&
C.getSourceManager().isInSystemHeader(CallF->getLocation()) &&
!isErrno(CallF)) {
if (getErrnoState(C.getState()) == MustBeChecked) {
Optional<ento::Loc> ErrnoLoc = getErrnoLoc(C.getState());
assert(ErrnoLoc && "ErrnoLoc should exist if an errno state is set.");
generateErrnoNotCheckedBug(C, setErrnoStateIrrelevant(C.getState()),
ErrnoLoc->getAsRegion(), &Call);
}
}
}
ProgramStateRef ErrnoChecker::checkRegionChanges(
ProgramStateRef State, const InvalidatedSymbols *Invalidated,
ArrayRef<const MemRegion *> ExplicitRegions,
ArrayRef<const MemRegion *> Regions, const LocationContext *LCtx,
const CallEvent *Call) const {
Optional<ento::Loc> ErrnoLoc = getErrnoLoc(State);
if (!ErrnoLoc)
return State;
const MemRegion *ErrnoRegion = ErrnoLoc->getAsRegion();
// If 'errno' is invalidated we can not know if it is checked or written into,
// allow read and write without bug reports.
if (llvm::is_contained(Regions, ErrnoRegion))
return setErrnoStateIrrelevant(State);
// Always reset errno state when the system memory space is invalidated.
// The ErrnoRegion is not always found in the list in this case.
if (llvm::is_contained(Regions, ErrnoRegion->getMemorySpace()))
return setErrnoStateIrrelevant(State);
return State;
}
void ento::registerErrnoChecker(CheckerManager &mgr) {
const AnalyzerOptions &Opts = mgr.getAnalyzerOptions();
auto *Checker = mgr.registerChecker<ErrnoChecker>();
Checker->AllowErrnoReadOutsideConditions = Opts.getCheckerBooleanOption(
Checker, "AllowErrnoReadOutsideConditionExpressions");
}
bool ento::shouldRegisterErrnoChecker(const CheckerManager &mgr) {
return true;
}
|