1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329
|
//=== VLASizeChecker.cpp - Undefined dereference checker --------*- C++ -*-===//
//
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//
//===----------------------------------------------------------------------===//
//
// This defines VLASizeChecker, a builtin check in ExprEngine that
// performs checks for declaration of VLA of undefined or zero size.
// In addition, VLASizeChecker is responsible for defining the extent
// of the MemRegion that represents a VLA.
//
//===----------------------------------------------------------------------===//
#include "clang/AST/CharUnits.h"
#include "clang/StaticAnalyzer/Checkers/BuiltinCheckerRegistration.h"
#include "clang/StaticAnalyzer/Checkers/Taint.h"
#include "clang/StaticAnalyzer/Core/BugReporter/BugType.h"
#include "clang/StaticAnalyzer/Core/Checker.h"
#include "clang/StaticAnalyzer/Core/CheckerManager.h"
#include "clang/StaticAnalyzer/Core/PathSensitive/CheckerContext.h"
#include "clang/StaticAnalyzer/Core/PathSensitive/DynamicExtent.h"
#include "llvm/ADT/STLExtras.h"
#include "llvm/ADT/SmallString.h"
#include "llvm/Support/raw_ostream.h"
using namespace clang;
using namespace ento;
using namespace taint;
namespace {
class VLASizeChecker
: public Checker<check::PreStmt<DeclStmt>,
check::PreStmt<UnaryExprOrTypeTraitExpr>> {
mutable std::unique_ptr<BugType> BT;
enum VLASize_Kind {
VLA_Garbage,
VLA_Zero,
VLA_Tainted,
VLA_Negative,
VLA_Overflow
};
/// Check a VLA for validity.
/// Every dimension of the array and the total size is checked for validity.
/// Returns null or a new state where the size is validated.
/// 'ArraySize' will contain SVal that refers to the total size (in char)
/// of the array.
ProgramStateRef checkVLA(CheckerContext &C, ProgramStateRef State,
const VariableArrayType *VLA, SVal &ArraySize) const;
/// Check a single VLA index size expression for validity.
ProgramStateRef checkVLAIndexSize(CheckerContext &C, ProgramStateRef State,
const Expr *SizeE) const;
void reportBug(VLASize_Kind Kind, const Expr *SizeE, ProgramStateRef State,
CheckerContext &C,
std::unique_ptr<BugReporterVisitor> Visitor = nullptr) const;
public:
void checkPreStmt(const DeclStmt *DS, CheckerContext &C) const;
void checkPreStmt(const UnaryExprOrTypeTraitExpr *UETTE,
CheckerContext &C) const;
};
} // end anonymous namespace
ProgramStateRef VLASizeChecker::checkVLA(CheckerContext &C,
ProgramStateRef State,
const VariableArrayType *VLA,
SVal &ArraySize) const {
assert(VLA && "Function should be called with non-null VLA argument.");
const VariableArrayType *VLALast = nullptr;
llvm::SmallVector<const Expr *, 2> VLASizes;
// Walk over the VLAs for every dimension until a non-VLA is found.
// There is a VariableArrayType for every dimension (fixed or variable) until
// the most inner array that is variably modified.
// Dimension sizes are collected into 'VLASizes'. 'VLALast' is set to the
// innermost VLA that was encountered.
// In "int vla[x][2][y][3]" this will be the array for index "y" (with type
// int[3]). 'VLASizes' contains 'x', '2', and 'y'.
while (VLA) {
const Expr *SizeE = VLA->getSizeExpr();
State = checkVLAIndexSize(C, State, SizeE);
if (!State)
return nullptr;
VLASizes.push_back(SizeE);
VLALast = VLA;
VLA = C.getASTContext().getAsVariableArrayType(VLA->getElementType());
};
assert(VLALast &&
"Array should have at least one variably-modified dimension.");
ASTContext &Ctx = C.getASTContext();
SValBuilder &SVB = C.getSValBuilder();
CanQualType SizeTy = Ctx.getSizeType();
uint64_t SizeMax =
SVB.getBasicValueFactory().getMaxValue(SizeTy).getZExtValue();
// Get the element size.
CharUnits EleSize = Ctx.getTypeSizeInChars(VLALast->getElementType());
NonLoc ArrSize =
SVB.makeIntVal(EleSize.getQuantity(), SizeTy).castAs<NonLoc>();
// Try to calculate the known real size of the array in KnownSize.
uint64_t KnownSize = 0;
if (const llvm::APSInt *KV = SVB.getKnownValue(State, ArrSize))
KnownSize = KV->getZExtValue();
for (const Expr *SizeE : VLASizes) {
auto SizeD = C.getSVal(SizeE).castAs<DefinedSVal>();
// Convert the array length to size_t.
NonLoc IndexLength =
SVB.evalCast(SizeD, SizeTy, SizeE->getType()).castAs<NonLoc>();
// Multiply the array length by the element size.
SVal Mul = SVB.evalBinOpNN(State, BO_Mul, ArrSize, IndexLength, SizeTy);
if (auto MulNonLoc = Mul.getAs<NonLoc>())
ArrSize = *MulNonLoc;
else
// Extent could not be determined.
return State;
if (const llvm::APSInt *IndexLVal = SVB.getKnownValue(State, IndexLength)) {
// Check if the array size will overflow.
// Size overflow check does not work with symbolic expressions because a
// overflow situation can not be detected easily.
uint64_t IndexL = IndexLVal->getZExtValue();
// FIXME: See https://reviews.llvm.org/D80903 for discussion of
// some difference in assume and getKnownValue that leads to
// unexpected behavior. Just bail on IndexL == 0 at this point.
if (IndexL == 0)
return nullptr;
if (KnownSize <= SizeMax / IndexL) {
KnownSize *= IndexL;
} else {
// Array size does not fit into size_t.
reportBug(VLA_Overflow, SizeE, State, C);
return nullptr;
}
} else {
KnownSize = 0;
}
}
ArraySize = ArrSize;
return State;
}
ProgramStateRef VLASizeChecker::checkVLAIndexSize(CheckerContext &C,
ProgramStateRef State,
const Expr *SizeE) const {
SVal SizeV = C.getSVal(SizeE);
if (SizeV.isUndef()) {
reportBug(VLA_Garbage, SizeE, State, C);
return nullptr;
}
// See if the size value is known. It can't be undefined because we would have
// warned about that already.
if (SizeV.isUnknown())
return nullptr;
// Check if the size is tainted.
if (isTainted(State, SizeV)) {
reportBug(VLA_Tainted, SizeE, nullptr, C,
std::make_unique<TaintBugVisitor>(SizeV));
return nullptr;
}
// Check if the size is zero.
DefinedSVal SizeD = SizeV.castAs<DefinedSVal>();
ProgramStateRef StateNotZero, StateZero;
std::tie(StateNotZero, StateZero) = State->assume(SizeD);
if (StateZero && !StateNotZero) {
reportBug(VLA_Zero, SizeE, StateZero, C);
return nullptr;
}
// From this point on, assume that the size is not zero.
State = StateNotZero;
// Check if the size is negative.
SValBuilder &SVB = C.getSValBuilder();
QualType SizeTy = SizeE->getType();
DefinedOrUnknownSVal Zero = SVB.makeZeroVal(SizeTy);
SVal LessThanZeroVal = SVB.evalBinOp(State, BO_LT, SizeD, Zero, SizeTy);
if (Optional<DefinedSVal> LessThanZeroDVal =
LessThanZeroVal.getAs<DefinedSVal>()) {
ConstraintManager &CM = C.getConstraintManager();
ProgramStateRef StatePos, StateNeg;
std::tie(StateNeg, StatePos) = CM.assumeDual(State, *LessThanZeroDVal);
if (StateNeg && !StatePos) {
reportBug(VLA_Negative, SizeE, State, C);
return nullptr;
}
State = StatePos;
}
return State;
}
void VLASizeChecker::reportBug(
VLASize_Kind Kind, const Expr *SizeE, ProgramStateRef State,
CheckerContext &C, std::unique_ptr<BugReporterVisitor> Visitor) const {
// Generate an error node.
ExplodedNode *N = C.generateErrorNode(State);
if (!N)
return;
if (!BT)
BT.reset(new BuiltinBug(
this, "Dangerous variable-length array (VLA) declaration"));
SmallString<256> buf;
llvm::raw_svector_ostream os(buf);
os << "Declared variable-length array (VLA) ";
switch (Kind) {
case VLA_Garbage:
os << "uses a garbage value as its size";
break;
case VLA_Zero:
os << "has zero size";
break;
case VLA_Tainted:
os << "has tainted size";
break;
case VLA_Negative:
os << "has negative size";
break;
case VLA_Overflow:
os << "has too large size";
break;
}
auto report = std::make_unique<PathSensitiveBugReport>(*BT, os.str(), N);
report->addVisitor(std::move(Visitor));
report->addRange(SizeE->getSourceRange());
bugreporter::trackExpressionValue(N, SizeE, *report);
C.emitReport(std::move(report));
}
void VLASizeChecker::checkPreStmt(const DeclStmt *DS, CheckerContext &C) const {
if (!DS->isSingleDecl())
return;
ASTContext &Ctx = C.getASTContext();
SValBuilder &SVB = C.getSValBuilder();
ProgramStateRef State = C.getState();
QualType TypeToCheck;
const VarDecl *VD = dyn_cast<VarDecl>(DS->getSingleDecl());
if (VD)
TypeToCheck = VD->getType().getCanonicalType();
else if (const auto *TND = dyn_cast<TypedefNameDecl>(DS->getSingleDecl()))
TypeToCheck = TND->getUnderlyingType().getCanonicalType();
else
return;
const VariableArrayType *VLA = Ctx.getAsVariableArrayType(TypeToCheck);
if (!VLA)
return;
// Check the VLA sizes for validity.
SVal ArraySize;
State = checkVLA(C, State, VLA, ArraySize);
if (!State)
return;
if (!isa<NonLoc>(ArraySize)) {
// Array size could not be determined but state may contain new assumptions.
C.addTransition(State);
return;
}
// VLASizeChecker is responsible for defining the extent of the array.
if (VD) {
State =
setDynamicExtent(State, State->getRegion(VD, C.getLocationContext()),
ArraySize.castAs<NonLoc>(), SVB);
}
// Remember our assumptions!
C.addTransition(State);
}
void VLASizeChecker::checkPreStmt(const UnaryExprOrTypeTraitExpr *UETTE,
CheckerContext &C) const {
// Want to check for sizeof.
if (UETTE->getKind() != UETT_SizeOf)
return;
// Ensure a type argument.
if (!UETTE->isArgumentType())
return;
const VariableArrayType *VLA = C.getASTContext().getAsVariableArrayType(
UETTE->getTypeOfArgument().getCanonicalType());
// Ensure that the type is a VLA.
if (!VLA)
return;
ProgramStateRef State = C.getState();
SVal ArraySize;
State = checkVLA(C, State, VLA, ArraySize);
if (!State)
return;
C.addTransition(State);
}
void ento::registerVLASizeChecker(CheckerManager &mgr) {
mgr.registerChecker<VLASizeChecker>();
}
bool ento::shouldRegisterVLASizeChecker(const CheckerManager &mgr) {
return true;
}
|