1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
|
//===--- MisleadingCaptureDefaultByValueCheck.cpp - clang-tidy-------------===//
//
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//
//===----------------------------------------------------------------------===//
#include "MisleadingCaptureDefaultByValueCheck.h"
#include "../utils/LexerUtils.h"
#include "clang/AST/ASTContext.h"
#include "clang/ASTMatchers/ASTMatchFinder.h"
#include "llvm/Support/raw_ostream.h"
#include <algorithm>
using namespace clang::ast_matchers;
namespace clang::tidy::cppcoreguidelines {
MisleadingCaptureDefaultByValueCheck::MisleadingCaptureDefaultByValueCheck(
StringRef Name, ClangTidyContext *Context)
: ClangTidyCheck(Name, Context) {}
void MisleadingCaptureDefaultByValueCheck::registerMatchers(
MatchFinder *Finder) {
Finder->addMatcher(lambdaExpr(hasAnyCapture(capturesThis())).bind("lambda"),
this);
}
static SourceLocation findDefaultCaptureEnd(const LambdaExpr *Lambda,
ASTContext &Context) {
for (const LambdaCapture &Capture : Lambda->explicit_captures()) {
if (Capture.isExplicit()) {
if (Capture.getCaptureKind() == LCK_ByRef) {
const SourceManager &SourceMgr = Context.getSourceManager();
SourceLocation AddressofLoc = utils::lexer::findPreviousTokenKind(
Capture.getLocation(), SourceMgr, Context.getLangOpts(), tok::amp);
return AddressofLoc;
} else {
return Capture.getLocation();
}
}
}
return Lambda->getIntroducerRange().getEnd();
}
static std::string createReplacementText(const LambdaExpr *Lambda) {
std::string Replacement;
llvm::raw_string_ostream Stream(Replacement);
auto AppendName = [&](llvm::StringRef Name) {
if (Replacement.size() != 0) {
Stream << ", ";
}
if (Lambda->getCaptureDefault() == LCD_ByRef && Name != "this") {
Stream << "&" << Name;
} else {
Stream << Name;
}
};
for (const LambdaCapture &Capture : Lambda->implicit_captures()) {
assert(Capture.isImplicit());
if (Capture.capturesVariable() && Capture.isImplicit()) {
AppendName(Capture.getCapturedVar()->getName());
} else if (Capture.capturesThis()) {
AppendName("this");
}
}
if (Replacement.size() &&
Lambda->explicit_capture_begin() != Lambda->explicit_capture_end()) {
// Add back separator if we are adding explicit capture variables.
Stream << ", ";
}
return Replacement;
}
void MisleadingCaptureDefaultByValueCheck::check(
const MatchFinder::MatchResult &Result) {
const auto *Lambda = Result.Nodes.getNodeAs<LambdaExpr>("lambda");
if (!Lambda)
return;
if (Lambda->getCaptureDefault() == LCD_ByCopy) {
bool IsThisImplicitlyCaptured = std::any_of(
Lambda->implicit_capture_begin(), Lambda->implicit_capture_end(),
[](const LambdaCapture &Capture) { return Capture.capturesThis(); });
auto Diag = diag(Lambda->getCaptureDefaultLoc(),
"lambdas that %select{|implicitly }0capture 'this' "
"should not specify a by-value capture default")
<< IsThisImplicitlyCaptured;
std::string ReplacementText = createReplacementText(Lambda);
SourceLocation DefaultCaptureEnd =
findDefaultCaptureEnd(Lambda, *Result.Context);
Diag << FixItHint::CreateReplacement(
CharSourceRange::getCharRange(Lambda->getCaptureDefaultLoc(),
DefaultCaptureEnd),
ReplacementText);
}
}
} // namespace clang::tidy::cppcoreguidelines
|
