1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
|
// RUN: %check_clang_tidy %s abseil-cleanup-ctad -std=c++17 %t
namespace std {
template <typename, typename>
struct is_same {
static const bool value = false;
};
template <typename T>
struct is_same<T, T> { static const bool value = true; };
template <typename>
class function {
public:
template <typename T>
function(T) {}
function(const function &) {}
};
} // namespace std
namespace absl {
namespace cleanup_internal {
struct Tag {};
template <typename Callback>
class Storage {
public:
Storage() = delete;
explicit Storage(Callback callback) {}
Storage(Storage &&other) {}
Storage(const Storage &other) = delete;
Storage &operator=(Storage &&other) = delete;
Storage &operator=(const Storage &other) = delete;
private:
bool is_callback_engaged_;
alignas(Callback) char callback_buffer_[sizeof(Callback)];
};
} // namespace cleanup_internal
template <typename Arg, typename Callback = void()>
class Cleanup final {
public:
Cleanup(Callback callback) // NOLINT
: storage_(static_cast<Callback &&>(callback)) {}
Cleanup(Cleanup &&other) = default;
void Cancel() &&;
void Invoke() &&;
~Cleanup();
private:
cleanup_internal::Storage<Callback> storage_;
};
template <typename Callback>
Cleanup(Callback callback) -> Cleanup<cleanup_internal::Tag, Callback>;
template <typename... Args, typename Callback>
absl::Cleanup<cleanup_internal::Tag, Callback> MakeCleanup(Callback callback) {
return {static_cast<Callback &&>(callback)};
}
} // namespace absl
void test() {
auto a = absl::MakeCleanup([] {});
// CHECK-MESSAGES: :[[@LINE-1]]:3: warning: prefer absl::Cleanup's class template argument deduction pattern in C++17 and higher
// CHECK-FIXES: {{^}} absl::Cleanup a = [] {};{{$}}
auto b = absl::MakeCleanup(std::function<void()>([] {}));
// CHECK-MESSAGES: :[[@LINE-1]]:3: warning: prefer absl::Cleanup{{.*}}C++17 and higher
// CHECK-FIXES: {{^}} absl::Cleanup b = std::function<void()>([] {});{{$}}
const auto c = absl::MakeCleanup([] {});
// CHECK-MESSAGES: :[[@LINE-1]]:9: warning: prefer absl::Cleanup{{.*}}C++17 and higher
// CHECK-FIXES: {{^}} const absl::Cleanup c = [] {};{{$}}
const auto d = absl::MakeCleanup(std::function<void()>([] {}));
// CHECK-MESSAGES: :[[@LINE-1]]:9: warning: prefer absl::Cleanup{{.*}}C++17 and higher
// CHECK-FIXES: {{^}} const absl::Cleanup d = std::function<void()>([] {});{{$}}
// Preserves extra parens
auto e = absl::MakeCleanup(([] {}));
// CHECK-MESSAGES: :[[@LINE-1]]:3: warning: prefer absl::Cleanup{{.*}}C++17 and higher
// CHECK-FIXES: {{^}} absl::Cleanup e = ([] {});{{$}}
// Preserves comments
auto f = /* a */ absl::MakeCleanup(/* b */ [] { /* c */ } /* d */) /* e */;
// CHECK-MESSAGES: :[[@LINE-1]]:3: warning: prefer absl::Cleanup{{.*}}C++17 and higher
// CHECK-FIXES: {{^}} absl::Cleanup f = /* a */ /* b */ [] { /* c */ } /* d */ /* e */;{{$}}
}
|
